Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Babel Plugin - Mock css imports #1606

Closed
bmingles opened this issue Oct 31, 2023 · 0 comments · Fixed by #1607 or deephaven/deephaven-core#4770
Closed

Babel Plugin - Mock css imports #1606

bmingles opened this issue Oct 31, 2023 · 0 comments · Fixed by #1607 or deephaven/deephaven-core#4770
Assignees
@bmingles
Labels
enhancement New feature or request web-client-ui

Comments

@bmingles
Copy link
Contributor

Mocking css imports doesn't provide a good way to differentiate different css modules without creating a 1 to 1 mapping of mock modules. We should be able to improve this via a custom Babel transform plugin.
@bmingles bmingles added enhancement New feature or request triage Issue requires triage labels Oct 31, 2023
@bmingles bmingles self-assigned this Oct 31, 2023
@bmingles bmingles added web-client-ui and removed triage Issue requires triage labels Oct 31, 2023
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 31, 2023
@bmingles
Babel plugin to mock css imports
8f22bf9 
deephaven#1606
@bmingles bmingles mentioned this issue Oct 31, 2023
Merged
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 31, 2023
@bmingles
Exports for babel plugins
3856307 
deephaven#1606
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 31, 2023
@bmingles
Fixed export map
4ce37bc 
deephaven#1606
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 31, 2023
@bmingles
Renamed function
9b6bcd8 
deephaven#1606
bmingles added a commit that referenced this issue Nov 1, 2023
@bmingles
feat: Babel Plugin - Mock css imports (#1607)
787c542 
Created a Babel transform plugin `mockCssImportPlugin` that transforms
certain css imports into const expressions.
- Replaces import of `.module.css` / `.module.scss` - with a const
object literal containing a key / value of the module name
- Replaces css imports of `?inline` and `?raw` with a const string
literal matching the import path

The new plugin is configured as a plugin for `babel-jest`

resolves #1606
@mofojed mofojed mentioned this issue Nov 3, 2023
Merged
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Nov 3, 2023
@github-actions @deephaven-internal
Update web version 0.53.0 (#4770)
77b25b0 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.53.0

# [0.53.0](deephaven/web-client-ui@v0.52.0...v0.53.0) (2023-11-03)


### Bug Fixes

* DH-15864: Scroll position StuckToBottom shouldn't trigger sharing dot ([#1617](deephaven/web-client-ui#1617)) ([3d4499b](deephaven/web-client-ui@3d4499b))
* Panel focus throwing an exception ([#1609](deephaven/web-client-ui#1609)) ([9e8b7ae](deephaven/web-client-ui@9e8b7ae))
* Plugins were re-registering on every re-render ([#1613](deephaven/web-client-ui#1613)) ([5977389](deephaven/web-client-ui@5977389))


### Features

* Add support for multi-partition parquet:kv tables ([#1580](deephaven/web-client-ui#1580)) ([d92c91e](deephaven/web-client-ui@d92c91e)), closes [#1143](deephaven/web-client-ui#1143) [#1438](deephaven/web-client-ui#1438)
* Babel Plugin - Mock css imports ([#1607](deephaven/web-client-ui#1607)) ([787c542](deephaven/web-client-ui@787c542)), closes [#1606](deephaven/web-client-ui#1606)
* Convert DashboardPlugins to WidgetPlugins ([#1598](deephaven/web-client-ui#1598)) ([a260842](deephaven/web-client-ui@a260842)), closes [#1573](deephaven/web-client-ui#1573)


### Reverts

* "fix: stuck to bottom on filter clear" ([#1616](deephaven/web-client-ui#1616)) ([806a6b6](deephaven/web-client-ui@806a6b6)), closes [deephaven/web-client-ui#1579](deephaven/web-client-ui#1579) [#1615](deephaven/web-client-ui#1615)

Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
enhancement New feature or request web-client-ui
Projects
None yet
Milestone
No milestone
1 participant
@bmingles