Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WindowsDesktop SDK to bring Windows Forms and WPF into project. #234

Merged
merged 30 commits into from
Aug 24, 2020

Conversation

kant2002
Copy link
Contributor

@kant2002 kant2002 commented Apr 7, 2020

This allow play with .NET Core support for tutorials.

These tutorials still can be built only on Windows. See dotnet/sdk#3592
So if any configuration changes should be present, they now can be split not on Core/Full ,but on Windows/NonWindows basis. I know that there some difference in codebase, but I do not play with that yet.

This allow play with .NET Core support for tutorials.

These tutorials still can be built only on Windows. See dotnet/sdk#3592
So if any configuration changes should be present, they now can be split not on Core/Full ,but on Windows/NonWindows basis. I know that there some difference in codebase, but I do not play with that yet.
@kant2002
Copy link
Contributor Author

kant2002 commented Apr 7, 2020

Do not sure that this is what you want in general, but I think it's simple change to ask for feedback.
Given that my magic wand is broken by build not sure what feedback will be.

kant2002 and others added 28 commits April 8, 2020 03:42
At least I want to be explicit on each step and effect which it has
- Moved arguments and expected result values for special function tests from inlined code to csv files.
- Added a python script to compute expected result values for tested special functions in high precision.
- Improved accuracy of NormalCdfLn for `x < -8`. Truncated series was too short, test used to pass, because the expected value itself was incorrect.
Automaton is pointmass if it has only 1 support string.

This implementation is also faster than previous one.
… Point properties are equal. (dotnet#212)

Added PointMassEstimator.
PointMass overrides Equals.
Observed variables can have query types.
Removed the obsolete Output attribute.
Fixed build order.

Internal compiler changes:
* Added MarginalAnalysisTransform.  VariableTransform, ChannelTransform, Channel2Transform no longer set marginal prototypes.
* VariableInformation can be attached to any declaration, not just variables.
* DeriveArrayVariable does not propagate MarginalPrototype attributes.
* VariableTransform and ChannelTransform create marginal channels for constants and parameters.
* ModelBuilder only attaches sizes to objects assignable from arrays.
* Added ObservedVariableMessages CompilerAttribute.
* Channel2Transform attaches DescriptionAttributes
The Nightly build has been failing because it uses VS2017 hosted machines that can not target the desired version of .NET Core.

Switching to VS2019 machines fixes this issue.
…lisers, and Compiler NuGet packages (dotnet#236)

This allows you to avoid confusion of private internal versions of these packages, with those on nuget.org or other feeds with other privately build versions.
`SequenceDistribution.SetTo()` called `SetWorkspace` that tried to normalize weight function.
This is not necessary if sequence distribution is set to another valid sequence distribution.
Renamed Factor.Cut to Cut.Backward
Added InferNet.IsIncreasing, IsIncreasingTransform
ComputeSpecialFunctionsTestValues.py computes more accurate test values, uses pure mpmath, more reliable quadrature. Computes values for NormalCdfRatioLn. Removed hard-coded cases.
MMath.Log1PlusExp uses a threshold based on machine epsilon.
- Ensured argument consistency in NormalCdfIntegralTest
- Fixed some test values
- Exp-Sinh quadrature in LogisticGaussian
- Arithmetic-precision-based constants in logistic gaussian
- Named const for Ulp(1)
- Generating series for gamma(x) - 1/x
- Fixed integer overflow in BGRat
- GenerateSeries can print arrays of bigfloats.
Removed c_digamma_small case from MMath.Digamma
Added tests for MMath.GammaLnSeries and XMinusLog1Plus
GenerateSeries also generates error bounds
Added CheckMathLibraries
…lString

Removed Visualizers/Windows/FactorManagerView
Fixed MslTests.MethodOverrideTest
Added MslTests.MethodInAnotherFileTest
* Added TestPython project.
* TestFSharp exposes xUnit tests.
* Added Invoker.InvokeInstance.  Invoker favors overloads with higher array indexing depth.
* Added EpTests.LinearProgrammingTest.
* Updated FSharp.Core, Msagl
* pr-netcore.yml uses latest version of .NET 3.1 instead of exact version
* UseDotNet task
* Updated versions of YAML tasks
* netcoretest.sh uses "dotnet test"
* Update build instructions
…otnet#271)

* RoslynDeclarationProvider uses all available source codes
to build the requested type declaration.

* Conversion.TryFindConversion looks for casts defined on the toType as
well.

Co-authored-by: Dmitry Kats <ratkillerx@hotmail.com>
* ModelCompiler.IncludeDebugInformation defaults to false

* Fixed TestFSharp.fsproj
ClickThroughModel can run with .NET core (when explicitly built)
@tminka
Copy link
Contributor

tminka commented Aug 24, 2020

I don't want to break the Tutorials project for non-Windows platforms so I reverted that bit. It is a good change for projects that require Windows already.

@tminka tminka merged commit 2ebf99a into dotnet:master Aug 24, 2020
@kant2002
Copy link
Contributor Author

Thanks.

@kant2002 kant2002 deleted the kant/window-sdk branch August 24, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants