Features/local function attributes #41847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

RikkiGibson merged 202 commits into master from features/local-function-attributes

Feb 21, 2020

Member

RikkiGibson commented Feb 21, 2020

Related to #38801

All commits in this PR have been reviewed. Everything is done except:

Add draft spec for local function attributes csharplang#3198 has not been merged yet
Speculative semantic model produces different behavior for local functions #24135 has not been fixed yet (SpeculativeSemanticModel gives attribute class instead of attribute constructor on attributes inside a method body).

I wasn't able to determine a scenario where the IDE experience was significantly harmed by the speculative GetSymbolInfo returning the attribute class rather than the attribute constructor, and it's been difficult to figure out what needs to change in order to get the right behavior, so I'd like to punt on it until after merge.

RikkiGibson and others added 30 commits

September 25, 2019 16:02


          Merge pull request #38856 from dotnet/merges/master-to-features/local…

5a1f9f2

…-function-attributes

Merge master to features/local-function-attributes


          Merge pull request #38864 from dotnet/merges/master-to-features/local…

38548a6

…-function-attributes

Merge master to features/local-function-attributes


          Parse attributes on local function declarations (#38808)


          Merge pull request #38891 from dotnet/merges/master-to-features/local…

2e00580

…-function-attributes

Merge master to features/local-function-attributes


          Merge remote-tracking branch 'upstream/master' into features/local-fu…

3d8bcc4

…nction-attributes


          Fix merge issue

cf8013b


          Fix crashes in expression evaluator tests

9d46b9a


          Merge pull request #38964 from dotnet/merges/master-to-features/local…

1b97910

…-function-attributes

Merge master to features/local-function-attributes


          Add support for parsing out attributes on any statement.

5aa7012


          Remove duplicate check

8d82b26


          Merge pull request #38991 from dotnet/merges/master-to-features/local…

788024a

…-function-attributes

Merge master to features/local-function-attributes


          Merge pull request #39012 from dotnet/merges/master-to-features/local…

9a47f25

…-function-attributes

Merge master to features/local-function-attributes


          Merge pull request #39038 from dotnet/merges/master-to-features/local…

1c81543

…-function-attributes

Merge master to features/local-function-attributes


          Renames

549c868


          Merge pull request #39050 from dotnet/merges/master-to-features/local…

9a7601c

…-function-attributes

Merge master to features/local-function-attributes


          Merge pull request #38937 from CyrusNajmabadi/attributeParsing

9071add

Allow parsing of attributes on any statement.


          Merge pull request #39060 from dotnet/merges/master-to-features/local…

fd2ccbf

…-function-attributes

Merge master to features/local-function-attributes


          Merge pull request #39081 from dotnet/merges/master-to-features/local…

dd64545

…-function-attributes

Merge master to features/local-function-attributes


          Merge remote-tracking branch 'upstream/master' into merges/master-to-…

e286800

…features/local-function-attributes


          Merge pull request #39124 from dotnet/merges/master-to-features/local…

5b366d0

…-function-attributes

Merge master to features/local-function-attributes


          Merge pull request #39182 from dotnet/merges/master-to-features/local…

8c73476

…-function-attributes

Merge master to features/local-function-attributes


          Merge pull request #39213 from dotnet/merges/master-to-features/local…

c56a511

…-function-attributes

Merge master to features/local-function-attributes


          Merge pull request #39231 from dotnet/merges/master-to-features/local…

f21005b

…-function-attributes

Merge master to features/local-function-attributes


          Merge pull request #39246 from dotnet/merges/master-to-features/local…

c201b1d

…-function-attributes

Merge master to features/local-function-attributes


          Merge pull request #39268 from dotnet/merges/master-to-features/local…

8194c46

…-function-attributes

Merge master to features/local-function-attributes


          Local function GetAttributes (#39135)

df8d805


          Merge remote-tracking branch 'upstream/master' into merges/master-to-…

…features/local-function-attributes


          Fix SourceWriter conflicts

588fa37


          Regenerate compiler code

db754c8


          Merge pull request #39283 from dotnet/merges/master-to-features/local…

6ba1de5

…-function-attributes

Merge master to features/local-function-attributes

msftbot[bot] and others added 20 commits

February 12, 2020 23:37


          Merge pull request #41623 from dotnet/merges/master-to-features/local…

9a6da28

…-function-attributes

Merge master to features/local-function-attributes


          Add some tests (#41379)

eb42cbf


          Merge pull request #41638 from dotnet/merges/master-to-features/local…

6818c57

…-function-attributes

Merge master to features/local-function-attributes


          Merge remote-tracking branch 'upstream/master' into merges/master-to-…

2aaf598

…features/local-function-attributes


          Merge pull request #41647 from dotnet/merges/master-to-features/local…

678010d

…-function-attributes

Merge master to features/local-function-attributes


          Merge remote-tracking branch 'upstream/master' into merges/master-to-…

e699d73

…features/local-function-attributes


          Fix crash for local function with MaybeNullWhenAttribute (#41597)

4560d2d


          Merge pull request #41670 from dotnet/merges/master-to-features/local…

d0cd176

…-function-attributes

Merge master to features/local-function-attributes


          Merge remote-tracking branch 'upstream/master' into merges/master-to-…

d73f093

…features/local-function-attributes


          Merge pull request #41677 from dotnet/merges/master-to-features/local…

35cfcfc

…-function-attributes

Merge master to features/local-function-attributes


          Merge pull request #41708 from dotnet/merges/master-to-features/local…

dc4eb42

…-function-attributes

Merge master to features/local-function-attributes


          Merge pull request #41716 from dotnet/merges/master-to-features/local…

f20b788

…-function-attributes

Merge master to features/local-function-attributes


          Merge remote-tracking branch 'upstream/master' into lfa-inlineStateme…

9522efe

…ntParsing


          Fix merge conflicts

9a88cd4


          Add some parsing and incremental parsing tests

29dadf0


          Enable NestedIfStatements

99c25e6


          Keyword recommendation for local function attributes (#41423)

74b47ab


          Fix test gap and delete outdated prototype comment

ab54470


          Test declaration expressions in local function attributes

125f93f


          Merge pull request #41725 from RikkiGibson/lfa-inlineStatementParsing

081a7a5

Merge master to local-function-attributes

RikkiGibson added the Area-Compilers label

RikkiGibson added this to the 16.6.P1 milestone

RikkiGibson requested review from a team as code owners

February 21, 2020 01:25

RikkiGibson requested review from jaredpar and removed request for a team

February 21, 2020 01:26

jaredpar approved these changes

View reviewed changes

Member

jaredpar left a comment

🚀

RikkiGibson merged commit a3918bf into master

Member

jcouv commented Feb 25, 2020

@RikkiGibson Could you update the language feature status page to reflect that this feature was merged? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels