Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge "list-patterns" feature into main branch #57962

Merged
merged 58 commits into from
Nov 24, 2021
Merged

Merge "list-patterns" feature into main branch #57962

merged 58 commits into from
Nov 24, 2021

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Nov 24, 2021

FYI @AlekseyTs @333fred
Relates to test plan #51289

msftbot[bot] and others added 30 commits February 21, 2021 03:11
Merge pull request #51376 from dotnet/merges/master-to-features/list-…
f752c2e 
…patterns

Merge master to features/list-patterns
Merge pull request #51542 from dotnet/merges/master-to-features/list-…
1e657f6 
…patterns

Merge master to features/list-patterns
Merge pull request #51718 from dotnet/merges/main-to-features/list-pa…
25bc053 
…tterns

Merge main to features/list-patterns
Merge pull request #51864 from dotnet/merges/main-to-features/list-pa…
dc72eca 
…tterns

Merge main to features/list-patterns
Merge pull request #52025 from dotnet/merges/main-to-features/list-pa…
445ab65 
…tterns

Merge main to features/list-patterns
Merge pull request #52198 from dotnet/merges/main-to-features/list-pa…
07098db 
…tterns

Merge main to features/list-patterns
Merge pull request #52402 from dotnet/merges/main-to-features/list-pa…
9d21c76 
…tterns

Merge main to features/list-patterns
Merge pull request #52548 from dotnet/merges/main-to-features/list-pa…
16e3f31 
…tterns

Merge main to features/list-patterns
@alrz
List pattern syntax (#51299)
65fce0c
@alrz
List patterns: binding and lowering (#53299)
ac4138a
@jcouv
Merge remote-tracking branch 'dotnet/main' into HEAD
7d72108
@jcouv
Resolve conflicts
6470f61
@jcouv
Merge pull request #53937 from jcouv/merge-master
37d8075 
Refresh `features/list-patterns` with latest bits from `main` branch
@alrz
List patterns: change syntax to use square brackets (#54335)
9961685
@alrz
Merge remote-tracking branch 'origin/main' into list-merge
256dda8 
# Conflicts:
#	src/Compilers/CSharp/Portable/Binder/Binder_Expressions.cs
#	src/Compilers/CSharp/Portable/Binder/Binder_Patterns.cs
#	src/Compilers/CSharp/Portable/Errors/MessageID.cs
#	src/Compilers/CSharp/Portable/FlowAnalysis/DefiniteAssignment.cs
#	src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter.cs
#	src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_AssignmentOperator.cs
#	src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_Call.cs
#	src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_FunctionPointerInvocation.cs
#	src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_IndexerAccess.cs
#	src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_ObjectOrCollectionInitializerExpression.cs
#	src/Compilers/CSharp/Portable/PublicAPI.Unshipped.txt
#	src/Compilers/CSharp/Portable/xlf/CSharpResources.cs.xlf
#	src/Compilers/CSharp/Portable/xlf/CSharpResources.de.xlf
#	src/Compilers/CSharp/Portable/xlf/CSharpResources.es.xlf
#	src/Compilers/CSharp/Portable/xlf/CSharpResources.fr.xlf
#	src/Compilers/CSharp/Portable/xlf/CSharpResources.it.xlf
#	src/Compilers/CSharp/Portable/xlf/CSharpResources.ja.xlf
#	src/Compilers/CSharp/Portable/xlf/CSharpResources.ko.xlf
#	src/Compilers/CSharp/Portable/xlf/CSharpResources.pl.xlf
#	src/Compilers/CSharp/Portable/xlf/CSharpResources.pt-BR.xlf
#	src/Compilers/CSharp/Portable/xlf/CSharpResources.ru.xlf
#	src/Compilers/CSharp/Portable/xlf/CSharpResources.tr.xlf
#	src/Compilers/CSharp/Portable/xlf/CSharpResources.zh-Hans.xlf
#	src/Compilers/CSharp/Portable/xlf/CSharpResources.zh-Hant.xlf
#	src/Compilers/Test/Utilities/CSharp/TestOptions.cs
@alrz
Resolve conflicts
1097878
@alrz
Simplify
d05daef
@alrz
Fixup tests
74d4e58
@jcouv
Merge pull request #55072 from alrz/list-merge
2f1f839 
Merge main into features/list-patterns
@dotnet-bot
Merge pull request #55106 from dotnet/merges/main-to-features/list-pa…
4e3d7bd 
…tterns

Merge main to features/list-patterns
@alrz
List patterns: Fix pattern lookup on nullable types (#55002)
3e08be9
@JoeRobich
Merge remote-tracking branch 'origin/features/list-patterns' into mer…
277c621 
…ges/main-to-features/list-patterns
@dotnet-bot
Merge pull request #55321 from dotnet/merges/main-to-features/list-pa…
a26c19b 
…tterns

Merge main to features/list-patterns
@alrz
Minor cleanup
541b1b7
@dotnet-bot
Merge pull request #56201 from dotnet/merges/main-to-features/list-pa…
3f03fcc 
…tterns

Merge main to features/list-patterns
@alrz
List patterns: subsumption checking (#53891)
ffe7d77
@JoeRobich
Merge branch 'features/list-patterns' into merges/main-to-features/li…
6ad070a 
…st-patterns
@dotnet-bot
Merge pull request #56525 from dotnet/merges/main-to-features/list-pa…
81bfa78 
…tterns

Merge main to features/list-patterns
@dotnet-bot
Merge pull request #56735 from dotnet/merges/main-to-features/list-pa…
d055cab 
…tterns

Merge main to features/list-patterns
@jcouv
List-patterns: fix build break (#56809)
d333187
alrz and others added 13 commits October 28, 2021 11:47
@alrz
List patterns: IOperation (#56008)
59a0608
@jcouv
List-patterns: Add declarations of public APIs (#57434)
3b4d45b
@alrz
Follow-up on merge
f50a8dd
@jcouv
Merge pull request #57425 from alrz/epilogue
67a9216 
Merge `main` branch into `list-patterns` branch
@jcouv
Merge remote-tracking branch 'dotnet/main' into merge-main
55c276c
@jcouv
Adjust OperationKind identifiers in publicAPI
f575c80
@jcouv
Merge pull request #57690 from jcouv/merge-main
1d38997 
Merge `main` branch into `list-patterns`
@JoeRobich
Merge branch 'features/list-patterns' into merges/main-to-features/li…
6d385fe 
…st-patterns
@dotnet-bot
Merge pull request #57754 from dotnet/merges/main-to-features/list-pa…
118a310 
…tterns

Merge main to features/list-patterns
@jcouv
List-patterns: factor binding logic (#57318)
09bc67a 
Co-authored-by: AlekseyTs <AlekseyTs@users.noreply.github.com>

This changes the bound tree representation of list patterns, slice patterns and implicit indexer accesses to avoid storing property or method symbols. Instead we store BoundIndexerAccess/BoundArrayAccess/BoundCall, which be obtain from existing "Bind*" methods and that we run through `CheckValue`. This ensures that we're not missing on all the validation rules which those include.
We intend to do some further refactoring, allowing `CheckValue` to properly deal with placeholders. This will allow us to store the Receiver separately from the IndexerOrSliceAccess and leverage existing placeholder infrastructure.
@jcouv
Merge pull request #57905 from dotnet/merges/main-to-features/list-pa…
0d661e9 
…tterns

Merge main to features/list-patterns
@AlekseyTs
Unify representation of an implicit Index indexer over an array and…
7fea0aa 
… non-array types. (#57918)
@jcouv
List-patterns: add a few tests and add HasValidate flag (#57914)
0660d83
@jcouv jcouv self-assigned this Nov 24, 2021
@jcouv
Copy link
Member Author

jcouv commented Nov 24, 2021

@alrz FYI the feature will likely get merged before your latest PR (#57934). If so, we'll just have to retarget the PR. Thanks

@jcouv jcouv marked this pull request as ready for review November 24, 2021 17:02
@jcouv jcouv requested review from a team as code owners November 24, 2021 17:02
@jcouv jcouv requested review from jaredpar and AlekseyTs November 24, 2021 17:02
@jcouv jcouv merged commit 19d3159 into main Nov 24, 2021
@ghost ghost added this to the Next milestone Nov 24, 2021
@jcouv
Copy link
Member Author

jcouv commented Nov 24, 2021

The list-patterns feature was merged for VS 17.1p2 and .NET 6.0.200.
Thanks @alrz, @333fred and @AlekseyTs

@allisonchou allisonchou modified the milestones: Next, 17.1.P2 Nov 30, 2021
@RikkiGibson
Copy link
Contributor

.NET 6.0.200

marking my calendar for when Roslyn can adopt the feature :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@jaredpar jaredpar Awaiting requested review from jaredpar

Assignees

@jcouv jcouv

Labels
Area-Compilers Feature - List Patterns
Projects
None yet
Milestone
17.1.P2
Development

Successfully merging this pull request may close these issues.
7 participants
@jcouv @RikkiGibson @AlekseyTs @allisonchou @alrz @dotnet-bot @JoeRobich