Skip to content

Merge param-nullchecking to main #58338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 98 commits into from
Dec 15, 2021
Merged

Merge param-nullchecking to main #58338

merged 98 commits into from
Dec 15, 2021

Conversation

@RikkiGibson
Copy link
Member

@RikkiGibson RikkiGibson commented Dec 15, 2021

Related to #36024

There is still more to do but we think this is ready to go into the preview langversion in 17.1.

fayrose and others added 30 commits May 30, 2019 13:31
@fayrose
Parsing for Parameter Nullchecking (#35826)
3816bf8
@fayrose
Merge master with param-nullchecking (#36070)
650a8d7
@JoeRobich
Merge remote-tracking branch 'origin/features/param-nullchecking' int…
1f0d02f 
…o merges/master-to-features/param-nullchecking
Merge pull request #36077 from dotnet/merges/master-to-features/param…
54b6387 
…-nullchecking

Merge master to features/param-nullchecking
Merge pull request #36145 from dotnet/merges/master-to-features/param…
584982b 
…-nullchecking

Merge master to features/param-nullchecking
@fayrose
Features/nullchecking error binding (#36095)
ca55da0
@JoeRobich
Merge remote-tracking branch 'origin/features/param-nullchecking' int…
c96b016 
…o merges/master-to-features/param-nullchecking
Merge pull request #36171 from dotnet/merges/master-to-features/param…
f8050ff 
…-nullchecking

Merge master to features/param-nullchecking
Merge pull request #36199 from dotnet/merges/master-to-features/param…
48f005f 
…-nullchecking

Merge master to features/param-nullchecking
Merge pull request #36207 from dotnet/merges/master-to-features/param…
adb2e77 
…-nullchecking

Merge master to features/param-nullchecking
Merge pull request #36231 from dotnet/merges/master-to-features/param…
fcde686 
…-nullchecking

Merge master to features/param-nullchecking
Merge pull request #36235 from dotnet/merges/master-to-features/param…
0d774a5 
…-nullchecking

Merge master to features/param-nullchecking
Merge pull request #36257 from dotnet/merges/master-to-features/param…
409bb04 
…-nullchecking

Merge master to features/param-nullchecking
@RikkiGibson
Merge remote-tracking branch 'upstream/master' into merges/master-to-…
3754748 
…features/param-nullchecking
@JoeRobich
Merge remote-tracking branch 'origin/master' into merges/master-to-fe…
f0a9368 
…atures/param-nullchecking
Merge pull request #36280 from dotnet/merges/master-to-features/param…
e9124ed 
…-nullchecking

Merge master to features/param-nullchecking
Merge pull request #36303 from dotnet/merges/master-to-features/param…
d6b0118 
…-nullchecking

Merge master to features/param-nullchecking
@fayrose
Param nullchecking binding (#36247)
3e72bb0
Merge pull request #36325 from dotnet/merges/master-to-features/param…
0cbdca9 
…-nullchecking

Merge master to features/param-nullchecking
Merge pull request #36343 from dotnet/merges/master-to-features/param…
d7c97f7 
…-nullchecking

Merge master to features/param-nullchecking
Merge pull request #36363 from dotnet/merges/master-to-features/param…
2aad1b0 
…-nullchecking

Merge master to features/param-nullchecking
Merge pull request #36376 from dotnet/merges/master-to-features/param…
8f47426 
…-nullchecking

Merge master to features/param-nullchecking
Merge pull request #36394 from dotnet/merges/master-to-features/param…
4cc2600 
…-nullchecking

Merge master to features/param-nullchecking
Merge pull request #36425 from dotnet/merges/master-to-features/param…
a25a2be 
…-nullchecking

Merge master to features/param-nullchecking
Merge pull request #36442 from dotnet/merges/master-to-features/param…
2f8cef2 
…-nullchecking

Merge master to features/param-nullchecking
Merge pull request #36479 from dotnet/merges/master-to-features/param…
13ee0f8 
…-nullchecking

Merge master to features/param-nullchecking
Merge pull request #36490 from dotnet/merges/master-to-features/param…
e74f602 
…-nullchecking

Merge master to features/param-nullchecking
Merge pull request #36531 from dotnet/merges/master-to-features/param…
32017d1 
…-nullchecking

Merge master to features/param-nullchecking
Merge pull request #36558 from dotnet/merges/master-to-features/param…
fa959cd 
…-nullchecking

Merge master to features/param-nullchecking
Merge pull request #36580 from dotnet/merges/master-to-features/param…
2490bf4 
…-nullchecking

Merge master to features/param-nullchecking
dotnet-automerge-bot and others added 21 commits August 7, 2019 12:00
Merge pull request #37776 from dotnet/merges/master-to-features/param…
2ca0209 
…-nullchecking

Merge master to features/param-nullchecking
@jaredpar
Merge remote-tracking branch 'origin/master' into m
19c19ec
Merge remote-tracking branch 'upstream/master' into features/pnc-upda…
2cf8ba0 
…te-r3
@jaredpar
Merge pull request #46388 from kevinsun-dev/features/pnc-update-r3
eda615d 
Merge [master] into [features/param-nullchecking]
Bring features/param-nullchecking up to date (#46398)
3f382cb 
* Merge Fixes

* Fixed Merge Errors - Building now...

* Update IOperationTests_INullCheckedParameters.cs

* PR changes (part 1)

* Undo Debug.Assert on LocalRewriter

* Updated ControlFlowGraphBuilder

* Fixed Testing

* Tab for a cause
[features/param-nullchecking] The BangBang Update (#46520)
3b0b5e1 
* Merge Fixes

* Fixed Merge Errors - Building now...

* Update IOperationTests_INullCheckedParameters.cs

* PR changes (part 1)

* Undo Debug.Assert on LocalRewriter

* Updated ControlFlowGraphBuilder

* Fixed Testing

* Tab for a cause

* BangBang Update

* Testing Fixes

* Revise Testing Baselines

* Updated CodeGen Tests

* Update NullableReferenceTypesTests.cs

* Moved BangBang from Lexer to Parser

* Fix !! Syntax Changes

* Revert changes

* Param Nullchecking ExclamationEquals Disassembly

* Update CSharp.Generated.g4

* Added Error Case

* PR Changes

* Update LanguageParser.cs

* Update LanguageParser.cs

* Updated with Bad Syntax

* Added ECC Parsing Tests

* Removed Test Noise

* Update DeclarationParsingTests.cs

* Add Prototype Flags

* Update LanguageParser.cs

* Added and changed tests
@RikkiGibson
Merge remote-tracking branch 'upstream/main' into merge-main-with-con…
5f0a324 
…flicts
@RikkiGibson
Merge main to features/param-nullchecking with conflicts (#57278)
f5b488c
@RikkiGibson
Merge pull request #57280 from RikkiGibson/resolve-conflicts
f907633 
Resolve conflicts merging main to features/param-nullchecking
@RikkiGibson
Fix param-nullchecking build/test failures (#57375)
6ba3dea
@RikkiGibson
Merge remote-tracking branch 'upstream/main' into merges/main-to-feat…
67eaccd 
…ures/param-nullchecking
Merge pull request #57512 from dotnet/merges/main-to-features/param-n…
38e86e0 
…ullchecking

Merges/main to features/param nullchecking
@RikkiGibson
Use helpers in param-nullchecking emit (#57615)
cabcb95
@RikkiGibson
Merge branch 'main' of github.com:dotnet/roslyn into merges/main-to-f…
4e7c469 
…eatures/param-nullchecking
Merge pull request #57866 from RikkiGibson/merges/main-to-features/pa…
7854604 
…ram-nullchecking

Merges/main to features/param nullchecking
@RikkiGibson
Merge pull request #57934 from RikkiGibson/pnc-refactoring
ed3de52 
Use !! in AddParameterCheck refactoring
@RikkiGibson
Merge remote-tracking branch 'upstream/main' into merges/main-to-feat…
96698d9 
…ures/param-nullchecking
@RikkiGibson
Merge pull request #58183 from dotnet/merges/main-to-features/param-n…
4bbf0c0 
…ullchecking

Merges/main to features/param nullchecking
@RikkiGibson
Address various minor param-nullchecking issues (#58321)
81e44e1
@jaredpar
Resolve PROTOTYPE comments in param null checking (#58324)
897223b 
* Resolve PROTOTYPE comments in param null checking

Filed the following issues:
- #58323
- #58322
- #58320

* Remove unnecessary issue link
@RikkiGibson
Change PROTOTYPE to issue reference (#58336)
e9c4789
@RikkiGibson RikkiGibson requested review from a team as code owners December 15, 2021 00:20
@ghost ghost added the Area-Compilers label Dec 15, 2021
@RikkiGibson RikkiGibson merged commit 8c77f52 into main Dec 15, 2021
@ghost ghost added this to the Next milestone Dec 15, 2021
@RikkiGibson RikkiGibson deleted the features/param-nullchecking branch December 15, 2021 02:31
@Cosifne Cosifne modified the milestones: Next, 17.1.P3 Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredpar jaredpar jaredpar approved these changes

Assignees

No one assigned

Labels

Area-Compilers

Projects

None yet

Milestone

17.1.P3

Development

Successfully merging this pull request may close these issues.

6 participants

@RikkiGibson @jaredpar @Cosifne @fayrose @JoeRobich