Release staging into master #877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix code format In [corefx/coding-style.md at master · dotnet/corefx](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md ) NO.1, we use Allman style braces, where each brace begins on a new line. A single line statement block can go without braces but the block must be properly indented on its own line and must not be nested in other statement blocks that use braces (See issue 381 for examples). One exception is that a using statement is permitted to be nested within another using statement by starting on the following line at the same indentation level, even if the nested using contains a controlled block. * Fix code format In [corefx/coding-style.md at master · dotnet/corefx](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md ) NO.11, we use language keywords instead of BCL types.
* Managed COM sample for .NET Core 3.0 * Feedback
* Clarify DateTime implicit conversion example It took some time for me to understand why the last example has -08:00 as offset. Since the example seemed to be about the addition of a TimeSpan the change in offset was quite confusing. Therefore, I split the example into two parts, one only focusing on the addition of a TimeSpan and the second on the adaption of the daylight time specific time zone. I also fixed a typo in the year given in line 84. * Clarify DateTime implicit conversion VB example Adaption of changes made to the C# example in commit e1833f1 to the Visual Basic sample base. This change was made based on the feedback received to [PR #850](#850 (comment))
If you try this sample in a .NET Core project, and build as debug, it will throw an exception on line 27. This is because, when built for debug, the value is not garbage collected, so `wr2.Target` is not `null` and we hit the `else if`. In that line, `mc2` *is* `null` (because it is set to `null` on line 19) which throws an exception trying to use it as a key to the CWT.
* SkipLast and TakeLast examples See Snippet203 and Snippet204 * added vb SkipLast and TakeLast examples
* Add ShampooSalesAnomalyDetection * Update for dataset changes
Update MovieRecommendation tutorial code sample to ML.NET v1.0.0
Update GitHubIssueClassification tutorial code sample to ML.NET v1.0.0
Update TransferLearningTF tutorial code sample to ML.NET v1.0.0
Update ProductSalesAnomalyDetection tutorial code sample to ML.NET v1.0.0
Rather than the try finally around the reader (SqlDataReader)_ I believe that the using construct is best practice and consistent with the SqlConnection. I know try / finally does the same thing - but the using construct is, I think, the way to go with all IDisposable classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.