[ftr] enable visualRegression jobs #42989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
|
Pinging @elastic/kibana-operations |
💚 Build Succeeded |
|
Looks like the Percy integration into Github works. |
liza-mae
suggested changes
Aug 9, 2019
There was a problem hiding this comment.
Looks like the security login tests are showing up as blank in Percy, either they need to be fixed or disabled, it is best not to use up the snapshots we currently have on our plan. For the same reason,
the console test is showing some non meaningful diffs, maybe we should disable for now until we can get this resolved either on our side or Percy.
|
@nreese I noticed your map test show a diff on the logo in bottom left, this is the first time I see this diff on your test. |
💚 Build Succeeded |
💚 Build Succeeded |
spalger
force-pushed
the
implement/run-percy-in-prs
branch
from
de498a8
to
c3a2d4c
Compare
spalger
force-pushed
the
implement/run-percy-in-prs
branch
from
c3a2d4c
to
2645914
Compare
💚 Build Succeeded |
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Aug 12, 2019
* enable visualRegression jobs * skip the console and login visual tests
This was referenced Aug 12, 2019
spalger
pushed a commit
that referenced
this pull request
Aug 12, 2019
|
7.x/7.4: 2441453 |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 13, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (27 commits) [ML] Data Frames: Analytics job creation. (elastic#43102) [Vis Default editor] Fix issue with Rollup (elastic#42430) [Vis: Default editor] EUIficate Markdown tab (elastic#42677) [New Platform Migration Phase I]: update dateHisogramInterval & parseEsInterval imports (elastic#42917) [Infra UI] Add AWS metrics to node detail page (elastic#42153) update apm index pattern (elastic#43106) [SIEM] Toggle Column / Code Coverage and Cypress (elastic#42766) skip failing test (elastic#43163) [code] Add option to turn the go dependency download on/off. (elastic#43096) disable visual regression jobs Removed dead code (elastic#42774) fixes csv export of saved searches that have _source field (elastic#43123) Export missing Context types (elastic#43051) Update dependency supports-color to v7 (elastic#43064) switch to icon type string instead of node (elastic#43111) [Maps] Enable borders for icon symbols (elastic#43066) [ftr] enable visualRegression jobs (elastic#42989) [ML] Converting single to multi metric job (elastic#42532) fix(NA): dont clean dll module if it is a package json file (elastic#42904) [Logs UI] Add link from the sample web logs to the Logs UI (elastic#42635) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a bunch of testing we are ready to enable the visualRegression jobs in CI 🎉