[code] Add option to turn the go dependency download on/off. #43096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no proper approaches to disable downloading go dependencies except creating inconsistencies of the running environments of go-langserver. Given that go language server will do its best to convert the repos into modules, one of the doable approaches is setting 'GO111MODULE' to false to be incompatible with the moduled repos.
|
Pinging @elastic/code |
zfy0701
approved these changes
Aug 12, 2019
| @@ -88,6 +88,7 @@ export const code = (kibana: any) => | |||
| security: Joi.object({ | |||
| enableMavenImport: Joi.boolean().default(true), | |||
| enableGradleImport: Joi.boolean().default(false), | |||
| installGoDependency: Joi.boolean().default(false), | |||
There was a problem hiding this comment.
@zfy0701 Do you mean this default value?
💚 Build Succeeded |
movie-travel-code
pushed a commit
to movie-travel-code/kibana
that referenced
this pull request
Aug 13, 2019
…#43096) There are no proper approaches to disable downloading go dependencies except creating inconsistencies of the running environments of go-langserver. Given that go language server will do its best to convert the repos into modules, one of the doable approaches is setting 'GO111MODULE' to false to be incompatible with the moduled repos.
movie-travel-code
pushed a commit
that referenced
this pull request
Aug 13, 2019
…#43165) There are no proper approaches to disable downloading go dependencies except creating inconsistencies of the running environments of go-langserver. Given that go language server will do its best to convert the repos into modules, one of the doable approaches is setting 'GO111MODULE' to false to be incompatible with the moduled repos.
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 13, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (27 commits) [ML] Data Frames: Analytics job creation. (elastic#43102) [Vis Default editor] Fix issue with Rollup (elastic#42430) [Vis: Default editor] EUIficate Markdown tab (elastic#42677) [New Platform Migration Phase I]: update dateHisogramInterval & parseEsInterval imports (elastic#42917) [Infra UI] Add AWS metrics to node detail page (elastic#42153) update apm index pattern (elastic#43106) [SIEM] Toggle Column / Code Coverage and Cypress (elastic#42766) skip failing test (elastic#43163) [code] Add option to turn the go dependency download on/off. (elastic#43096) disable visual regression jobs Removed dead code (elastic#42774) fixes csv export of saved searches that have _source field (elastic#43123) Export missing Context types (elastic#43051) Update dependency supports-color to v7 (elastic#43064) switch to icon type string instead of node (elastic#43111) [Maps] Enable borders for icon symbols (elastic#43066) [ftr] enable visualRegression jobs (elastic#42989) [ML] Converting single to multi metric job (elastic#42532) fix(NA): dont clean dll module if it is a package json file (elastic#42904) [Logs UI] Add link from the sample web logs to the Logs UI (elastic#42635) ...
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are no proper approaches to disable downloading go dependencies
except creating inconsistencies of the running environments of
go-langserver. Given that go language server will do its best to convert
the repos into modules, one of the doable approaches is setting
'GO111MODULE' to false to be incompatible with the moduled repos.
Related issue: https://github.com/elastic/code/issues/1533
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers