Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes csv export of saved searches that have _source field #43123

Merged
merged 2 commits into from
Aug 12, 2019

Conversation

bmcconaghy
Copy link
Contributor

Fixes #42945

To verify, create a saved search from discover, add the saved search to a dashboard, and then download a CSV from that dashboard.

@bmcconaghy bmcconaghy added release_note:fix (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead v8.0.0 Team:Stack Services v7.4.0 v7.3.1 labels Aug 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services

Copy link
Contributor

@joelgriffith joelgriffith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Is there anyway we can add a test-case for this?

@joelgriffith
Copy link
Contributor

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@bmcconaghy bmcconaghy merged commit 142897f into elastic:master Aug 12, 2019
@bmcconaghy bmcconaghy deleted the fix_discover_saved_search_csv branch August 12, 2019 20:14
bmcconaghy added a commit to bmcconaghy/kibana that referenced this pull request Aug 12, 2019
…3123)

* fixes csv export of saved searches that have _source field

* adding test
bmcconaghy added a commit that referenced this pull request Aug 13, 2019
…43149)

* fixes csv export of saved searches that have _source field

* adding test
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 13, 2019
…p-metrics-selectall

* 'master' of github.com:elastic/kibana: (27 commits)
  [ML] Data Frames: Analytics job creation. (elastic#43102)
  [Vis Default editor] Fix issue with Rollup (elastic#42430)
  [Vis: Default editor] EUIficate Markdown tab (elastic#42677)
  [New Platform Migration Phase I]: update dateHisogramInterval & parseEsInterval imports (elastic#42917)
  [Infra UI] Add AWS metrics to node detail page (elastic#42153)
  update apm index pattern (elastic#43106)
  [SIEM] Toggle Column / Code Coverage and Cypress (elastic#42766)
  skip failing test (elastic#43163)
  [code] Add option to turn the go dependency download on/off. (elastic#43096)
  disable visual regression jobs
  Removed dead code (elastic#42774)
  fixes csv export of saved searches that have _source field (elastic#43123)
  Export missing Context types (elastic#43051)
  Update dependency supports-color to v7 (elastic#43064)
  switch to icon type string instead of node (elastic#43111)
  [Maps] Enable borders for icon symbols (elastic#43066)
  [ftr] enable visualRegression jobs (elastic#42989)
  [ML] Converting single to multi metric job (elastic#42532)
  fix(NA): dont clean dll module if it is a package json file (elastic#42904)
  [Logs UI] Add link from the sample web logs to the Logs UI (elastic#42635)
  ...
bmcconaghy added a commit that referenced this pull request Aug 13, 2019
…43148)

* fixes csv export of saved searches that have _source field

* adding test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:fix v7.3.1 v7.4.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download csv from dashboard panel returns empty
3 participants