[Drilldowns] Dashboard state fixes for drilldowns #61457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Dosant
added
release_note:skip
7 tasks
Dosant
force-pushed
the
dev/drilldowns/dashboard-state-fixes
branch
from
8778384
to
71fe97c
Compare
|
@elasticmachine merge upstream |
…s/dashboard-state-fixes # Conflicts: # src/legacy/core_plugins/kibana/public/dashboard/np_ready/url_helper.test.ts # src/legacy/core_plugins/kibana/public/dashboard/np_ready/url_helper.ts
…ant/kibana into dev/drilldowns/dashboard-state-fixes
|
I have started reviewing this, will finish tomorrow morning. |
flash1293
reviewed
Apr 1, 2020
src/legacy/core_plugins/kibana/public/dashboard/np_ready/lib/url.ts
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/kibana/public/dashboard/np_ready/dashboard_state_manager.ts
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/kibana/public/dashboard/np_ready/dashboard_state_manager.ts
Show resolved
Hide resolved
src/legacy/core_plugins/kibana/public/dashboard/np_ready/dashboard_app_controller.tsx
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/kibana/public/dashboard/np_ready/lib/url.test.ts
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/kibana/public/dashboard/np_ready/dashboard_state_manager.ts
Show resolved
Hide resolved
…s/dashboard-state-fixes
…s/dashboard-state-fixes
7 tasks
flash1293
approved these changes
Apr 2, 2020
…s/dashboard-state-fixes
…s/dashboard-state-fixes
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Dosant
added
the
bug
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Apr 3, 2020
1. Change logic around deciding wether to use time from url or from saved object. Previously code looked only into if _g is present in the url at all. And didn't consider edge case if time or refreshInterval is missing in _g 2. Fix initial syncing of time from savedobject causing redundant history record. _This changed caused order of _a and g params in url change. One test was affected by it because it relied on the order. I don't think it should be considered breaking as order app puts it's query params shouldn't matter. 3. Fix another race condition between state syncing with url and angular controller $destroy. Similar fix was done before in elastic#57795, but this on covers case when we stay within dashboard app, but change dashboard 4. Fix initial panel state migration causing redundant browser history records Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Apr 3, 2020
1. Change logic around deciding wether to use time from url or from saved object. Previously code looked only into if _g is present in the url at all. And didn't consider edge case if time or refreshInterval is missing in _g 2. Fix initial syncing of time from savedobject causing redundant history record. _This changed caused order of _a and g params in url change. One test was affected by it because it relied on the order. I don't think it should be considered breaking as order app puts it's query params shouldn't matter. 3. Fix another race condition between state syncing with url and angular controller $destroy. Similar fix was done before in elastic#57795, but this on covers case when we stay within dashboard app, but change dashboard 4. Fix initial panel state migration causing redundant browser history records Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 3, 2020
* master: [Drilldowns] Dashboard state fixes for drilldowns (elastic#61457) allow null for filterQuery (elastic#62310) [ML] call job validation endpoint with complete payload (elastic#62331) removing configuration from agents (elastic#62290) Allow Enterprise license for service map (elastic#62371) docs: updates to apm agent config (elastic#61893) [Ingest] Fix package info request returning 500 (elastic#61712) move crypto to server utils (elastic#62344) Start indexing documents by default (elastic#62159) [Endpoint] Update host field accordion (elastic#61878) Add more definitions about Ingest Management (elastic#62049)
Dosant
added a commit
that referenced
this pull request
Apr 3, 2020
1. Change logic around deciding wether to use time from url or from saved object. Previously code looked only into if _g is present in the url at all. And didn't consider edge case if time or refreshInterval is missing in _g 2. Fix initial syncing of time from savedobject causing redundant history record. _This changed caused order of _a and g params in url change. One test was affected by it because it relied on the order. I don't think it should be considered breaking as order app puts it's query params shouldn't matter. 3. Fix another race condition between state syncing with url and angular controller $destroy. Similar fix was done before in #57795, but this on covers case when we stay within dashboard app, but change dashboard 4. Fix initial panel state migration causing redundant browser history records Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Dosant
added a commit
that referenced
this pull request
Apr 3, 2020
1. Change logic around deciding wether to use time from url or from saved object. Previously code looked only into if _g is present in the url at all. And didn't consider edge case if time or refreshInterval is missing in _g 2. Fix initial syncing of time from savedobject causing redundant history record. _This changed caused order of _a and g params in url change. One test was affected by it because it relied on the order. I don't think it should be considered breaking as order app puts it's query params shouldn't matter. 3. Fix another race condition between state syncing with url and angular controller $destroy. Similar fix was done before in #57795, but this on covers case when we stay within dashboard app, but change dashboard 4. Fix initial panel state migration causing redundant browser history records Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #61230
Some fixes to dashboard state to support drilldowns and navigation from one dashboard to another
Fixed issues:
Change logic around deciding wether to use time from url or from saved object. Previously code looked only into if
_gis present in the url at all. And didn't consider edge case if time or refreshInterval is missing in_gFix initial syncing of time from savedobject causing redundant history record. _This changed caused order of _a and g params in url change. One test was affected by it because it relied on the order. I don't think it should be considered breaking as order app puts it's query params shouldn't matter.
Fix another race condition between state syncing with url and angular controller $destroy. Similar fix was done before in Navigation from unsaved dashboard to recently used fails #57795, but this on covers case when we stay within dashboard app, but change dashboard
Fix initial panel state migration causing redundant browser history records
Known not fixed issues:
Checklist
Delete any items that are not applicable to this PR.
For maintainers