Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Update validation schema for imported timeline #62310

Merged
merged 1 commit into from
Apr 3, 2020
Merged

[SIEM] Update validation schema for imported timeline #62310

merged 1 commit into from
Apr 3, 2020

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Apr 2, 2020 •
edited
Loading

Summary

Updating schema for this case:

  1. Let filterQuery allows null
  2. Let kuery allows null

To verify please download the attachment and rename it with .ndjson
timelines_export_noFilterQuery.ndjson.txt

no_filterquery_joi

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@angorayc angorayc requested a review from a team as a code owner April 2, 2020 12:50
@angorayc angorayc added v7.7.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:SIEM labels Apr 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

rylnd
rylnd approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally, LGTM. I created a basic timeline and exported it, and was unable to import it without these changes.

@angorayc angorayc merged commit aab3dff into elastic:master Apr 3, 2020
@angorayc angorayc mentioned this pull request Apr 3, 2020
Merged
angorayc added a commit to angorayc/kibana that referenced this pull request Apr 3, 2020
@angorayc
allow null for filterQuery (elastic#62310)
d1ccb96
@angorayc angorayc mentioned this pull request Apr 3, 2020
Merged
angorayc added a commit to angorayc/kibana that referenced this pull request Apr 3, 2020
@angorayc
allow null for filterQuery (elastic#62310)
7db1b5a
angorayc added a commit that referenced this pull request Apr 3, 2020
@angorayc
allow null for filterQuery (#62310) (#62410)
127393d
angorayc added a commit that referenced this pull request Apr 3, 2020
@angorayc
allow null for filterQuery (#62310) (#62411)
ddc1a1b
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 3, 2020
@gmmorris
Merge branch 'master' into event-log/query-support
a492453 
* master:
  [Drilldowns] Dashboard state fixes for drilldowns (elastic#61457)
  allow null for filterQuery (elastic#62310)
  [ML] call job validation endpoint with complete payload (elastic#62331)
  removing configuration from agents (elastic#62290)
  Allow Enterprise license for service map (elastic#62371)
  docs: updates to apm agent config (elastic#61893)
  [Ingest] Fix package info request returning 500 (elastic#61712)
  move crypto to server utils (elastic#62344)
  Start indexing documents by default (elastic#62159)
  [Endpoint] Update host field accordion (elastic#61878)
  Add more definitions about Ingest Management (elastic#62049)
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylnd rylnd rylnd approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@angorayc @elasticmachine @kibanamachine @rylnd @MindyRS