-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Fix job wizard model memory limit warnings #62331
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⚡️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* master: [Drilldowns] Dashboard state fixes for drilldowns (elastic#61457) allow null for filterQuery (elastic#62310) [ML] call job validation endpoint with complete payload (elastic#62331) removing configuration from agents (elastic#62290) Allow Enterprise license for service map (elastic#62371) docs: updates to apm agent config (elastic#61893) [Ingest] Fix package info request returning 500 (elastic#61712) move crypto to server utils (elastic#62344) Start indexing documents by default (elastic#62159) [Endpoint] Update host field accordion (elastic#61878) Add more definitions about Ingest Management (elastic#62049)
Summary
Part of the payload for performing job validation was omitted (probably during the refactoring), which led to the skipping of the model memory limit check during the "Validation" step.
This PR fixes the API call and the issue with an incorrect duration check.