Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM][CASE] Fix bug when connector is deleted. #65876

Merged
merged 10 commits into from
May 15, 2020

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented May 8, 2020

Summary

When a connector is deleted and a case uses that connector the pushed at service button is being shown. This PR fixes the issue: https://github.com/elastic/siem-team/issues/658

b

For maintainers

@cnasikas cnasikas added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v7.9.0 labels May 8, 2020
@cnasikas cnasikas requested review from a team as code owners May 8, 2020 15:22
@cnasikas cnasikas self-assigned this May 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@cnasikas cnasikas force-pushed the case_bug_fix branch 3 times, most recently from 187574f to dea7f15 Compare May 11, 2020 08:22
@stephmilovic
Copy link
Contributor

One more issue. After the connector is deleted

current:
Screen Shot 2020-05-11 at 8 44 12 AM

should be:
Screen Shot 2020-05-11 at 8 44 48 AM

@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@cnasikas
Copy link
Member Author

One more issue. After the connector is deleted

current:
Screen Shot 2020-05-11 at 8 44 12 AM

should be:
Screen Shot 2020-05-11 at 8 44 48 AM

Fixed.

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesterday @cnasikas and i discovered in zoom a few more intricacies. We need to decide on some behaviors with the help of @XavierM in a variety of scenarios that happen when the connector gets deleted (all cases connector column, etc)

@cnasikas
Copy link
Member Author

@XavierM @stephmilovic I made all changes we discussed.

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with follow up on color=danger to be done in #66029

@cnasikas cnasikas force-pushed the case_bug_fix branch 3 times, most recently from 17972d5 to 436279a Compare May 14, 2020 18:23
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💔 Build #48054 failed 436279ad3f21ad32a45b3151c62c4d2b5c12deb0
  • 💔 Build #47568 failed f4d237af95132318c3384dcbbe365afffec81a23
  • 💔 Build #47446 failed 9f124708ebb425fc314c7d932f09feae03f1c064
  • 💚 Build #47260 succeeded fb9f07ee5e1902318e1069e5f9780d34f706b9f6
  • 💔 Build #47208 failed f66934db923d56c0865d3c844ad8e5343e42b4c3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cnasikas cnasikas merged commit d174897 into elastic:master May 15, 2020
@cnasikas cnasikas deleted the case_bug_fix branch May 15, 2020 11:43
jloleysens added a commit to jloleysens/kibana that referenced this pull request May 15, 2020
…ent/add-support-in-url-for-hidden-toggle

* 'master' of github.com:elastic/kibana: (34 commits)
  [SIEM][CASE] Fix bug when connector is deleted. (elastic#65876)
  [SIEM][CASE] Improve layout (elastic#66232)
  [Index Management] Support Hidden Indices (elastic#66422)
  Add Login Selector functional tests. (elastic#65705)
  Lens drilldowns (elastic#65675)
  [ML] Custom template for apiDoc markdown (elastic#66567)
  Don't bootstrap core type emits (elastic#66377)
  [Dashboard] Improve loading error handling (elastic#66372)
  [APM] Minor style fixes for the node strokes (elastic#66574)
  [Ingest Manager] Fix create data source from integration (elastic#66626)
  [Metrics UI] Fix default metric alert interval for new conditions (elastic#66610)
  [Metrics UI] Fix alignment and allow clearing metric value (elastic#66589)
  Don't return package name for non-package data streams (elastic#66606)
  [Ingest Manager] Consolidate routing and add breadcrumbs to all pages (elastic#66475)
  [Docs/Reporting] Have the docs about granular timeout match Cloud docs (elastic#66267)
  Don't automatically add license header to code inside plugins dir. (elastic#66601)
  [APM] Don't trigger map layout if no elements (elastic#66625)
  [Logs UI] Validate ML job setup time ranges (elastic#66426)
  Fix pagination bugs in CCR and Remote Clusters (elastic#65931)
  Add cloud icon for supported settings and embed single-sourced getting started (elastic#65610)
  ...

# Conflicts:
#	x-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.js
#	x-pack/plugins/index_management/server/lib/fetch_indices.ts
cnasikas added a commit to cnasikas/kibana that referenced this pull request May 15, 2020
cnasikas added a commit to cnasikas/kibana that referenced this pull request May 17, 2020
# Conflicts:
#	x-pack/plugins/siem/public/cases/components/case_view/index.test.tsx
#	x-pack/plugins/siem/public/cases/components/case_view/index.tsx
#	x-pack/plugins/siem/public/cases/components/use_push_to_service/index.test.tsx
#	x-pack/plugins/siem/public/cases/components/use_push_to_service/index.tsx
#	x-pack/test/case_api_integration/basic/tests/cases/push_case.ts
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants