Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs/Reporting] Have the docs about granular timeout match Cloud docs #66267

Merged

Conversation

tsullivan
Copy link
Member

This is related to updates of the Reporting docs in Cloud. This PR tunes the wording to make it match Cloud docs.

@tsullivan tsullivan added Team:Docs v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v7.8.0 v7.9.0 labels May 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@spalger spalger added v7.7.1 and removed v7.7.0 labels May 14, 2020
docs/settings/reporting-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/reporting-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/reporting-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/reporting-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/reporting-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/reporting-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/reporting-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/reporting-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/reporting-settings.asciidoc Outdated Show resolved Hide resolved
@gchaps
Copy link
Contributor

gchaps commented May 14, 2020

The PR with the cloud icons has been merged. So if you want to flag these settings for cloud, you can use {ess-icon} or {ece-icon} or both. For an example of how to use, see #65610

@tsullivan tsullivan requested a review from KOTungseth May 14, 2020 22:16
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsullivan tsullivan merged commit 3546f71 into elastic:master May 14, 2020
tsullivan added a commit to tsullivan/kibana that referenced this pull request May 14, 2020
elastic#66267)

* [Docs/Reporting] Have the docs about granular timeout match Cloud docs

* Update docs/settings/reporting-settings.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* re-sync the updates

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* add comma

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
tsullivan added a commit to tsullivan/kibana that referenced this pull request May 14, 2020
elastic#66267)

* [Docs/Reporting] Have the docs about granular timeout match Cloud docs

* Update docs/settings/reporting-settings.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* re-sync the updates

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* add comma

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
tsullivan added a commit to tsullivan/kibana that referenced this pull request May 14, 2020
elastic#66267)

* [Docs/Reporting] Have the docs about granular timeout match Cloud docs

* Update docs/settings/reporting-settings.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* re-sync the updates

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* add comma

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
tsullivan added a commit that referenced this pull request May 15, 2020
#66267) (#66665)

* [Docs/Reporting] Have the docs about granular timeout match Cloud docs

* Update docs/settings/reporting-settings.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* re-sync the updates

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* add comma

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
tsullivan added a commit that referenced this pull request May 15, 2020
#66267) (#66664)

* [Docs/Reporting] Have the docs about granular timeout match Cloud docs

* Update docs/settings/reporting-settings.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* re-sync the updates

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* add comma

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
tsullivan added a commit that referenced this pull request May 15, 2020
#66267) (#66663)

* [Docs/Reporting] Have the docs about granular timeout match Cloud docs

* Update docs/settings/reporting-settings.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* re-sync the updates

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* add comma

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request May 15, 2020
…ent/add-support-in-url-for-hidden-toggle

* 'master' of github.com:elastic/kibana: (34 commits)
  [SIEM][CASE] Fix bug when connector is deleted. (elastic#65876)
  [SIEM][CASE] Improve layout (elastic#66232)
  [Index Management] Support Hidden Indices (elastic#66422)
  Add Login Selector functional tests. (elastic#65705)
  Lens drilldowns (elastic#65675)
  [ML] Custom template for apiDoc markdown (elastic#66567)
  Don't bootstrap core type emits (elastic#66377)
  [Dashboard] Improve loading error handling (elastic#66372)
  [APM] Minor style fixes for the node strokes (elastic#66574)
  [Ingest Manager] Fix create data source from integration (elastic#66626)
  [Metrics UI] Fix default metric alert interval for new conditions (elastic#66610)
  [Metrics UI] Fix alignment and allow clearing metric value (elastic#66589)
  Don't return package name for non-package data streams (elastic#66606)
  [Ingest Manager] Consolidate routing and add breadcrumbs to all pages (elastic#66475)
  [Docs/Reporting] Have the docs about granular timeout match Cloud docs (elastic#66267)
  Don't automatically add license header to code inside plugins dir. (elastic#66601)
  [APM] Don't trigger map layout if no elements (elastic#66625)
  [Logs UI] Validate ML job setup time ranges (elastic#66426)
  Fix pagination bugs in CCR and Remote Clusters (elastic#65931)
  Add cloud icon for supported settings and embed single-sourced getting started (elastic#65610)
  ...

# Conflicts:
#	x-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.js
#	x-pack/plugins/index_management/server/lib/fetch_indices.ts
@tsullivan tsullivan deleted the docs/match-cloud-reporting-settin-dogs branch June 25, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.7.1 v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants