[Ingest Manager] Fix create data source from integration #66626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jen-huang
added
v8.0.0
release_note:skip
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
jen-huang
added
the
bug
|
@elasticmachine merge upstream |
jfsiii
approved these changes
May 14, 2020
| console.debug('Agent config updated', updatedAgentConfig); | ||
| }; | ||
| // eslint-disable-next-line no-console | ||
| console.debug('Agent config updated', updatedAgentConfig); |
There was a problem hiding this comment.
We can also use the logger from AppService now
There was a problem hiding this comment.
I believe Logger is only available as a server-side dependency
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
May 15, 2020
* Fix add datasource button from integration not responsive * Fix React key prop warnings Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
May 15, 2020
* Fix add datasource button from integration not responsive * Fix React key prop warnings Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jen-huang
added a commit
that referenced
this pull request
May 15, 2020
…6680) * Fix add datasource button from integration not responsive * Fix React key prop warnings Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jen-huang
added a commit
that referenced
this pull request
May 15, 2020
…6681) * Fix add datasource button from integration not responsive * Fix React key prop warnings Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
May 15, 2020
…ent/add-support-in-url-for-hidden-toggle * 'master' of github.com:elastic/kibana: (34 commits) [SIEM][CASE] Fix bug when connector is deleted. (elastic#65876) [SIEM][CASE] Improve layout (elastic#66232) [Index Management] Support Hidden Indices (elastic#66422) Add Login Selector functional tests. (elastic#65705) Lens drilldowns (elastic#65675) [ML] Custom template for apiDoc markdown (elastic#66567) Don't bootstrap core type emits (elastic#66377) [Dashboard] Improve loading error handling (elastic#66372) [APM] Minor style fixes for the node strokes (elastic#66574) [Ingest Manager] Fix create data source from integration (elastic#66626) [Metrics UI] Fix default metric alert interval for new conditions (elastic#66610) [Metrics UI] Fix alignment and allow clearing metric value (elastic#66589) Don't return package name for non-package data streams (elastic#66606) [Ingest Manager] Consolidate routing and add breadcrumbs to all pages (elastic#66475) [Docs/Reporting] Have the docs about granular timeout match Cloud docs (elastic#66267) Don't automatically add license header to code inside plugins dir. (elastic#66601) [APM] Don't trigger map layout if no elements (elastic#66625) [Logs UI] Validate ML job setup time ranges (elastic#66426) Fix pagination bugs in CCR and Remote Clusters (elastic#65931) Add cloud icon for supported settings and embed single-sourced getting started (elastic#65610) ... # Conflicts: # x-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.js # x-pack/plugins/index_management/server/lib/fetch_indices.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #66229. I'm tagging this as 7.8 because this is actually a pretty bad bug; the original report was that the Save button does not go into a loading state, but it was actually entirely unresponsive (no data source is created) due to unnecessary re-renders that affected the form validation state. This only affected creating a data source from an integration. To fix this, I wrapped a few methods and components in
useMemoanduseCallback.I also spotted a few React key prop warnings while working on this, so fixed those too.