[SIEM][CASE] Improve layout #66232
Merged
[SIEM][CASE] Improve layout #66232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
cnasikas
requested review from
XavierM,
patrykkopycinski,
stephmilovic and
angorayc
x-pack/plugins/siem/public/cases/components/case_view/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/siem/public/cases/components/case_view/index.tsx
Outdated
Show resolved
Hide resolved
patrykkopycinski
approved these changes
May 14, 2020
Thank you for your help and the helpful pair programming! |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
May 15, 2020
…ent/add-support-in-url-for-hidden-toggle * 'master' of github.com:elastic/kibana: (34 commits) [SIEM][CASE] Fix bug when connector is deleted. (elastic#65876) [SIEM][CASE] Improve layout (elastic#66232) [Index Management] Support Hidden Indices (elastic#66422) Add Login Selector functional tests. (elastic#65705) Lens drilldowns (elastic#65675) [ML] Custom template for apiDoc markdown (elastic#66567) Don't bootstrap core type emits (elastic#66377) [Dashboard] Improve loading error handling (elastic#66372) [APM] Minor style fixes for the node strokes (elastic#66574) [Ingest Manager] Fix create data source from integration (elastic#66626) [Metrics UI] Fix default metric alert interval for new conditions (elastic#66610) [Metrics UI] Fix alignment and allow clearing metric value (elastic#66589) Don't return package name for non-package data streams (elastic#66606) [Ingest Manager] Consolidate routing and add breadcrumbs to all pages (elastic#66475) [Docs/Reporting] Have the docs about granular timeout match Cloud docs (elastic#66267) Don't automatically add license header to code inside plugins dir. (elastic#66601) [APM] Don't trigger map layout if no elements (elastic#66625) [Logs UI] Validate ML job setup time ranges (elastic#66426) Fix pagination bugs in CCR and Remote Clusters (elastic#65931) Add cloud icon for supported settings and embed single-sourced getting started (elastic#65610) ... # Conflicts: # x-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.js # x-pack/plugins/index_management/server/lib/fetch_indices.ts
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
May 15, 2020
cnasikas
added a commit
that referenced
this pull request
May 16, 2020
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
May 16, 2020
# Conflicts: # x-pack/plugins/siem/public/cases/components/case_view/index.tsx # x-pack/plugins/siem/public/cases/pages/case_details.tsx # x-pack/plugins/siem/public/cases/pages/configure_cases.tsx
cnasikas
added a commit
that referenced
this pull request
May 16, 2020
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
WrapperPagecomponent adds theAppGlobalStylewhich is the SIEM's global CSS. Adding multipleWrapperPagecomponents on the same page imports the same CSS rules multiple times. The PR cleans multipleWrapperPagecomponents on the same page.Checklist
Delete any items that are not applicable to this PR.
For maintainers