[Visualize] Bar chart: Show missing values on chart setting #66375

sulemanof · 2020-05-13T10:06:01Z

Summary

Rely on vis.type.name instead of vis.type.type, since the last one is gone.
Can't rely on vis.params.type, since it is not changed when a chart type is changed via select in Metrics & axes panel:

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

ppisljar

code LGTM, could we add a test for this ?

timroes · 2020-05-14T08:06:13Z

I think we should somehow add a functional test for that. Though this would need to check the chart, which will as soon as we switch to elastic-charts (and thus canvas rendering) not be as easy anymore. But we should at least check it for now, and maybe later need to convert it to screenshot tests.

timroes · 2020-05-19T06:59:34Z

@elasticmachine merge upstream

…to fix/bar_chart_values

flash1293

Tested in Firefox and works as expected. I noticed one strange behavior, not sure whether introduced by this PR:

Create a bar chart with two metrics - "show values" is available
Change the first metric to line - "show values" is available (which makes sense as there is still a "bar" metric)
Change the second metric to area - "show values" is available (doesn't make sense, as it's not applied anymore)
Change the second metric to line as well - "show values" is not available any more

kibanamachine · 2020-05-19T09:25:44Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 36faac5

History

💔 Build #47587 failed 4aecde4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sulemanof · 2020-05-19T09:56:50Z

Thanks @flash1293 for the good points you mentioned!
This was not introduced by this PR, but lives for a long.
If this PR is a good place to fix it, I could implement something like:
https://github.com/elastic/kibana/blob/master/src/plugins/vis_type_vislib/public/components/options/metrics_axes/index.tsx#L296
and also update FT to check different chart types and their mix.

Updated:
Checked in 7.3.1, where the feature was introduced #36511,
and there is the same bug exist: (line & area metrics)

flash1293 · 2020-05-19T11:25:59Z

@sulemanof In that case this LGTM

elasticmachine · 2020-05-19T11:27:56Z

Pinging @elastic/kibana-app (Team:KibanaApp)

flash1293

LGTM for GH

…66375) * Show missing switch button * Add functional tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…66375) * Show missing switch button * Add functional tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # src/plugins/vis_type_vislib/public/components/options/point_series/point_series.tsx # test/functional/page_objects/visualize_chart_page.ts # test/functional/page_objects/visualize_editor_page.ts

…67017) * Show missing switch button * Add functional tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…67019) * Show missing switch button * Add functional tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…67025) * Show missing switch button * Add functional tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # src/plugins/vis_type_vislib/public/components/options/point_series/point_series.tsx # test/functional/page_objects/visualize_chart_page.ts # test/functional/page_objects/visualize_editor_page.ts

* master: (33 commits) [Saved Objects] adds support for including hidden types in saved objects client (elastic#66879) [Discover] Deangularize timechart header (elastic#66532) [Discover] Improve and unskip a11y context view test (elastic#66959) [SIEM] Refactor Timeline.timelineType draft to Timeline.status draft (elastic#66864) docs: update RUM documentation link (elastic#67042) [QA] fixup coverage ingestion tests. (elastic#66905) [Metrics UI] Add support for multiple groupings to Metrics Explorer (and Alerts) (elastic#66503) [Metrics UI] Add sorting for name and value to Inventory View (elastic#66644) [Metrics UI] Change Metric Threshold Alert charts to use bar charts (elastic#66672) [Uptime] Use React.lazy for alert type registration (elastic#66829) [Reporting] Consolidate API Integration Test configs (elastic#66637) Allow histogram fields in average and sum aggregations (elastic#66891) Fix saved object share link (elastic#66771) move role reset into the top level after clause (elastic#66971) Automate the labels for any PRs affecting files for the Ingest Management team (elastic#67022) [SIEMDPOINT] Move endpoint to siem (elastic#66907) server.uuid so is not used (elastic#66963) Revert "[ci/stats] fix git metadata collection (elastic#66840)" [Uptime] Unmount uptime app properly (elastic#66950) [Visualize] Bar chart: Show missing values on chart setting (elastic#66375) ...

Show missing switch button

4aecde4

sulemanof requested review from flash1293, timroes and ppisljar May 13, 2020 10:06

sulemanof added v7.7.0 v7.8.0 v7.9.0 v8.0.0 labels May 13, 2020

ppisljar approved these changes May 13, 2020

View reviewed changes

spalger added v7.7.1 and removed v7.7.0 labels May 14, 2020

sulemanof added 2 commits May 14, 2020 12:12

Merge remote-tracking branch 'upstream/master' into fix/bar_chart_values

1440f06

Merge remote-tracking branch 'upstream/master' into fix/bar_chart_values

6fce690

elasticmachine and others added 4 commits May 18, 2020 23:59

Merge branch 'master' into fix/bar_chart_values

dcc5a86

Add functional tests

98dc1b1

Merge remote-tracking branch 'upstream/master' into fix/bar_chart_values

6be3720

Merge branch 'fix/bar_chart_values' of github.com:sulemanof/kibana in…

36faac5

…to fix/bar_chart_values

flash1293 reviewed May 19, 2020

View reviewed changes

sulemanof marked this pull request as ready for review May 19, 2020 11:27

sulemanof requested a review from a team May 19, 2020 11:27

sulemanof added :KibanaApp/fix-it-week release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure labels May 19, 2020

flash1293 approved these changes May 19, 2020

View reviewed changes

sulemanof merged commit b70955b into elastic:master May 19, 2020

sulemanof deleted the fix/bar_chart_values branch May 19, 2020 14:47

sulemanof mentioned this pull request May 19, 2020

[7.x] [Visualize] Bar chart: Show missing values on chart setting (#66375) #67017

Merged

sulemanof mentioned this pull request May 19, 2020

[7.8] [Visualize] Bar chart: Show missing values on chart setting (#66375) #67019

Merged

sulemanof mentioned this pull request May 19, 2020

[7.7] [Visualize] Bar chart: Show missing values on chart setting (#66375) #67025

Merged

sulemanof added the backported label May 19, 2020

sulemanof mentioned this pull request Oct 1, 2020

[Visualize] Horizontal Bar Graph Visualizations have Vertical Bar Graph Type #78536

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Visualize] Bar chart: Show missing values on chart setting #66375

[Visualize] Bar chart: Show missing values on chart setting #66375

sulemanof commented May 13, 2020

ppisljar left a comment

timroes commented May 14, 2020

timroes commented May 19, 2020

flash1293 left a comment •

edited

Loading

kibanamachine commented May 19, 2020

sulemanof commented May 19, 2020 •

edited

Loading

flash1293 commented May 19, 2020

elasticmachine commented May 19, 2020

flash1293 left a comment

[Visualize] Bar chart: Show missing values on chart setting #66375

[Visualize] Bar chart: Show missing values on chart setting #66375

Conversation

sulemanof commented May 13, 2020

Summary

Checklist

For maintainers

ppisljar left a comment

Choose a reason for hiding this comment

timroes commented May 14, 2020

timroes commented May 19, 2020

flash1293 left a comment • edited Loading

Choose a reason for hiding this comment

kibanamachine commented May 19, 2020

💚 Build Succeeded

History

sulemanof commented May 19, 2020 • edited Loading

flash1293 commented May 19, 2020

elasticmachine commented May 19, 2020

flash1293 left a comment

Choose a reason for hiding this comment

flash1293 left a comment •

edited

Loading

sulemanof commented May 19, 2020 •

edited

Loading