Fix saved object share link #66771
Merged
Fix saved object share link #66771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Dosant
approved these changes
May 19, 2020
There was a problem hiding this comment.
Tested in chrome.
When making url for embed got:
<iframe src="http://localhost:5601/amt/app/dashboards#/view/7adfa750-4c81-11e8-b3d7-01146121b73d?embed=true&_g=(filters%3A!()%2CrefreshInterval%3A(pause%3A!f%2Cvalue%3A900000)%2Ctime%3A(from%3Anow-24h%2Cto%3Anow))" height="600" width="800"></iframe>
So no _a anymore.
|
The |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
May 19, 2020
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
May 19, 2020
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
May 19, 2020
flash1293
added a commit
that referenced
this pull request
May 20, 2020
flash1293
added a commit
that referenced
this pull request
May 20, 2020
flash1293
added a commit
that referenced
this pull request
May 20, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 20, 2020
* master: (33 commits) [Saved Objects] adds support for including hidden types in saved objects client (elastic#66879) [Discover] Deangularize timechart header (elastic#66532) [Discover] Improve and unskip a11y context view test (elastic#66959) [SIEM] Refactor Timeline.timelineType draft to Timeline.status draft (elastic#66864) docs: update RUM documentation link (elastic#67042) [QA] fixup coverage ingestion tests. (elastic#66905) [Metrics UI] Add support for multiple groupings to Metrics Explorer (and Alerts) (elastic#66503) [Metrics UI] Add sorting for name and value to Inventory View (elastic#66644) [Metrics UI] Change Metric Threshold Alert charts to use bar charts (elastic#66672) [Uptime] Use React.lazy for alert type registration (elastic#66829) [Reporting] Consolidate API Integration Test configs (elastic#66637) Allow histogram fields in average and sum aggregations (elastic#66891) Fix saved object share link (elastic#66771) move role reset into the top level after clause (elastic#66971) Automate the labels for any PRs affecting files for the Ingest Management team (elastic#67022) [SIEMDPOINT] Move endpoint to siem (elastic#66907) server.uuid so is not used (elastic#66963) Revert "[ci/stats] fix git metadata collection (elastic#66840)" [Uptime] Unmount uptime app properly (elastic#66950) [Visualize] Bar chart: Show missing values on chart setting (elastic#66375) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66760
When making the URL embeddable, the code would accidentally grab the unformatted URL and thus adding back the
_astate to the URL.As part of this PR I also added unit tests for the component to make sure it's not happening again.