[Reporting] Consolidate API Integration Test configs #66637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
release_note:skip
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
|
@elasticmachine merge upstream |
tsullivan
commented
May 18, 2020
| services: { | ||
| ...apiConfig.get('services'), | ||
| reportingAPI: ReportingAPIProvider, | ||
| }, | ||
| kbnTestServer: { | ||
| ...apiConfig.get('kbnTestServer'), | ||
| serverArgs: [ | ||
| '--logging.events.log', | ||
| '["info","warning","error","fatal","optimize","reporting"]', |
There was a problem hiding this comment.
This logging config param was removed, because it isn't the correct way to see debug logs for just Reporting. This is the case since the Reporting config migration.
tsullivan
commented
May 18, 2020
| log.debug(`Report at path ${downloadReportPath} is complete`); | ||
| } else { | ||
| log.debug(`Report at path ${downloadReportPath} returned code ${response.statusCode}`); | ||
| } |
There was a problem hiding this comment.
I added this change because it makes it a bit easier to see what is going on while watching the logs.
tsullivan
commented
May 18, 2020
| import path from 'path'; | ||
|
|
||
| export const OSS_KIBANA_ARCHIVE_PATH = path.resolve( | ||
| __dirname, | ||
| '../../../../test/functional/fixtures/es_archiver/dashboard/current/kibana' | ||
| REPO_ROOT, |
joelgriffith
approved these changes
May 18, 2020
…a into reporting/api-test-unify
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
May 19, 2020
* [Reporting] Consolidate API Integration Test configs * fix test isolation * tweak * import order * fix ts refactor ish * fix a test bug * fix test * --wip-- [skip ci] * revision * undo bad cherrypick * fix delete reports * log tweak * fix default index pattern * fix the test * revert * --wip-- [skip ci] * unrevert * harden the deleteAllReportingIndexes function * fix tests * move the log.debug line * fix config path Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 20, 2020
* master: (33 commits) [Saved Objects] adds support for including hidden types in saved objects client (elastic#66879) [Discover] Deangularize timechart header (elastic#66532) [Discover] Improve and unskip a11y context view test (elastic#66959) [SIEM] Refactor Timeline.timelineType draft to Timeline.status draft (elastic#66864) docs: update RUM documentation link (elastic#67042) [QA] fixup coverage ingestion tests. (elastic#66905) [Metrics UI] Add support for multiple groupings to Metrics Explorer (and Alerts) (elastic#66503) [Metrics UI] Add sorting for name and value to Inventory View (elastic#66644) [Metrics UI] Change Metric Threshold Alert charts to use bar charts (elastic#66672) [Uptime] Use React.lazy for alert type registration (elastic#66829) [Reporting] Consolidate API Integration Test configs (elastic#66637) Allow histogram fields in average and sum aggregations (elastic#66891) Fix saved object share link (elastic#66771) move role reset into the top level after clause (elastic#66971) Automate the labels for any PRs affecting files for the Ingest Management team (elastic#67022) [SIEMDPOINT] Move endpoint to siem (elastic#66907) server.uuid so is not used (elastic#66963) Revert "[ci/stats] fix git metadata collection (elastic#66840)" [Uptime] Unmount uptime app properly (elastic#66950) [Visualize] Bar chart: Show missing values on chart setting (elastic#66375) ...
tsullivan
added a commit
that referenced
this pull request
May 20, 2020
…67052) * [Reporting] Consolidate API Integration Test configs (#66637) * [Reporting] Consolidate API Integration Test configs * fix test isolation * tweak * import order * fix ts refactor ish * fix a test bug * fix test * --wip-- [skip ci] * revision * undo bad cherrypick * fix delete reports * log tweak * fix default index pattern * fix the test * revert * --wip-- [skip ci] * unrevert * harden the deleteAllReportingIndexes function * fix tests * move the log.debug line * fix config path Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * fix script * fix bwc fn tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleans up 2 config.js files that were in place for Reporting API Integration tests, and replaces them with one. The tests are moved to a folder that matches the structure of other X-Pack test code in the repo.
Checklist