[SIEM] Refactor Timeline.timelineType draft to Timeline.status draft #66864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrykkopycinski
added
Team:SIEM
v8.0.0
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
angorayc
reviewed
May 19, 2020
angorayc
reviewed
May 19, 2020
angorayc
approved these changes
May 19, 2020
There was a problem hiding this comment.
Played around with it, all works well! Thank you @patrykkopycinski !!
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 20, 2020
…lastic#66864) # Conflicts: # x-pack/plugins/siem/public/timelines/store/timeline/defaults.ts # x-pack/plugins/siem/public/timelines/store/timeline/epic.ts # x-pack/plugins/siem/public/timelines/store/timeline/model.ts
patrykkopycinski
added a commit
that referenced
this pull request
May 20, 2020
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 20, 2020
…lastic#66864) # Conflicts: # x-pack/plugins/siem/public/alerts/components/signals/actions.test.tsx # x-pack/plugins/siem/public/common/mock/global_state.ts # x-pack/plugins/siem/public/common/mock/timeline_results.ts # x-pack/plugins/siem/public/timelines/components/open_timeline/helpers.test.ts # x-pack/plugins/siem/public/timelines/containers/api.ts # x-pack/plugins/siem/public/timelines/store/timeline/defaults.ts # x-pack/plugins/siem/public/timelines/store/timeline/epic.test.ts # x-pack/plugins/siem/public/timelines/store/timeline/epic.ts # x-pack/plugins/siem/public/timelines/store/timeline/model.ts # x-pack/plugins/siem/public/timelines/store/timeline/reducer.test.ts
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 20, 2020
* master: (33 commits) [Saved Objects] adds support for including hidden types in saved objects client (elastic#66879) [Discover] Deangularize timechart header (elastic#66532) [Discover] Improve and unskip a11y context view test (elastic#66959) [SIEM] Refactor Timeline.timelineType draft to Timeline.status draft (elastic#66864) docs: update RUM documentation link (elastic#67042) [QA] fixup coverage ingestion tests. (elastic#66905) [Metrics UI] Add support for multiple groupings to Metrics Explorer (and Alerts) (elastic#66503) [Metrics UI] Add sorting for name and value to Inventory View (elastic#66644) [Metrics UI] Change Metric Threshold Alert charts to use bar charts (elastic#66672) [Uptime] Use React.lazy for alert type registration (elastic#66829) [Reporting] Consolidate API Integration Test configs (elastic#66637) Allow histogram fields in average and sum aggregations (elastic#66891) Fix saved object share link (elastic#66771) move role reset into the top level after clause (elastic#66971) Automate the labels for any PRs affecting files for the Ingest Management team (elastic#67022) [SIEMDPOINT] Move endpoint to siem (elastic#66907) server.uuid so is not used (elastic#66963) Revert "[ci/stats] fix git metadata collection (elastic#66840)" [Uptime] Unmount uptime app properly (elastic#66950) [Visualize] Bar chart: Show missing values on chart setting (elastic#66375) ...
patrykkopycinski
added a commit
that referenced
this pull request
May 20, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
May 20, 2020
…ent/add-support-in-url-for-hidden-toggle * 'master' of github.com:elastic/kibana: (49 commits) [Uptime] Improve responsiveness details page (elastic#67034) skip flaky suite (elastic#66669) Revert "Integration of a static filesystem for the node_modules (elastic#47998)" (elastic#67124) Support api_integration/kibana/stats against remote hosts (elastic#53000) chore(NA): add module name mapper for src plugins on x-pack (elastic#67103) Change the error message on TSVB in order to be more user friendly (elastic#67090) [kbn/optimizer] poll parent process to avoid zombie processes (elastic#67059) [Visualize] Lazy load default editor, fix duplicated styles (elastic#66732) Bump styled-component dependencies (elastic#66611) Bump react-markdown dependencies (elastic#66615) Fix Core docs links (elastic#66977) Timelion graph is not refreshing content after searching or filtering (elastic#67023) Remove `--xpack.endpoint.enabled=true` from README.md file (elastic#67053) Move apm tutorial from apm plugin into apm_oss plugin (elastic#66432) [Logs UI] Restore call to `UsageCollector.countLogs` (elastic#67051) Remove unused license check result from LP Security plugin (elastic#66966) [Saved Objects] adds support for including hidden types in saved objects client (elastic#66879) [Discover] Deangularize timechart header (elastic#66532) [Discover] Improve and unskip a11y context view test (elastic#66959) [SIEM] Refactor Timeline.timelineType draft to Timeline.status draft (elastic#66864) ... # Conflicts: # x-pack/plugins/index_management/__jest__/client_integration/helpers/home.helpers.ts
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current solution for draft timeline by using
TimelineTypedoesn't allow us to supportdrafttimeline instance perTimelineType, so this PR refactor previously added in #65783TimellineType.draftand instead introduces newstatusfield, which currently will be eitherdraftoractive, but in the future may be used to support more sophisticated timeline flow, like e.x ability to archive the timeline when the case has been closed.Checklist