-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing translation message #8879
Comments
Thanks for the report. We've seen this as well. It should be fixed for future releases by #8710. If you see it again in the next release, please let us know! |
Oh, I read too fast and missed that you are still seeing it. The issue should be that the language files are being cached by the browser for too long. Is it fixed by a "hard refresh" in the browser (usually Cmd-Shift-R or similar)? |
Unfortunately Ctrl-F5 and Ctrl-Shift-R don't help. I still see missing translation messages. |
Can you check which URLs aren't loading using the browser's DevTools? |
I receive 404 for home.html (which I don't have) from Riot\s vhost and _matrix/client/r0/room_keys/version from Synapse's vhost. Other requests are served with 200 or 206. |
What about things like Do those requests succeed? If so, were they updated as part of updating Riot? |
The are 200 but the Date header has an old value. So cached. |
If you search one of the bad strings from the UI in the |
Yes. Checked with "General" and "Preferences". |
Is this still an issue for you? So far, it sounds like you may need to tweak the cache settings of the web server you use to serve Riot so that the browser receives the latest copy. (#8710 should "solve" this in the next release since each version of these files will use a unique URL.) |
No, currently it is fine. I'm not using any fancy caching on web server. It's very basic configuration.There's not much to change here: server { access_log /var/log/nginx/ssl_riot.mydomain-access.log combined; add_header Strict-Transport-Security "max-age=31536000; includeSubDomains" always; ssl_stapling on; ssl_session_timeout 1d; root /opt/riot; |
Hmm. At this point, I am unsure what to suggest. So far, I don't see any evidence that there is a bug in Riot. You have confirmed that the translation files on disk contain the new strings. However, somehow the browser is receiving an old copy when Riot requests it. Could you double-check that the URL for Maybe try unpacking Riot to a fresh directory (assuming you usually unpack new versions on top of old ones) and see if that changes anything? |
I'm sure that files are mapping correctly. For now let's close this issue. I'll try your suggestions about fresh directory if problem happens again. |
* Device manager - scroll to filtered list from security recommendations ([\element-hq#9227](matrix-org/matrix-react-sdk#9227)). Contributed by @kerryarchibald. * Device manager - updated dropdown style in filtered device list ([\element-hq#9226](matrix-org/matrix-react-sdk#9226)). Contributed by @kerryarchibald. * Device manager - device type and verification icons on device tile ([\element-hq#9197](matrix-org/matrix-react-sdk#9197)). Contributed by @kerryarchibald. * Ignore unreads in low priority rooms in the space panel ([\element-hq#6518](matrix-org/matrix-react-sdk#6518)). Fixes element-hq#16836. * Release message right-click context menu out of labs ([\element-hq#8613](matrix-org/matrix-react-sdk#8613)). * Device manager - expandable session details in device list ([\element-hq#9188](matrix-org/matrix-react-sdk#9188)). Contributed by @kerryarchibald. * Device manager - device list filtering ([\element-hq#9181](matrix-org/matrix-react-sdk#9181)). Contributed by @kerryarchibald. * Device manager - add verification details to session details ([\element-hq#9187](matrix-org/matrix-react-sdk#9187)). Contributed by @kerryarchibald. * Device manager - current session expandable details ([\element-hq#9185](matrix-org/matrix-react-sdk#9185)). Contributed by @kerryarchibald. * Device manager - security recommendations section ([\element-hq#9179](matrix-org/matrix-react-sdk#9179)). Contributed by @kerryarchibald. * The Welcome Home Screen: Return Button ([\element-hq#9089](matrix-org/matrix-react-sdk#9089)). Fixes element-hq#22917. Contributed by @justjanne. * Device manager - label devices as inactive ([\element-hq#9175](matrix-org/matrix-react-sdk#9175)). Contributed by @kerryarchibald. * Device manager - other sessions list ([\element-hq#9155](matrix-org/matrix-react-sdk#9155)). Contributed by @kerryarchibald. * Implement MSC3846: Allowing widgets to access TURN servers ([\element-hq#9061](matrix-org/matrix-react-sdk#9061)). * Allow widgets to send/receive to-device messages ([\element-hq#8885](matrix-org/matrix-react-sdk#8885)). * Add super cool feature ([\element-hq#9222](matrix-org/matrix-react-sdk#9222)). Contributed by @gefgu. * Make use of js-sdk roomNameGenerator to handle i18n for generated room names ([\element-hq#9209](matrix-org/matrix-react-sdk#9209)). Fixes element-hq#21369. * Fix progress bar regression throughout the app ([\element-hq#9219](matrix-org/matrix-react-sdk#9219)). Fixes element-hq#23121. * Reuse empty string & space string logic for event types in devtools ([\element-hq#9218](matrix-org/matrix-react-sdk#9218)). Fixes element-hq#23115. * Reduce amount of requests done by the onboarding task list ([\element-hq#9194](matrix-org/matrix-react-sdk#9194)). Fixes element-hq#23085. Contributed by @justjanne. * Avoid hardcoding branding in user onboarding ([\#9206](matrix-org/matrix-react-sdk#9206)). Fixes element-hq#23111. Contributed by @justjanne. * End jitsi call when member is banned ([\element-hq#8879](matrix-org/matrix-react-sdk#8879)). Contributed by @maheichyk. * Fix context menu being opened when clicking message action bar buttons ([\element-hq#9200](matrix-org/matrix-react-sdk#9200)). Fixes element-hq#22279 and element-hq#23100. * Add gap between checkbox and text in report dialog following the same pattern (8px) used in the gap between the two buttons. It fixes element-hq#23060 ([\element-hq#9195](matrix-org/matrix-react-sdk#9195)). Contributed by @gefgu. * Fix url preview AXE and layout issue & add percy test ([\element-hq#9189](matrix-org/matrix-react-sdk#9189)). Fixes element-hq#23083. * Wrap long space names ([\element-hq#9201](matrix-org/matrix-react-sdk#9201)). Fixes element-hq#23095. * Attempt to fix `Failed to execute 'removeChild' on 'Node'` ([\element-hq#9196](matrix-org/matrix-react-sdk#9196)). * Fix soft crash around space hierarchy changing between spaces ([\element-hq#9191](matrix-org/matrix-react-sdk#9191)). Fixes matrix-org/element-web-rageshakes#14613. * Fix soft crash around room view store metrics ([\element-hq#9190](matrix-org/matrix-react-sdk#9190)). Fixes matrix-org/element-web-rageshakes#14361. * Fix the same person appearing multiple times when searching for them. ([\element-hq#9177](matrix-org/matrix-react-sdk#9177)). Fixes element-hq#22851. * Fix space panel subspace indentation going missing ([\element-hq#9167](matrix-org/matrix-react-sdk#9167)). Fixes element-hq#23049. * Fix invisible power levels tile when showing hidden events ([\element-hq#9162](matrix-org/matrix-react-sdk#9162)). Fixes element-hq#23013. * Space panel accessibility improvements ([\element-hq#9157](matrix-org/matrix-react-sdk#9157)). Fixes element-hq#22995. * Fix inverted logic for showing UserWelcomeTop component ([\element-hq#9164](matrix-org/matrix-react-sdk#9164)). Fixes element-hq#23037.
Description
So far I was using Riot 0.17 (and older versions) and I've never seen "missing translation". After I installed 1.0.1 most of strings are preceded with "missing translation" message. I tried to reload Riot and clear cache and reload but the messages are still there. I also tried changing the language but problem persists.
I use Firefox 65.0.1 on Linux, Riot instance I use is self-hosted (on nginx).
For the web app:
The text was updated successfully, but these errors were encountered: