Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing translation message #8879

Closed
worldowner opened this issue Feb 22, 2019 · 14 comments
Closed

missing translation message #8879

worldowner opened this issue Feb 22, 2019 · 14 comments
Labels
T-Other Questions, user support, anything else

Comments

@worldowner
Copy link

Description

So far I was using Riot 0.17 (and older versions) and I've never seen "missing translation". After I installed 1.0.1 most of strings are preceded with "missing translation" message. I tried to reload Riot and clear cache and reload but the messages are still there. I also tried changing the language but problem persists.

I use Firefox 65.0.1 on Linux, Riot instance I use is self-hosted (on nginx).

  • Platform: web

For the web app:

  • Browser: Firefox 65.0.1
  • OS: Linux
  • URL: self-hosted Riot 1.0.1
@jryans
Copy link
Collaborator

jryans commented Feb 22, 2019

Thanks for the report. We've seen this as well. It should be fixed for future releases by #8710. If you see it again in the next release, please let us know!

@jryans jryans closed this as completed Feb 22, 2019
@jryans jryans reopened this Feb 22, 2019
@jryans
Copy link
Collaborator

jryans commented Feb 22, 2019

Oh, I read too fast and missed that you are still seeing it. The issue should be that the language files are being cached by the browser for too long. Is it fixed by a "hard refresh" in the browser (usually Cmd-Shift-R or similar)?

@worldowner
Copy link
Author

worldowner commented Feb 22, 2019

Unfortunately Ctrl-F5 and Ctrl-Shift-R don't help. I still see missing translation messages.

@jryans
Copy link
Collaborator

jryans commented Feb 22, 2019

Can you check which URLs aren't loading using the browser's DevTools?

@worldowner
Copy link
Author

I receive 404 for home.html (which I don't have) from Riot\s vhost and _matrix/client/r0/room_keys/version from Synapse's vhost. Other requests are served with 200 or 206.

@jryans
Copy link
Collaborator

jryans commented Feb 22, 2019

What about things like languages.json, en_EN.json, etc.? These are the Riot files related to strings.

Do those requests succeed? If so, were they updated as part of updating Riot?

@worldowner
Copy link
Author

The are 200 but the Date header has an old value. So cached.
I'm sure that everything was updated. I untar new version, copy config file and then change symlink so that it points to new version.

@jryans
Copy link
Collaborator

jryans commented Feb 22, 2019

If you search one of the bad strings from the UI in the en_EN.json file, is it there?

@worldowner
Copy link
Author

Yes. Checked with "General" and "Preferences".

@jryans
Copy link
Collaborator

jryans commented Feb 26, 2019

Is this still an issue for you? So far, it sounds like you may need to tweak the cache settings of the web server you use to serve Riot so that the browser receives the latest copy. (#8710 should "solve" this in the next release since each version of these files will use a unique URL.)

@lampholder lampholder added the T-Other Questions, user support, anything else label Feb 27, 2019
@worldowner
Copy link
Author

No, currently it is fine. I'm not using any fancy caching on web server. It's very basic configuration.There's not much to change here:

server {
listen 443 ssl http2;
server_name riot.mydomain;

access_log /var/log/nginx/ssl_riot.mydomain-access.log combined;
error_log /var/log/nginx/ssl_riot.mydomain-error.log error;

add_header Strict-Transport-Security "max-age=31536000; includeSubDomains" always;

ssl_stapling on;
ssl_stapling_verify on;
ssl_trusted_certificate /etc/letsencrypt/live/mydomain/fullchain.pem;
ssl_certificate /etc/letsencrypt/live/mydomain/fullchain.pem;
ssl_certificate_key /etc/letsencrypt/live/mydomain/privkey.pem;
ssl_dhparam /etc/letsencrypt/live/dhparam.pem;

ssl_session_timeout 1d;
ssl_protocols TLSv1.2 TLSv1.3;
ssl_ciphers 'EECDH+AESGCM:EDH+AESGCM:AES256+EECDH:AES256+EDH';
ssl_prefer_server_ciphers on;
ssl_session_cache shared:SSL:50m;

root /opt/riot;
index index.html;
}

@jryans
Copy link
Collaborator

jryans commented Feb 28, 2019

Hmm. At this point, I am unsure what to suggest. So far, I don't see any evidence that there is a bug in Riot. You have confirmed that the translation files on disk contain the new strings. However, somehow the browser is receiving an old copy when Riot requests it.

Could you double-check that the URL for en_EN.json that Riot is requesting actually maps to the new file where you found the correct strings? (I'm running out of ideas on how this could go wrong...)

Maybe try unpacking Riot to a fresh directory (assuming you usually unpack new versions on top of old ones) and see if that changes anything?

@worldowner
Copy link
Author

I'm sure that files are mapping correctly. For now let's close this issue. I'll try your suggestions about fresh directory if problem happens again.

@NonstickAtom785
Copy link

I'm getting a bug that states this on Chrome OS. It only shows up a few times and I have to close app and reopen it. Not I'm using the web application and not the Android App.

Here's a screenshot:
image

su-ex added a commit to SchildiChat/element-web that referenced this issue Sep 1, 2022
* Device manager - scroll to filtered list from security recommendations ([\element-hq#9227](matrix-org/matrix-react-sdk#9227)). Contributed by @kerryarchibald.
* Device manager - updated dropdown style in filtered device list ([\element-hq#9226](matrix-org/matrix-react-sdk#9226)). Contributed by @kerryarchibald.
* Device manager - device type and verification icons on device tile ([\element-hq#9197](matrix-org/matrix-react-sdk#9197)). Contributed by @kerryarchibald.
* Ignore unreads in low priority rooms in the space panel ([\element-hq#6518](matrix-org/matrix-react-sdk#6518)). Fixes element-hq#16836.
* Release message right-click context menu out of labs ([\element-hq#8613](matrix-org/matrix-react-sdk#8613)).
* Device manager - expandable session details in device list ([\element-hq#9188](matrix-org/matrix-react-sdk#9188)). Contributed by @kerryarchibald.
* Device manager - device list filtering ([\element-hq#9181](matrix-org/matrix-react-sdk#9181)). Contributed by @kerryarchibald.
* Device manager - add verification details to session details ([\element-hq#9187](matrix-org/matrix-react-sdk#9187)). Contributed by @kerryarchibald.
* Device manager - current session expandable details ([\element-hq#9185](matrix-org/matrix-react-sdk#9185)). Contributed by @kerryarchibald.
* Device manager - security recommendations section ([\element-hq#9179](matrix-org/matrix-react-sdk#9179)). Contributed by @kerryarchibald.
* The Welcome Home Screen: Return Button ([\element-hq#9089](matrix-org/matrix-react-sdk#9089)). Fixes element-hq#22917. Contributed by @justjanne.
* Device manager - label devices as inactive ([\element-hq#9175](matrix-org/matrix-react-sdk#9175)). Contributed by @kerryarchibald.
* Device manager - other sessions list ([\element-hq#9155](matrix-org/matrix-react-sdk#9155)). Contributed by @kerryarchibald.
* Implement MSC3846: Allowing widgets to access TURN servers ([\element-hq#9061](matrix-org/matrix-react-sdk#9061)).
* Allow widgets to send/receive to-device messages ([\element-hq#8885](matrix-org/matrix-react-sdk#8885)).
* Add super cool feature ([\element-hq#9222](matrix-org/matrix-react-sdk#9222)). Contributed by @gefgu.
* Make use of js-sdk roomNameGenerator to handle i18n for generated room names ([\element-hq#9209](matrix-org/matrix-react-sdk#9209)). Fixes element-hq#21369.
* Fix progress bar regression throughout the app ([\element-hq#9219](matrix-org/matrix-react-sdk#9219)). Fixes element-hq#23121.
* Reuse empty string & space string logic for event types in devtools ([\element-hq#9218](matrix-org/matrix-react-sdk#9218)). Fixes element-hq#23115.
* Reduce amount of requests done by the onboarding task list ([\element-hq#9194](matrix-org/matrix-react-sdk#9194)). Fixes element-hq#23085. Contributed by @justjanne.
* Avoid hardcoding branding in user onboarding ([\#9206](matrix-org/matrix-react-sdk#9206)). Fixes element-hq#23111. Contributed by @justjanne.
* End jitsi call when member is banned ([\element-hq#8879](matrix-org/matrix-react-sdk#8879)). Contributed by @maheichyk.
* Fix context menu being opened when clicking message action bar buttons ([\element-hq#9200](matrix-org/matrix-react-sdk#9200)). Fixes element-hq#22279 and element-hq#23100.
* Add gap between checkbox and text in report dialog following the same pattern (8px) used in the gap between the two buttons. It fixes element-hq#23060 ([\element-hq#9195](matrix-org/matrix-react-sdk#9195)). Contributed by @gefgu.
* Fix url preview AXE and layout issue & add percy test ([\element-hq#9189](matrix-org/matrix-react-sdk#9189)). Fixes element-hq#23083.
* Wrap long space names ([\element-hq#9201](matrix-org/matrix-react-sdk#9201)). Fixes element-hq#23095.
* Attempt to fix `Failed to execute 'removeChild' on 'Node'` ([\element-hq#9196](matrix-org/matrix-react-sdk#9196)).
* Fix soft crash around space hierarchy changing between spaces ([\element-hq#9191](matrix-org/matrix-react-sdk#9191)). Fixes matrix-org/element-web-rageshakes#14613.
* Fix soft crash around room view store metrics ([\element-hq#9190](matrix-org/matrix-react-sdk#9190)). Fixes matrix-org/element-web-rageshakes#14361.
* Fix the same person appearing multiple times when searching for them. ([\element-hq#9177](matrix-org/matrix-react-sdk#9177)). Fixes element-hq#22851.
* Fix space panel subspace indentation going missing ([\element-hq#9167](matrix-org/matrix-react-sdk#9167)). Fixes element-hq#23049.
* Fix invisible power levels tile when showing hidden events ([\element-hq#9162](matrix-org/matrix-react-sdk#9162)). Fixes element-hq#23013.
* Space panel accessibility improvements ([\element-hq#9157](matrix-org/matrix-react-sdk#9157)). Fixes element-hq#22995.
* Fix inverted logic for showing UserWelcomeTop component ([\element-hq#9164](matrix-org/matrix-react-sdk#9164)). Fixes element-hq#23037.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Other Questions, user support, anything else
Projects
None yet
Development

No branches or pull requests

4 participants