Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI build doesn't work / Switch to BuildKite now #9164

Closed
turt2live opened this issue Mar 13, 2019 · 8 comments
Closed

CI build doesn't work / Switch to BuildKite now #9164

turt2live opened this issue Mar 13, 2019 · 8 comments
Assignees
@turt2live
Labels
P1 S-Critical Prevents work, causes data loss and/or has no workaround T-Task Tasks for the team like planning

Comments

@turt2live
Copy link
Member

Seems to only apply to the riot-web repo for some reason. Random unit tests often fail for no obvious reason, and sometimes the build crashes entirely at yarn install.

https://travis-ci.org/vector-im/riot-web/jobs/505974036 is an example of this.
@turt2live
Copy link
Member Author

Upgrading this to "the CI is literally useless" now that react-sdk builds are failing:

An unexpected error occurred: "https://registry.yarnpkg.com/@xtuc/long/-/long-4.2.2.tgz: Request failed "502 Bad Gateway"".

@turt2live turt2live added T-Task Tasks for the team like planning P1 S-Critical Prevents work, causes data loss and/or has no workaround labels Mar 13, 2019
@turt2live turt2live changed the title CI build is unstable since Yarn CI build doesn't work Mar 13, 2019
@turt2live turt2live self-assigned this Mar 13, 2019
@turt2live turt2live changed the title CI build doesn't work 🔥🔥🔥 CI build doesn't work Mar 13, 2019
@turt2live
Copy link
Member Author

Annoyingly I can't reproduce this locally, so it might be a Travis CI + yarn/npm issue and not our fault. Getting 503 errors in CI logs now.

@turt2live turt2live mentioned this issue Mar 13, 2019
Merged
@turt2live turt2live changed the title 🔥🔥🔥 CI build doesn't work 🔥🔥🔥 CI build doesn't work / Switch to BuildKite now Mar 13, 2019
@turt2live
Copy link
Member Author

Travis CI is failing us, so we're jumping to BuildKite by just migrating what we have. #9019 will later make the pipelines better.

@turt2live turt2live mentioned this issue Mar 13, 2019
Merged
@turt2live
Copy link
Member Author

Somewhere between me opening this issue and now, NPM realized that their stuff is broken: https://status.npmjs.org/incidents/3p30y0pkblsp

This causes BuildKite builds to also fail for the same reasons as Travis CI, however I also think that switching to BuildKite now is a good plan all around. Going to move ahead on BuildKite and hope npm fixes their stuff before UK morning so the PRs can safely go up for review with green checkmarks.

@turt2live turt2live mentioned this issue Mar 14, 2019
Merged
@turt2live
Copy link
Member Author

npm has fixed the issue, now there's just a couple things to fix:

  • Status checks aren't landing on riot-web due to lack of permissions
  • The builds are a bit massive and are blowing out the resource limit on the workers

@jryans
Copy link
Collaborator

jryans commented Mar 14, 2019

An unexpected error occurred: "https://registry.yarnpkg.com/@xtuc/long/-/long-4.2.2.tgz: Request failed "502 Bad Gateway"".

For future reference, I believe the "Yarn registry" is just a CNAME to npm's registry, so if we see errors with registry.yarnpkg.com, we should something similar when using npm as well.

@turt2live
Copy link
Member Author

I've fixed vector-im not allowing BuildKite to manipulate status checks, so riot-web should now receive them.

I've also tested the build a couple times today to see if I could reproduce the "running out of memory" problem - it appears as though the problem has gone away, however I'm still going to recommend we get larger instances sooner rather than later.

@turt2live turt2live changed the title 🔥🔥🔥 CI build doesn't work / Switch to BuildKite now CI build doesn't work / Switch to BuildKite now Mar 14, 2019
@turt2live
Copy link
Member Author

Landed 🎉

Future work to be dealt with in #9019

su-ex added a commit to SchildiChat/element-web that referenced this issue Sep 1, 2022
@su-ex
Merge tag 'v1.11.4' into sc
167861c 
* Device manager - scroll to filtered list from security recommendations ([\element-hq#9227](matrix-org/matrix-react-sdk#9227)). Contributed by @kerryarchibald.
* Device manager - updated dropdown style in filtered device list ([\element-hq#9226](matrix-org/matrix-react-sdk#9226)). Contributed by @kerryarchibald.
* Device manager - device type and verification icons on device tile ([\element-hq#9197](matrix-org/matrix-react-sdk#9197)). Contributed by @kerryarchibald.
* Ignore unreads in low priority rooms in the space panel ([\element-hq#6518](matrix-org/matrix-react-sdk#6518)). Fixes element-hq#16836.
* Release message right-click context menu out of labs ([\element-hq#8613](matrix-org/matrix-react-sdk#8613)).
* Device manager - expandable session details in device list ([\element-hq#9188](matrix-org/matrix-react-sdk#9188)). Contributed by @kerryarchibald.
* Device manager - device list filtering ([\element-hq#9181](matrix-org/matrix-react-sdk#9181)). Contributed by @kerryarchibald.
* Device manager - add verification details to session details ([\element-hq#9187](matrix-org/matrix-react-sdk#9187)). Contributed by @kerryarchibald.
* Device manager - current session expandable details ([\element-hq#9185](matrix-org/matrix-react-sdk#9185)). Contributed by @kerryarchibald.
* Device manager - security recommendations section ([\element-hq#9179](matrix-org/matrix-react-sdk#9179)). Contributed by @kerryarchibald.
* The Welcome Home Screen: Return Button ([\element-hq#9089](matrix-org/matrix-react-sdk#9089)). Fixes element-hq#22917. Contributed by @justjanne.
* Device manager - label devices as inactive ([\element-hq#9175](matrix-org/matrix-react-sdk#9175)). Contributed by @kerryarchibald.
* Device manager - other sessions list ([\element-hq#9155](matrix-org/matrix-react-sdk#9155)). Contributed by @kerryarchibald.
* Implement MSC3846: Allowing widgets to access TURN servers ([\element-hq#9061](matrix-org/matrix-react-sdk#9061)).
* Allow widgets to send/receive to-device messages ([\element-hq#8885](matrix-org/matrix-react-sdk#8885)).
* Add super cool feature ([\element-hq#9222](matrix-org/matrix-react-sdk#9222)). Contributed by @gefgu.
* Make use of js-sdk roomNameGenerator to handle i18n for generated room names ([\element-hq#9209](matrix-org/matrix-react-sdk#9209)). Fixes element-hq#21369.
* Fix progress bar regression throughout the app ([\element-hq#9219](matrix-org/matrix-react-sdk#9219)). Fixes element-hq#23121.
* Reuse empty string & space string logic for event types in devtools ([\element-hq#9218](matrix-org/matrix-react-sdk#9218)). Fixes element-hq#23115.
* Reduce amount of requests done by the onboarding task list ([\element-hq#9194](matrix-org/matrix-react-sdk#9194)). Fixes element-hq#23085. Contributed by @justjanne.
* Avoid hardcoding branding in user onboarding ([\#9206](matrix-org/matrix-react-sdk#9206)). Fixes element-hq#23111. Contributed by @justjanne.
* End jitsi call when member is banned ([\element-hq#8879](matrix-org/matrix-react-sdk#8879)). Contributed by @maheichyk.
* Fix context menu being opened when clicking message action bar buttons ([\element-hq#9200](matrix-org/matrix-react-sdk#9200)). Fixes element-hq#22279 and element-hq#23100.
* Add gap between checkbox and text in report dialog following the same pattern (8px) used in the gap between the two buttons. It fixes element-hq#23060 ([\element-hq#9195](matrix-org/matrix-react-sdk#9195)). Contributed by @gefgu.
* Fix url preview AXE and layout issue & add percy test ([\element-hq#9189](matrix-org/matrix-react-sdk#9189)). Fixes element-hq#23083.
* Wrap long space names ([\element-hq#9201](matrix-org/matrix-react-sdk#9201)). Fixes element-hq#23095.
* Attempt to fix `Failed to execute 'removeChild' on 'Node'` ([\element-hq#9196](matrix-org/matrix-react-sdk#9196)).
* Fix soft crash around space hierarchy changing between spaces ([\element-hq#9191](matrix-org/matrix-react-sdk#9191)). Fixes matrix-org/element-web-rageshakes#14613.
* Fix soft crash around room view store metrics ([\element-hq#9190](matrix-org/matrix-react-sdk#9190)). Fixes matrix-org/element-web-rageshakes#14361.
* Fix the same person appearing multiple times when searching for them. ([\element-hq#9177](matrix-org/matrix-react-sdk#9177)). Fixes element-hq#22851.
* Fix space panel subspace indentation going missing ([\element-hq#9167](matrix-org/matrix-react-sdk#9167)). Fixes element-hq#23049.
* Fix invisible power levels tile when showing hidden events ([\element-hq#9162](matrix-org/matrix-react-sdk#9162)). Fixes element-hq#23013.
* Space panel accessibility improvements ([\element-hq#9157](matrix-org/matrix-react-sdk#9157)). Fixes element-hq#22995.
* Fix inverted logic for showing UserWelcomeTop component ([\element-hq#9164](matrix-org/matrix-react-sdk#9164)). Fixes element-hq#23037.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
P1 S-Critical Prevents work, causes data loss and/or has no workaround T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jryans @turt2live