Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana Widget does not work in Windows App but in Browser #9167

Closed
vmario89 opened this issue Mar 14, 2019 · 13 comments
Closed

Grafana Widget does not work in Windows App but in Browser #9167

vmario89 opened this issue Mar 14, 2019 · 13 comments

Comments

@vmario89
Copy link

Hi,
i am running Riot 1.0.1 and using matrix-dimension to embed widgets. I figured out that displaying a widget works in within Browser based riot, but not in the electron provided Windows Application.

I tested the same stuff with vector.im integrations. same situation. Seems to be Riot-related. I double checked config.json - this is the same in Desktop App as well as on web server.

Is there any config setting i am missing?

regards, Mario

@lampholder
Copy link
Member

@jaywink any thoughts?

@jaywink
Copy link
Member

jaywink commented Mar 19, 2019

@lampholder unfortunately no. This seems like an issue with the Riot desktop build for Windows since the widget has been confirmed to work by op in riot web - so I think we should rule Scalar and/or Dimension here.

@jaywink
Copy link
Member

jaywink commented Mar 19, 2019

@vmario89 Riot 1.0.4 was released yesterday - would you mind upgrading and seeing if the problem persists? Thanks

@lampholder
Copy link
Member

Hey @vmario89 would you be able to describe in more detail how it isn't working?

I just tried a grafana widget on electron macOS - when I tried to load the widget, I got:

  • a prompt to log in with username/password or github
  • when I try and log in with github, I get a white screen

Is that what you're getting, or another failure mode?

For future reference, screenshots are hugely valuable when trying to debug Riot :)

@vmario89
Copy link
Author

Hi,
i have the following behaviour:

  • displaying Grafana widget inside riot.fablabchemnitz.de works fine (version 1.0.4-rc1)
  • displaying Grafana wdiget outside riot client, which is redirected to https://dimension.fablabchemnitz.de/widgets/generic-fullscreen?url=https.... and so and works fine too
  • displaying Grafana widget inside Windows Riot Client (v1.0.4) does not work. It gives prompt to login inside Grafana. After entering credentials nothing happens. just showing login mask again

I am running exact same config.json for Windows App and web client.

@jaywink
Copy link
Member

jaywink commented Mar 20, 2019

Thanks for the additional information @vmario89 . I'm summoning @turt2live related to the Dimension connection here.

displaying Grafana widget inside Windows Riot Client (v1.0.4) does not work. It gives prompt to login inside Grafana. After entering credentials nothing happens. just showing login mask again

When saying "Windows client", did you build this yourself or is it a vanilla build? What I'm looking at is whether the integration manager was "Scalar" or "Dimension" in this case. If you don't mind giving your Matrix ID, I could have a look from Scalar side what might show there. You can send it to me via PM at @jaywink:federator.dev if you prefer.

@vmario89
Copy link
Author

hey. thanks for that, i just sent you some message right now. regards, Mario

@jaywink jaywink removed the A-Scalar label Mar 20, 2019
@jaywink
Copy link
Member

jaywink commented Mar 20, 2019

So confirmed in chat that Dimension is the integration manager used here. However, there is some kind of issue with Riot too since we've confirmed on our end with Scalar the Grafana GitHub login flow doesn't work with desktop riot, but works with web riot.

@turt2live
Copy link
Member

turt2live commented Mar 24, 2019

Sorry for the late reply - I don't think this is an integration manager problem. Given it reportedly doesn't work in Dimension or Scalar, and I can't reproduce this using dimension.t2bot.io, I think this might be a CORS issue or similar. Double check that your Grafana instance isn't locked to a specific domain, and that it is allowed to be put into an iframe.

Riot, Dimension, and Scalar all just use iframes so it is usually a matter of getting the right CORS stuff worked out, and possibly might be a bug in Grafana itself (would need to confirm this though).

@turt2live
Copy link
Member

also ftr, Dimension seems to also get the white screen of death when logging in with Github: turt2live/matrix-dimension#257

@vmario89
Copy link
Author

The log says the following:
grafik

@jaywink jaywink self-assigned this Aug 12, 2019
@jaywink
Copy link
Member

jaywink commented Aug 16, 2019

Unfortunately there isn't a terrible lot we can do about the white screen of death on trying to use GitHub for login. They disallow this with a combination of Content-Security-Policy: frame-ancestors 'none'; and (for older browsers X-Frame-Options: deny headers. Browsers are doing the right thing by not allowing the resource to be loaded.

Username/password login works fine for me at least. @vmario89 could you confirm once more which one of the following you are seeing? I fail to see a clear mention above.

  1. username/password login does not work for grafana
  2. github or other oauth login does not work for grafana
  3. something else? (please describe and include screenshots)

Thanks!

@jaywink
Copy link
Member

jaywink commented Aug 25, 2019

Closing for now as there is no new information.

@jaywink jaywink closed this as completed Aug 25, 2019
su-ex added a commit to SchildiChat/element-web that referenced this issue Sep 1, 2022
* Device manager - scroll to filtered list from security recommendations ([\element-hq#9227](matrix-org/matrix-react-sdk#9227)). Contributed by @kerryarchibald.
* Device manager - updated dropdown style in filtered device list ([\element-hq#9226](matrix-org/matrix-react-sdk#9226)). Contributed by @kerryarchibald.
* Device manager - device type and verification icons on device tile ([\element-hq#9197](matrix-org/matrix-react-sdk#9197)). Contributed by @kerryarchibald.
* Ignore unreads in low priority rooms in the space panel ([\element-hq#6518](matrix-org/matrix-react-sdk#6518)). Fixes element-hq#16836.
* Release message right-click context menu out of labs ([\element-hq#8613](matrix-org/matrix-react-sdk#8613)).
* Device manager - expandable session details in device list ([\element-hq#9188](matrix-org/matrix-react-sdk#9188)). Contributed by @kerryarchibald.
* Device manager - device list filtering ([\element-hq#9181](matrix-org/matrix-react-sdk#9181)). Contributed by @kerryarchibald.
* Device manager - add verification details to session details ([\element-hq#9187](matrix-org/matrix-react-sdk#9187)). Contributed by @kerryarchibald.
* Device manager - current session expandable details ([\element-hq#9185](matrix-org/matrix-react-sdk#9185)). Contributed by @kerryarchibald.
* Device manager - security recommendations section ([\element-hq#9179](matrix-org/matrix-react-sdk#9179)). Contributed by @kerryarchibald.
* The Welcome Home Screen: Return Button ([\element-hq#9089](matrix-org/matrix-react-sdk#9089)). Fixes element-hq#22917. Contributed by @justjanne.
* Device manager - label devices as inactive ([\element-hq#9175](matrix-org/matrix-react-sdk#9175)). Contributed by @kerryarchibald.
* Device manager - other sessions list ([\element-hq#9155](matrix-org/matrix-react-sdk#9155)). Contributed by @kerryarchibald.
* Implement MSC3846: Allowing widgets to access TURN servers ([\element-hq#9061](matrix-org/matrix-react-sdk#9061)).
* Allow widgets to send/receive to-device messages ([\element-hq#8885](matrix-org/matrix-react-sdk#8885)).
* Add super cool feature ([\element-hq#9222](matrix-org/matrix-react-sdk#9222)). Contributed by @gefgu.
* Make use of js-sdk roomNameGenerator to handle i18n for generated room names ([\element-hq#9209](matrix-org/matrix-react-sdk#9209)). Fixes element-hq#21369.
* Fix progress bar regression throughout the app ([\element-hq#9219](matrix-org/matrix-react-sdk#9219)). Fixes element-hq#23121.
* Reuse empty string & space string logic for event types in devtools ([\element-hq#9218](matrix-org/matrix-react-sdk#9218)). Fixes element-hq#23115.
* Reduce amount of requests done by the onboarding task list ([\element-hq#9194](matrix-org/matrix-react-sdk#9194)). Fixes element-hq#23085. Contributed by @justjanne.
* Avoid hardcoding branding in user onboarding ([\#9206](matrix-org/matrix-react-sdk#9206)). Fixes element-hq#23111. Contributed by @justjanne.
* End jitsi call when member is banned ([\element-hq#8879](matrix-org/matrix-react-sdk#8879)). Contributed by @maheichyk.
* Fix context menu being opened when clicking message action bar buttons ([\element-hq#9200](matrix-org/matrix-react-sdk#9200)). Fixes element-hq#22279 and element-hq#23100.
* Add gap between checkbox and text in report dialog following the same pattern (8px) used in the gap between the two buttons. It fixes element-hq#23060 ([\element-hq#9195](matrix-org/matrix-react-sdk#9195)). Contributed by @gefgu.
* Fix url preview AXE and layout issue & add percy test ([\element-hq#9189](matrix-org/matrix-react-sdk#9189)). Fixes element-hq#23083.
* Wrap long space names ([\element-hq#9201](matrix-org/matrix-react-sdk#9201)). Fixes element-hq#23095.
* Attempt to fix `Failed to execute 'removeChild' on 'Node'` ([\element-hq#9196](matrix-org/matrix-react-sdk#9196)).
* Fix soft crash around space hierarchy changing between spaces ([\element-hq#9191](matrix-org/matrix-react-sdk#9191)). Fixes matrix-org/element-web-rageshakes#14613.
* Fix soft crash around room view store metrics ([\element-hq#9190](matrix-org/matrix-react-sdk#9190)). Fixes matrix-org/element-web-rageshakes#14361.
* Fix the same person appearing multiple times when searching for them. ([\element-hq#9177](matrix-org/matrix-react-sdk#9177)). Fixes element-hq#22851.
* Fix space panel subspace indentation going missing ([\element-hq#9167](matrix-org/matrix-react-sdk#9167)). Fixes element-hq#23049.
* Fix invisible power levels tile when showing hidden events ([\element-hq#9162](matrix-org/matrix-react-sdk#9162)). Fixes element-hq#23013.
* Space panel accessibility improvements ([\element-hq#9157](matrix-org/matrix-react-sdk#9157)). Fixes element-hq#22995.
* Fix inverted logic for showing UserWelcomeTop component ([\element-hq#9164](matrix-org/matrix-react-sdk#9164)). Fixes element-hq#23037.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants