pull #1
Merged
pull #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use the textless endpoint (/api/queries/:id/results) for pristine queriest * reverse conditional. not not is making me the headaches. * add ParameterizedQuery#is_safe with an inital naive implementation which treats any query with a text parameter as not safe. This will be remedied later when DB drivers will handle these parameters. * allow getting new query results even if user has only view permissions to the data source (given that the query is safe) * fix lint error - getDerivedStateFromProps should be placed after state * Revert "use the textless endpoint (/api/queries/:id/results) for pristine" This reverts commit cd2cee7. * move execution preparation to a different function, which will be soon reused * go to textless /api/queries/:id/results by default * let the query view decide if text or textless endpoint is needed * allow safe queries to be executed in the UI even if the user has no permission to execute and create new query results * change `run_query`'s signature to accept a ParameterizedQuery instead of constructing it inside * use dict#get instead of a None guard * use ParameterizedQuery in queries handler as well * test that /queries/:id/results allows execution of safe queries even if user has view_only permissions * lint * raise HTTP 400 when receiving invalid parameter values. Fixes #3394 * remove unused methods * avoid cyclic imports by importing only when needed * verify that a ParameterizedQuery without any parameters is considered safe * introduce query.parameter_schema * encapsulate ParameterizedQuery creation inside Query
…3500) handling invites (as opposed to password reset links)
#3333) * adding gevent worker in requirements.txt, adding some gunicorn configurable parameters with defaults * reverting the change as it's going to be set via env variable(s)
* re-verify e-mail address on change * send verification e-mail to the new address
…_LDAP_AUTH_BIND (#2776) * Add two new envars. REDASH_LDAP_USE_SSL which determines if the connection will use ssl and LDAP_AUTH_BIND which determines if the binding is SIMPLE or ANONYMOUS * Add use_ssl paremeter * Rename LDAP_AUTH_BIND to LDAP_AUTH_METHOD and modify LDAP_SSL using parse_boolean * Fix typo * import ANONYMOUS constant from ldap3 * Add NTLM authentication * Add comment to authentication method envar
* Updated npm to support react hooks * Added <QuerySelector /> * Changed selectQuery to also clear, completed 2->3 dots in msg, avoiding setSearching on stale rejection. * Removed unused highlight lib
* Make sure master builds tarball/docker image only when backend and frontend tests pass. * Build a redash/preview image alongside redash/redash image. * Fix version variable
* Fixed navbar responsiveness * Adjustments so that logo should never hide
* append slug to /verification_email endpoint when in MULTI_ORG mode * Revert "append slug to /verification_email endpoint when in MULTI_ORG mode" This reverts commit 817fb03. * fix for /email_verification in MULTI_ORG setups
* Create React version for the EmailSettingsWarning * Migrate the Create User Page * Migrate UserProfile to React * Add /users/me to the routes (Percy ftw) * Fix UserShow test spec * Remove Error Messages component * Show invitation link if email server not setup (#3519) * return invite link to client if e-mail server is not set up * add a couple of tests to make sure invite links are only returned when neccessary * show invite link when e-mail is not configured * remove "an e-mail has been sent" when there's no e-mail configured * return invite_url in re-invites as well. Also refactor to reuse the code. * Use CreateUserDialog instead of Page * Render invite link on Resend Invitation click * Add email validation to DynamicForm * Fix EmailWarning position + update user list with user creation success * Fix console error on UserProfile * Redirect from /users/new + rename createUser -> showCreateUserDialog * Use alert instead of toastr for user creation errors * Remove logic from CreateUserDialog * CR * Use Promise.reject instead of throw to avoid console error
* Add support for Google Hangouts Chat as alert destination * Remove redundant imports * Remove code used for debugging * Fix pep8 warnings * Update redash/destinations/hangoutschat.py Add friendly name by separating type and description Co-Authored-By: pieter-venter <pieterventer@geotab.com> * Fix pep8 warnings. Rename image to match desitnation type. * Show message for unknown alert state in default color
Since the svv_columns system view supports them now https://docs.aws.amazon.com/redshift/latest/dg/r_SVV_COLUMNS.html
* Name help text for date range only * Autofocus on name input * Form acts on enter key * Fixed range check * Fixed startsWith
Newer versions dropped support for Python 2. Closes #3542.
## What type of PR is this? (check all applicable) - [x] Refactor - [x] Bug Fix ## Description Move favorites list handlers to their relevant modules (`redash.handlers.queries` and `redash.handlers.dashboards`) and applied `order_results` to dashboards.
…ore reliable test connection (#3883) * Google Sheets: friendlier error message in case of an APIError and more reliable test connection. * Pleasing the pep8 gods
* Add support ssl connections to redis * Fix line length * Update redash/__init__.py w suggestion Co-Authored-By: Omer Lachish <omer@rauchy.net> * Cleanup init after suggestion * Move redis SSL config to settings * Do not pass celery SSL config unless necessary * Fix typo
* Celery task to clear schedule was added * fix formating * empty_schedules task was put in separate task * worker interval changed, new tests added * past artifact deleted * test queries moved to right class, lambda was used to filter data * unnecessary changes eliminated * more unnecessary files deleted * line shortened * Line shortened more * codeclimate changes * Unused test deleted, logs added
* Add regenerate function of query's API Key * Add regenerate API Key button * Add regenerate Query API Key tests * Fix too long line * Replace with this * Return a simple version query * Update only API Key * Update API Key via query
* Add keyboard shortcut for format query * Added to button tooltip
* Expose celery job timeout to env * Change variable name
This will help me target the Query Control Drodpwon in my extension.
So that changing other files will not trigger the very expensive rebuild process.
…eload spinner forever (#3939)
* Details visualization * Add PropTypes and guard against no rows
* Add option to hide Pivot Table totals * Simplify implementation using DEFAULT_OPTIONS. * Flip hide pivot controls to show pivot controls * Update client/app/visualizations/pivot/Editor.jsx Co-Authored-By: Ran Byron <ranbena@gmail.com>
* supply a parameter value for text parameters to have it show up * add parameter values for date and datetime * use the current year and month to avoid pagination * use Cypress.moment() instead of preinstalled moment() * capture time before clicking on Now * use now from input * use now from input for another test
* Fix: waiting tasks are not shown properly * Added a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull