go get .../cmd/evm fails.

[nejucomo]

I currently cannot install the evm command from a shell:

$ go get github.com/ethereum/go-ethereum/cmd/evm
# github.com/ethereum/go-ethereum/cmd/evm
../go-pkg/src/github.com/ethereum/go-ethereum/cmd/evm/main.go:146: cannot use evm (type vm.VirtualMachine) as type vm.Environment in argument to core.NewExecution:
        vm.VirtualMachine does not implement vm.Environment (missing AddLog method)

[nejucomo]

I glanced at the two build pages:

• http://build.ethdev.com:8010/builders/Linux%20Go%20master%20branch/builds/-1
• http://build.ethdev.com:8010/builders/Linux%20Go%20develop%20branch/builds/-1

I don't see an installation target for evm. If I were to work on this ticket, I would first want to make automated installation tests and integrate them into this continuous integration testing.

[fjl]

We will include the evm command in CI builds in the future.

[nejucomo]

Good to hear. In the interim is there a way to create automated tests for contract code, in contrast to instantiating it in a test network?

It looks like changeset 59ef6e3 altered the core.NewExecution interface without updating evm. I'm going to experiment with modifying ./cmd/evm/main.go to mimick the changes from this changeset.

If that goes well, I might either make a pull request, or hunt for relevant unit tests and see if I can extend them to cover evm.

[nejucomo]

After this small patch go build ./cmd/evm succeeds and I can execute ./evm:

$ git diff poc8
diff --git a/cmd/evm/main.go b/cmd/evm/main.go
index c6c986a..2bdfdfa 100644
--- a/cmd/evm/main.go
+++ b/cmd/evm/main.go
@@ -141,9 +141,7 @@ func (self *VMEnv) Transfer(from, to vm.Account, amount *big.Int) error {
 }

 func (self *VMEnv) vm(addr, data []byte, gas, price, value *big.Int) *core.Execution {
-       evm := vm.New(self, vm.DebugVmTy)
-
-       return core.NewExecution(evm, addr, data, gas, price, value)
+       return core.NewExecution(self, addr, data, gas, price, value)
 }

 func (self *VMEnv) Call(caller vm.ClosureRef, addr, data []byte, gas, price, value *big.Int) ([]byte, error) {

[obscuren]

Cheers! Fixed