do not init git config on help and version cmds #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skryukov
approved these changes
Jun 9, 2021
Envek
approved these changes
Jun 10, 2021
Envek
pushed a commit
that referenced
this pull request
Jun 10, 2021
Allow to run `lefthook version` and `lefthook help` commands outside of a git repository.
|
Released in 0.7.7 |
Envek
added a commit
that referenced
this pull request
Jun 6, 2022
* origin/0-7-stable: 0.7.7: Fix arguments passing and various NPM-related fixes Fix incorrect npx command in git hook script template (#236) Update project URLs in NPM package.json (#235) Pass all arguments to downstream hooks (#231) Allows lefthook to work when node_modules is not in root folder for npx (#224) Do not initialize git config on `help` and `version` commands (#209) node: fix postinstall: process.cwd is a function and should be called
mrexox
added a commit
that referenced
this pull request
Jun 9, 2022
* master: Account for GOAMD64 suffix in directory names in NPM and GEM packages [ci skip] Include version into RPM/DEB packages on release [ci skip] 0.8.0: Skip hooks in merge/rebase, hide summary, NPM installer package Split NPM package to two: bundled and installer (#273) Include archived binaries in the releases (#189) docs: s/agrs/args (#265) [ci skip] chore(lint): Fix golangci-lint complains docs(usage): Add commitlint example in full_guide (#201) Fix unreachable conditional in hook template (#242) fix(hook.tmpl): adds cpu arch and os arch to `lefthook`'s filepath (#260) Replace deprecated `File.exists?` with `exist?` for Ruby wrapper (#263) Fix typo in docs/full_guide.md (#256) 0.7.7: Fix arguments passing and various NPM-related fixes Fix incorrect npx command in git hook script template (#236) Update project URLs in NPM package.json (#235) Pass all arguments to downstream hooks (#231) Allows lefthook to work when node_modules is not in root folder for npx (#224) Do not initialize git config on `help` and `version` commands (#209) node: fix postinstall: process.cwd is a function and should be called Signed-off-by: Valentin Kiselev <mrexox@evilmartians.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #206 and #90.
The root cause is that
gitcommands were being run for all subcommands, instead of just the ones that needed them. This PR changes when the git config is resolved so that the problematic commands are not run forversionandhelp.Additionally, it slightly improves the error message when you invoke a subcommand that does need to be run from within a git repo. Previously, it would produce a cryptic
exit status 128response.