Fix unreachable conditional in hook template #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves evilmartians#241 For devs who are using yarn as their package manager, the git hook templates are conditioned so that it will never attempt to run `yarn lefthook` from the local package it is installed in. Instead, the conditional will always end with `npx @arkweid/lefthook` which ends up fetching the package via network. In the worst case, the dev will fetch this package twice, once in the `elif` conditional and again within the `then` block, causing a significiant delay before the lefthook binary is executed. This degrades performance to an almost unusable state. To fix, give `yarn` a chance to find the lefthook binary within its local cache before moving on to `npx`.
|
Oh, all that yarn/npm/npx makes me mad. I will need to play with it a bit in a day or two. Sorry for the late reply. |
|
Thanks for the reply @Envek. I think the key point here is that the |
|
Great catch! Sorry for the late review. |
mrexox
added a commit
that referenced
this pull request
Jun 9, 2022
* master: Account for GOAMD64 suffix in directory names in NPM and GEM packages [ci skip] Include version into RPM/DEB packages on release [ci skip] 0.8.0: Skip hooks in merge/rebase, hide summary, NPM installer package Split NPM package to two: bundled and installer (#273) Include archived binaries in the releases (#189) docs: s/agrs/args (#265) [ci skip] chore(lint): Fix golangci-lint complains docs(usage): Add commitlint example in full_guide (#201) Fix unreachable conditional in hook template (#242) fix(hook.tmpl): adds cpu arch and os arch to `lefthook`'s filepath (#260) Replace deprecated `File.exists?` with `exist?` for Ruby wrapper (#263) Fix typo in docs/full_guide.md (#256) 0.7.7: Fix arguments passing and various NPM-related fixes Fix incorrect npx command in git hook script template (#236) Update project URLs in NPM package.json (#235) Pass all arguments to downstream hooks (#231) Allows lefthook to work when node_modules is not in root folder for npx (#224) Do not initialize git config on `help` and `version` commands (#209) node: fix postinstall: process.cwd is a function and should be called Signed-off-by: Valentin Kiselev <mrexox@evilmartians.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #241
For devs who are using yarn as their package manager, the git hook
templates are conditioned so that it will never attempt to run
yarn lefthookfrom the local package it is installed in. Instead, theconditional will always end with
npx @arkweid/lefthookwhich ends upfetching the package via network.
In the worst case, the dev will fetch this package twice, once in the
elifconditional and again within thethenblock, causing asignificiant delay before the lefthook binary is executed. This degrades
performance to an almost unusable state.
To fix, give
yarna chance to find the lefthook binary within itslocal cache before moving on to
npx.