Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass all arguments to downstream hooks #231

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Pass all arguments to downstream hooks #231

merged 1 commit into from
Sep 15, 2021

Conversation

pablobirukov
Copy link
Contributor

Fixes #230

@pablobirukov pablobirukov marked this pull request as ready for review September 14, 2021 19:49
skryukov
skryukov approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@skryukov skryukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @pablobirukov, thanks for the issue and the RP!

@skryukov skryukov merged commit 6c84d85 into evilmartians:master Sep 15, 2021
@Envek
Copy link
Member

Envek commented Sep 15, 2021

Thanks! We will release it a few days later.

@pablobirukov
Copy link
Contributor Author

Thanks you @skryukov @Envek.

Any estimates for release?

@PikachuEXE PikachuEXE mentioned this pull request Sep 28, 2021
Closed
Envek pushed a commit that referenced this pull request Oct 2, 2021
@pablobirukov @Envek
Pass all arguments to downstream hooks (#231)
8eda3be 
Co-authored-by: Pavel Birukov <pavel.birukov@workday.com>
@Envek
Copy link
Member

Envek commented Oct 2, 2021

Released in 0.7.7

Envek added a commit that referenced this pull request Jun 6, 2022
@Envek
Merge remote-tracking branch 'origin/0-7-stable'
eae9d36 
* origin/0-7-stable:
  0.7.7: Fix arguments passing and various NPM-related fixes
  Fix incorrect npx command in git hook script template (#236)
  Update project URLs in NPM package.json (#235)
  Pass all arguments to downstream hooks (#231)
  Allows lefthook to work when node_modules is not in root folder for npx (#224)
  Do not initialize git config on `help` and `version` commands (#209)
  node: fix postinstall: process.cwd is a function and should be called
mrexox added a commit that referenced this pull request Jun 9, 2022
@mrexox
Merge branch 'master' into refactoring
466e801 
* master:
  Account for GOAMD64 suffix in directory names in NPM and GEM packages [ci skip]
  Include version into RPM/DEB packages on release [ci skip]
  0.8.0: Skip hooks in merge/rebase, hide summary, NPM installer package
  Split NPM package to two: bundled and installer (#273)
  Include archived binaries in the releases (#189)
  docs: s/agrs/args (#265) [ci skip]
  chore(lint): Fix golangci-lint complains
  docs(usage): Add commitlint example in full_guide (#201)
  Fix unreachable conditional in hook template (#242)
  fix(hook.tmpl): adds cpu arch and os arch to `lefthook`'s filepath (#260)
  Replace deprecated `File.exists?` with `exist?` for Ruby wrapper (#263)
  Fix typo in docs/full_guide.md (#256)
  0.7.7: Fix arguments passing and various NPM-related fixes
  Fix incorrect npx command in git hook script template (#236)
  Update project URLs in NPM package.json (#235)
  Pass all arguments to downstream hooks (#231)
  Allows lefthook to work when node_modules is not in root folder for npx (#224)
  Do not initialize git config on `help` and `version` commands (#209)
  node: fix postinstall: process.cwd is a function and should be called

Signed-off-by: Valentin Kiselev <mrexox@evilmartians.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skryukov skryukov skryukov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression. Lefthook won't pass extra arguments to hooks
3 participants
@pablobirukov @Envek @skryukov