Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hook.tmpl): adds cpu arch and os arch to lefthook's filepath #260

Merged

Conversation

rmachado-studocu
Copy link
Contributor

Issue: When installing lefthook via yarn (yarn add --dev @arkweid/lefthook) we get the following tree in node_modules:

@arkweid
└── lefthook
    ├── README.md
    ├── bin
    │   ├── index.js
    │   ├── lefthook_darwin_amd64
    │   │   └── lefthook
    │   ├── lefthook_darwin_arm64
    │   │   └── lefthook
    │   ├── lefthook_linux_386
    │   │   └── lefthook
    │   ├── lefthook_linux_amd64
    │   │   └── lefthook
    │   ├── lefthook_linux_arm64
    │   │   └── lefthook
    │   ├── lefthook_windows_386
    │   │   └── lefthook.exe
    │   └── lefthook_windows_amd64
    │       └── lefthook.exe
    ├── get-exe.js
    ├── package.json
    └── postinstall.js

However the hooks expect the path: "$dir/node_modules/@arkweid/lefthook/bin/lefthook", falling back to npx when not available 😄

This commit fixes the path.

@mrexox mrexox merged commit c43d472 into evilmartians:master Mar 31, 2022
@rmachado-studocu rmachado-studocu deleted the fix-node-modules-path-on-template branch March 31, 2022 17:53
mrexox added a commit that referenced this pull request Jun 9, 2022
* master:
  Account for GOAMD64 suffix in directory names in NPM and GEM packages [ci skip]
  Include version into RPM/DEB packages on release [ci skip]
  0.8.0: Skip hooks in merge/rebase, hide summary, NPM installer package
  Split NPM package to two: bundled and installer (#273)
  Include archived binaries in the releases (#189)
  docs: s/agrs/args (#265) [ci skip]
  chore(lint): Fix golangci-lint complains
  docs(usage): Add commitlint example in full_guide (#201)
  Fix unreachable conditional in hook template (#242)
  fix(hook.tmpl): adds cpu arch and os arch to `lefthook`'s filepath (#260)
  Replace deprecated `File.exists?` with `exist?` for Ruby wrapper (#263)
  Fix typo in docs/full_guide.md (#256)
  0.7.7: Fix arguments passing and various NPM-related fixes
  Fix incorrect npx command in git hook script template (#236)
  Update project URLs in NPM package.json (#235)
  Pass all arguments to downstream hooks (#231)
  Allows lefthook to work when node_modules is not in root folder for npx (#224)
  Do not initialize git config on `help` and `version` commands (#209)
  node: fix postinstall: process.cwd is a function and should be called

Signed-off-by: Valentin Kiselev <mrexox@evilmartians.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants