Refactor vector3_t #1645 #1648

Yogesh9000 · 2024-10-05T15:45:40Z

refactored vector3_t and added a naive parse function

github-actions · 2024-10-05T15:45:53Z

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

codecov · 2024-10-05T15:53:24Z

Codecov Report

Attention: Patch coverage is 99.47971% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.93%. Comparing base (544ae70) to head (2a0eef1).
Report is 35 commits behind head on master.

Files with missing lines	Patch %	Lines
library/public/types.h	90.24%	4 Missing ⚠️
application/F3DStarter.cxx	99.60%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1648      +/-   ##
==========================================
+ Coverage   96.85%   96.93%   +0.08%     
==========================================
  Files         108      106       -2     
  Lines        7691     8789    +1098     
==========================================
+ Hits         7449     8520    +1071     
- Misses        242      269      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

library/public/types.h

library/private/options_tools.h.in

library/public/types.h

library/private/options_tools.h.in

mwestphal · 2024-10-06T07:18:11Z

library/options.json

@@ -4,6 +4,10 @@
      "type": "string",
      "default_value": "+Y"
    },
+    "up_direction2": {


please add a test in TestSDKOption.cxx

what am I supposed to here exactly. there doesn't seems to be test for other options in TestSDKOption.cxx

TestSDKOptions.cxx test all types of options, you are adding a new type of option, you should test it.

library/public/types.h

library/private/options_tools.h.in

Meakk · 2024-10-09T06:55:42Z

library/private/options_tools.h.in

+    {
+      throw options::parsing_exception("cannot parse " + str + " to a vector3_t");
+    }
+    int sign = +1;


We do have a logic based on regex working there:

f3d/vtkext/private/module/vtkF3DRenderer.cxx

Line 236 in 33771c5

if (std::regex_match(upString, match, re))

Feel free to copy it.
The advantage is it supports lowercase, omitting the + prefix, and errors out if invalid.

@Yogesh9000 please take this into account.

library/public/types.h

library/testing/PseudoUnitTest.h

library/private/options_tools.h.in

library/public/types.h

python/F3DPythonBindings.cxx

library/public/types.h

library/testing/TestSDKOptionsIO.cxx

python/F3DPythonBindings.cxx

Fix nightly CI logic in VTK action and also remove useless label in nightly CI. Chaning cache number not needed has there is no cache used for nightly.

Fixes issue f3d-app#1259 Changes: * Renamed page title from "Usage" to "Quickstart Guide". * Added short introduction. * Added "Prerequisites" section. * Added "Run F3D" section and added quickstart section from README file. * Reformatted supported file formats into table including scene and animation support. * Improved style in "Animations" and "Plugins" sections. * Added "Further Reading" section with links to other user documentation pages. * Rename the "Usage" page to "Quickstart" Co-authored-by: kli332 <kli332@wisc.edu>

- Add a interactor::command API - Add the following commands: - set - toggle - reset - unset - print - many specific commands - Add dedicated documentation - Add python bindings and tests - Fix f3d-app#1685 - Change options::toggle behavior with optional bool - Add tests - Add triggerCommand binding for java and wasm

Add an API to let libf3d users control how interactions are handled - Add `interactor::addInteractionCommand`, `interactor::removeInteractorCommand` - Use it in `interactor_impl` to declare all libf3d interactions - Use it in F3DStarter to to declare all F3D interactions - Remove `interactor::setKeyPressCallBack` - Implement the interaction command logic in OnKeyPress - Update TestSDKInteractorCallback accordingly - Add libf3d doc - Add python bindings and tests Co-authored-by: snoyer <noyer.stephane@gmail.com>

- Add a command callback "add_files" in libf3d to add files to a scene - Add an interaction command for "Drop" interaction to trigger "add_files" - Rework OnDropFiles interaction to trigger a "Drop" interaction with added "files" as arguments of the command - Add command callbacks in F3D application to "add_files" , "set_hdri", "add_files_or_set_hdri" - Add interactions commands for "Drop" -> "add_files_or_set_hdri", "CTRL+Drop" -> add_files, "SHIFT+Drop" -> "set_hdri" - Remove user drop files callback logic - Rework tests to ensure multifile drop is tested - Add a modified drops test - Rework SDK callback test to test Drop interaction - Fix: f3d-app#1159 - Add libf3d doc - Add doc for the new commands

+ add test for new types to TestSDKOptions.cxx + update vector3_t parse() function to using std::regex + add attribute F3D_EXPORT to struct type_creation_exception

mwestphal · 2024-11-16T09:35:12Z

Please rebase your branch on master instead of merging

mwestphal · 2024-11-24T06:38:05Z

here is a cleaned up rebase: https://github.com/mwestphal/f3d/tree/feature/add-a-direction-type

Yogesh9000 · 2024-11-24T06:51:01Z

here is a cleaned up rebase: https://github.com/mwestphal/f3d/tree/feature/add-a-direction-type

nice.

refactored vector3_t and added a naive parse function

06d661f

added a new option and updated struct vector3_t

1207b57

Meakk reviewed Oct 5, 2024

View reviewed changes

library/public/types.h Outdated Show resolved Hide resolved

Meakk reviewed Oct 5, 2024

View reviewed changes

library/private/options_tools.h.in Outdated Show resolved Hide resolved

vector3_t does not inherit from std::array now

e3572cf

Meakk reviewed Oct 6, 2024

View reviewed changes

library/public/types.h Outdated Show resolved Hide resolved

Meakk reviewed Oct 6, 2024

View reviewed changes

library/public/types.h Outdated Show resolved Hide resolved

mwestphal reviewed Oct 6, 2024

View reviewed changes

library/private/options_tools.h.in Show resolved Hide resolved

mwestphal reviewed Oct 6, 2024

View reviewed changes

library/private/options_tools.h.in Show resolved Hide resolved

mwestphal reviewed Oct 6, 2024

View reviewed changes

library/public/types.h Show resolved Hide resolved

mwestphal reviewed Oct 6, 2024

View reviewed changes

library/private/options_tools.h.in Outdated Show resolved Hide resolved

added tests and related functions: currently build fails

9eb7747

Yogesh9000 requested a review from mwestphal October 8, 2024 20:03

Meakk reviewed Oct 9, 2024

View reviewed changes

added tests and related functions: currently build passes

d8e4ad9

mwestphal reviewed Oct 9, 2024

View reviewed changes

library/private/options_tools.h.in Show resolved Hide resolved

mwestphal reviewed Oct 9, 2024

View reviewed changes

library/public/types.h Outdated Show resolved Hide resolved

Yogesh9000 added 2 commits October 9, 2024 21:01

updated python bindings

f1b01d4

removed unnecessary includes

efab6ad

mwestphal reviewed Oct 9, 2024

View reviewed changes

library/public/types.h Outdated Show resolved Hide resolved

mwestphal reviewed Oct 9, 2024

View reviewed changes

python/F3DPythonBindings.cxx Show resolved Hide resolved

mwestphal reviewed Oct 9, 2024

View reviewed changes

python/F3DPythonBindings.cxx Outdated Show resolved Hide resolved

Yogesh9000 added 4 commits October 9, 2024 22:28

minor fixes

eff24d8

fix formating and python binding

6761e04

fix for f3d::vector3_t iterators

b87313f

minor fix

d6d4eaa

Meakk reviewed Oct 9, 2024

View reviewed changes

mwestphal and others added 26 commits November 15, 2024 22:34

vtkext: Remove unused member

9fb9c25

Fix wasm bindings (f3d-app#1666)

02837ed

Fix wasm grid rendering (f3d-app#1667)

7a810e5

Fix compatibility with VTK and glad (f3d-app#1631)

dae1295

CI: Fix nightly workflow (f3d-app#1668)

95c2624

Disable external tests requiring a X server (f3d-app#1671)

a86bf76

CI: Fixup nightly logic (f3d-app#1673)

9a22666

Fix nightly CI logic in VTK action and also remove useless label in nightly CI. Chaning cache number not needed has there is no cache used for nightly.

Clear scene before adding model in f3d-web (f3d-app#1677)

c36fab6

Cleanup gitignore (f3d-app#1679)

4c9bf90

Move coloring info logic into a dedicated handler (f3d-app#1672)

ed0636a

Doc: Fix many small issues (f3d-app#1683)

52b0ce3

log: Cleanup incorrect eol usages (f3d-app#1684)

9f60fda

Test: Fix an issue with drop hdri tests (f3d-app#1688)

826a619

Test: Fix another interaction test (f3d-app#1689)

71345ea

VTK: Update sha (f3d-app#1691)

54a26dd

Testing: Fix an issue with SDK image testing (f3d-app#1693)

ccc0212

Interactor: Make SetViewOrbit not static (f3d-app#1695)

6484019

don't add filename to window title if there's no file (f3d-app#1699)

c76e3a6

Patch VTK CMP0174 policy in CI (f3d-app#1709)

71af4dc

Add changes commented in the pr

6330928

+ add test for new types to TestSDKOptions.cxx + update vector3_t parse() function to using std::regex + add attribute F3D_EXPORT to struct type_creation_exception

Format code

1112b54

Remove attribute F3D_EXPORT from struct type_creation_exception

2a0eef1

Yogesh9000 requested a review from mwestphal November 15, 2024 19:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor vector3_t #1645 #1648

Refactor vector3_t #1645 #1648

Yogesh9000 commented Oct 5, 2024

github-actions bot commented Oct 5, 2024

codecov bot commented Oct 5, 2024 •

edited

Loading

mwestphal Oct 6, 2024

Yogesh9000 Oct 9, 2024

mwestphal Oct 22, 2024

Meakk Oct 9, 2024

mwestphal Oct 22, 2024

mwestphal commented Nov 16, 2024

mwestphal commented Nov 24, 2024

Yogesh9000 commented Nov 24, 2024

Refactor vector3_t #1645 #1648

Are you sure you want to change the base?

Refactor vector3_t #1645 #1648

Conversation

Yogesh9000 commented Oct 5, 2024

github-actions bot commented Oct 5, 2024

codecov bot commented Oct 5, 2024 • edited Loading

Codecov Report

mwestphal Oct 6, 2024

Choose a reason for hiding this comment

Yogesh9000 Oct 9, 2024

Choose a reason for hiding this comment

mwestphal Oct 22, 2024

Choose a reason for hiding this comment

Meakk Oct 9, 2024

Choose a reason for hiding this comment

mwestphal Oct 22, 2024

Choose a reason for hiding this comment

mwestphal commented Nov 16, 2024

mwestphal commented Nov 24, 2024

Yogesh9000 commented Nov 24, 2024

codecov bot commented Oct 5, 2024 •

edited

Loading