Unable to build release version for iOS with the new architecture #33764

wood1986 · 2022-05-05T04:14:02Z

Description

I am unable to build release version for iOS with the new architecture. But I can build the debug version.

Here is build error

Undefined symbols for architecture x86_64:
  "folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::deferredReaders", referenced from:
      void folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::applyDeferredReaders<folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::WaitForever>(unsigned int&, folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::WaitForever&) in AppDelegate.o
      void folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::applyDeferredReaders<folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::WaitForever>(unsigned int&, folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::WaitForever&, unsigned int) in AppDelegate.o
  "folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::unlock()", referenced from:
      std::__1::unique_lock<folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false> >::~unique_lock() in AppDelegate.o
  "folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::~SharedMutexImpl()", referenced from:
      std::__1::__shared_ptr_emplace<facebook::react::ContextContainer const, std::__1::allocator<facebook::react::ContextContainer const> >::__on_zero_shared() in AppDelegate.o
ld: symbol(s) not found for architecture x86_64

Version

0.68.1

Output of `npx react-native info`

info Fetching system and libraries information...
System:
    OS: macOS 12.3.1
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 749.82 MB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 18.0.0 - ~/.nvm/versions/node/v18.0.0/bin/node
    Yarn: 1.22.18 - ~/.nvm/versions/node/v18.0.0/bin/yarn
    npm: 8.6.0 - ~/.nvm/versions/node/v18.0.0/bin/npm
    Watchman: 2022.03.21.00 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.11.3 - /Users/wood/.rbenv/shims/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 15.4, macOS 12.3, tvOS 15.4, watchOS 8.5
    Android SDK: Not Found
  IDEs:
    Android Studio: 2021.1 AI-211.7628.21.2111.8309675
    Xcode: 13.3.1/13E500a - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.15 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.2 => 17.0.2
    react-native: 0.68.1 => 0.68.1
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to reproduce

npx react-native init AwesomeTSProject --template react-native-template-typescript
Run RCT_NEW_ARCH_ENABLED=1 bundle exec pod install
npx react-native run-ios --configuration Release

Snack, code example, screenshot, or link to a repository

Undefined symbols for architecture x86_64:
  "folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::deferredReaders", referenced from:
      void folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::applyDeferredReaders<folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::WaitForever>(unsigned int&, folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::WaitForever&) in AppDelegate.o
      void folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::applyDeferredReaders<folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::WaitForever>(unsigned int&, folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::WaitForever&, unsigned int) in AppDelegate.o
  "folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::unlock()", referenced from:
      std::__1::unique_lock<folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false> >::~unique_lock() in AppDelegate.o
  "folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::~SharedMutexImpl()", referenced from:
      std::__1::__shared_ptr_emplace<facebook::react::ContextContainer const, std::__1::allocator<facebook::react::ContextContainer const> >::__on_zero_shared() in AppDelegate.o
ld: symbol(s) not found for architecture x86_64

The text was updated successfully, but these errors were encountered:

tj-mc · 2022-05-06T03:52:57Z

Followed steps but unable to reproduce on M1 Pro

wood1986 · 2022-05-06T06:19:52Z

I missed the step. But did you RCT_NEW_ARCH_ENABLED=1 bundle exec pod install?

Arkkeeper · 2022-05-15T14:38:44Z

This issue persists both in RN 0.68.x and 0.69 when trying to build release version or to make an archive.

I'm facing it when building for MacCatalyst on M1.

You may add these lines to the end of post_install do |installer| as a temporary solution:

rm -f Pods/Flipper-Folly/folly/SharedMutex.cpp Pods/Flipper-Folly/folly/SharedMutex.h
cp Pods/RCT-Folly/folly/SharedMutex.cpp Pods/Flipper-Folly/folly/
cp Pods/RCT-Folly/folly/SharedMutex.h Pods/Flipper-Folly/folly/

fabOnReact · 2022-05-15T15:35:01Z

#33167 https://github.com/facebook/folly/blob/main/folly/docs/Futures.md

cipolleschi · 2022-05-18T10:30:52Z

Hi @wood1986, thanks for the issue. Is the issue solved with the #33167 linked by @fabriziobertoglio1987 or is it still there?

cortinico · 2022-05-18T13:36:33Z

Hi @wood1986, thanks for the issue. Is the issue solved with the #33167 linked by @fabriziobertoglio1987 or is it still there?

@cipolleschi Nope I don't think the linked PR is relevant here. Such PR was fixing a build failure on Android, while the user is reporting an issue on iOS

fabOnReact · 2022-05-18T14:53:49Z

sorry. I don't know the solution to this issue. I just included links to relevant conversations, which would help me find a solution. What I did find out is the following:

Similar issue was experienced in the past. The symbol error was previously caused by folly depending on libc++abi
8b6d7fd

seems that https://stackoverflow.com/a/33686591/7295772 different environment use different libraries

https://gcc.gnu.org/onlinedocs/gcc-11.3.0/libstdc++/api/a00176_source.html
8b6d7fd#diff-5de3520951eb222bc3b5b734cc1003e84a53fb42220159fedc58768bda2e2cf3R75

this are the folly releases https://github.com/facebook/folly/releases. I did not find anything relevant in the new releases.

@Arkkeeper understand this issue and he tested this solution

rm -f Pods/Flipper-Folly/folly/SharedMutex.cpp Pods/Flipper-Folly/folly/SharedMutex.h
cp Pods/RCT-Folly/folly/SharedMutex.cpp Pods/Flipper-Folly/folly/
cp Pods/RCT-Folly/folly/SharedMutex.h Pods/Flipper-Folly/folly/

so seems that the issue is caused by the Flipper-Folly SharedMutex , while it works with RCT-Folly SharedMutex

this are the configs for folly futures in Flipper-Folly
https://github.com/facebook/flipper/blob/0f038218f893d86e91714cd91eed8e37d756386c/iOS/Podspecs/Flipper-Folly.podspec#L74

this are the configs for folly-futures in RCT-Folly
https://github.com/facebook/react-native/blob/main/third-party-podspecs/RCT-Folly.podspec#L106-L148

I'm not sure that this is connected to futures
The above PR fixed the issue in folly futures, https://github.com/facebook/folly/blob/b72a70a35ada45ac286eb60028c0ecf5f6725665/folly/SharedMutex.h#L554-L571 as the undefined reference was unlock_shared

This is an explanation of unlock_shared, deferredReaders seems to be an array of readers used to access data

https://github.com/facebook/folly/blob/69b6f947ea9aeb73235ccabf235a6804e0f54946/folly/SharedMutex.h#L128-L161

in this case the undefined symbol is folly::SharedMutexImpl<..>::deferredReaders

It's 22:35 here and I have to go to sleep. Sorry for my incomplete message. 🙏
I'll come back to this post in the future. Thanks.

wood1986 · 2022-05-20T07:16:36Z

I have a question for you guys.

Doing this does not make sense

rm -f Pods/Flipper-Folly/folly/SharedMutex.cpp Pods/Flipper-Folly/folly/SharedMutex.h
cp Pods/RCT-Folly/folly/SharedMutex.cpp Pods/Flipper-Folly/folly/
cp Pods/RCT-Folly/folly/SharedMutex.h Pods/Flipper-Folly/folly/

If I comment out use_flipper!() in the Podfile, I can build release successfully. Is building release without flipper the best practice?

fortmarek · 2022-05-20T07:43:16Z

Is building release without flipper the best practice?

Flipper should never be in the release app but it should be done via compilation flags instead of commenting out Podfile. Check out the template app which already does a good job of stripping out Flipper when not in DEBUG.

f-meloni · 2022-05-23T09:38:49Z

Is building release without flipper the best practice?

Flipper should never be in the release app but it should be done via compilation flags instead of commenting out Podfile. Check out the template app which already does a good job of stripping out Flipper when not in DEBUG.

👍🏻 I totally agree.
I've tried to simplify the Flipper configuration, by bringing it into use_react_native, similarly to what we do for Fabric and Hermes, and I've used the flag production that is already available there to decide if add or not Flipper.
That should solve this issue (even if is just a workaround), because if pod install is executed with production true, it won't add the Flipper Pods at all (differently to what CocoaPods does currently, that adds it, but doesn't copy it after is built), so Flipper won't be compiled and won't generate the mentioned error.
I'm not fully familiar with this, so any feedback is welcome :) #33882

…lipper dependencies logic (#33882) Summary: This PR tries to simplify the `use_flipper` logic: - makes `use_flipper` a configuration inside `use_react_native`'s options - uses the already present `production` flag in the `use_react_native`'s options to decide if add or not the Flipper pods - Simplifies the logic to download the flipper dependencies This PR also adds a workaround for #33764 ## Changelog  [iOS] [Changed] - Move `use_flipper` logic inside `use_react_native` and simplify the Flipper dependencies logic Pull Request resolved: #33882 Test Plan: Executed a pod install with and without flipper and with isProduction true Reviewed By: cipolleschi Differential Revision: D36592338 Pulled By: f-meloni fbshipit-source-id: 3c3f773151513e27e251f18865986e942a96ffd9

- 빌드 오류 수정 - facebook/react-native#33764

Issue - reactwg/react-native-releases#21 (comment) - facebook/react-native#33764 PR - facebook/react-native#33882

leotm · 2022-07-20T21:47:56Z

no longer getting the original issue with PRODUCTION= 1 pod install after updating Podfile, updated our template here too

but had Flipper downgrade to 0.125.0, just thinking the best way to config Flipper again for a custom/latest version

similar scenario will surface here
https://github.com/facebook/flipper/blob/main/react-native/ReactNativeFlipperExample/ios/Podfile
but not yet being on 0.67.4

maybe better opened as seperate/follow-up issue

wood1986 · 2022-07-24T02:25:47Z

How to specify the flipper version in 0.69.2?

wood1986 · 2022-07-24T02:26:09Z

I found it

Summary: ### Mentioned - pr[main]: #33882 - discussion: reactwg/react-native-releases#21 (reply in thread) - pr[0.69-stable]: #34098 Close: #33764 Saw the issue ago couple wks too: leotm/react-native-template-new-architecture#757 Fixed similarly: leotm/react-native-template-new-architecture#791 ## Changelog [iOS] [Changed] - Update Podfile to allow `PRODUCTION=1 pod install` [CATEGORY] [TYPE] - Message Pull Request resolved: #34234 Test Plan: Everything builds and runs as expected Reviewed By: cortinico Differential Revision: D38029117 Pulled By: cipolleschi fbshipit-source-id: bdb58200a999cb66f1043a2feb670f9037c8e463

leotm · 2022-08-03T10:40:01Z

just for anyone else landing here

react-native/scripts/cocoapods/flipper.rb

Line 105 in 463af23

def self.enabled(configurations = ["Debug"], versions = {})

nicely shows how to set custom Flipper version, we were unsure about at first

so it could be worth us expanding on the comment here or adding an example for others in the future

react-native/template/ios/Podfile

Line 20 in 463af23

# Enables Flipper.

will do pronto unless somebody (feel free) beats me to it :)

* Draft ios.yml * Fix indentation * Update ios.yml * Build app for release * Fix prod build error w Flipper, set env flag Issue - reactwg/react-native-releases#21 (comment) - facebook/react-native#33764 PR - facebook/react-native#33882 * Remove stale comment * Temporarily add `npx react-native info` * Move `npx react-native info` after `yarn` * Add release bundle step before build * Update bundle script * Update bundle script * Update RN CLI from next (8.0.0-alpha.0) to 9.0.0-alpha.5 * Remove devDep @react-native-community/cli No luck with 9.0.0-alpha.5 Should now use npm:9.0.0-alpha.4 (via npm:^9.0.0-alpha.3) * Try bundling also to ios/MyApp/main.jsbundle * Add debug before release bundle/build * Fix yarn lockfile/cache conflict res * Add normal pod install before debug * Comment debug pod install and build, working fine * Update pbxproj and xcscheme Follow-up: - facebook/react-native#34274 (comment) Also update parts in-line with current main - https://github.com/facebook/react-native/tree/main/template * Disable Metro experimentalImportSupport * Resolve Yarn lockfile From conflict res * Rename xcode.env prefix _ to . * Remove react-native-flipper * Revert "Remove react-native-flipper" This reverts commit 646dd74. * Revert "Rename xcode.env prefix _ to ." This reverts commit 8f15810. * Revert "Disable Metro experimentalImportSupport" This reverts commit 41ed14b. * Add index.js for iOS Release bundling * Add back @react-native-community/cli 9.0.0-alpha.5 * Revert "Try bundling also to ios/MyApp/main.jsbundle" This reverts commit 80e7354. * Revert "Comment debug pod install and build, working fine" This reverts commit 0ea4d01. * Update workflow comments

stefanradu1989 · 2022-11-16T12:30:49Z

Hi,
I get this error but only when I try to archive the project so I can upload to TestFlight.
My use flipper is commented in my Podfile. (# use_flipper!())
I am running RN 0.70 Xcode 14.1

I tried the solution but it does not work:

rm -f Pods/Flipper-Folly/folly/SharedMutex.cpp Pods/Flipper-Folly/folly/SharedMutex.h
cp Pods/RCT-Folly/folly/SharedMutex.cpp Pods/Flipper-Folly/folly/
cp Pods/RCT-Folly/folly/SharedMutex.h Pods/Flipper-Folly/folly/

Did anyone solve this issue?

PS: react native info
System:
OS: macOS 13.0.1
CPU: (10) arm64 Apple M1 Pro
Memory: 55.41 MB / 16.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 18.9.0 - /usr/local/bin/node
Yarn: Not Found
npm: 8.19.1 - /usr/local/bin/npm
Watchman: 2022.09.05.00 - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.11.3 - /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 22.1, iOS 16.1, macOS 13.0, tvOS 16.1, watchOS 9.1
Android SDK: Not Found
IDEs:
Android Studio: 2021.3 AI-213.7172.25.2113.9123335
Xcode: 14.1/14B47b - /usr/bin/xcodebuild
Languages:
Java: 11.0.16.1 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.1.0 => 18.1.0
react-native: 0.70.4 => 0.70.4
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found

cipolleschi · 2022-11-16T15:00:27Z

@stefanradu1989 you need to reinstall the pods with PRODUCTION=1 pod install

stefanradu1989 · 2022-11-17T09:57:12Z

@cipolleschi thank you that solved my issue

MJ0826 · 2023-04-25T16:23:22Z

Hi,
I'm not sure if this is related to the same stuff being talked about here, but I am struggling with building the app while updating from react-native version 0.67.4 to 0.69.9. Does anyone have any idea what can be the reason behind this ?

Here are the screenShots -

cipolleschi · 2023-04-28T11:01:46Z

@MJ0826 Can you walk throught what you did?

To me, it looks like you just run yarn update react-native or something similar, but you forget to run pod install to update the dependencies.

One thing that we did was to remove folly::Optional and replace it with std::optional, which seems the error that you are encountering. This should go away by reinstalling cocoapods with:

# from your root folder
cd ios
bundle install
bundle exec pod install

Secondly, this issue is about the New Architecture. Are you building for the New Arch or for the Legacy one?

wood1986 added the Needs: Triage 🔍 label May 5, 2022

react-native-bot added the Platform: iOS iOS applications. label May 5, 2022

cortinico added the Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules) label May 5, 2022

Arkkeeper mentioned this issue May 15, 2022

🐛 MacCatalyst Does not Build on RN above 64 because of RCT-Folly (1/2 Fix Included Here!) facebook/flipper#3117

Closed

cipolleschi added Impact: Errors During Build Tech: React Native Core Issue related to the Core of React Native Priority: High and removed Needs: Triage 🔍 labels May 18, 2022

cipolleschi mentioned this issue May 19, 2022

Running the app in Xcode reports an error when the new architecture mode is turned on. #33699

Closed

f-meloni mentioned this issue May 23, 2022

Move use_flipper logic inside use_react_native and simplify the Flipper dependencies logic #33882

Closed

jiggag added a commit to jiggag/react-native-starter that referenced this issue Jun 1, 2022

[deploy-ios] fix: 디버그 빌드에서만 flipper 사용하도록

4c2baa2

- 빌드 오류 수정 - facebook/react-native#33764

jiggag added a commit to jiggag/react-native-starter that referenced this issue Jun 1, 2022

[deploy-ios] fix: 디버그 빌드에서만 flipper 사용하도록

bfd0f2f

- 빌드 오류 수정 - facebook/react-native#33764

jiggag added a commit to jiggag/react-native-starter that referenced this issue Jun 1, 2022

[deploy-ios] fix: 디버그 빌드에서만 flipper 사용하도록

c19ea22

- 빌드 오류 수정 - facebook/react-native#33764

leotm added a commit to leotm/react-native-template-new-architecture that referenced this issue Jun 19, 2022

Fix prod build error w Flipper, set env flag

04a51f5

Issue - reactwg/react-native-releases#21 (comment) - facebook/react-native#33764 PR - facebook/react-native#33882

leotm mentioned this issue Jul 20, 2022

Bake prod env var into react_native_pods.rb for iOS Release build #34234

Closed

facebook-github-bot closed this as completed in 77752fc Jul 22, 2022

cortinico added the Resolution: Fixed A PR that fixes this issue has been merged. label Jul 22, 2022

leotm mentioned this issue Aug 3, 2022

[fix] backport FlipperConfiguration from main #34098

Merged

leotm mentioned this issue Aug 5, 2022

iOS CI Release on macos-12 leotm/react-native-template-new-architecture#690

Merged

21 tasks

AbhiSharma722 mentioned this issue Aug 11, 2022

Unable to build with particular scheme for iOS with the new architecture #34382

Closed

cipolleschi mentioned this issue Nov 17, 2023

[iOS] Seeing Hermes Inspecter Threads in release app #39556

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unable to build release version for iOS with the new architecture #33764

Unable to build release version for iOS with the new architecture #33764

wood1986 commented May 5, 2022 •

edited

Loading

tj-mc commented May 6, 2022

wood1986 commented May 6, 2022

Arkkeeper commented May 15, 2022

fabOnReact commented May 15, 2022 •

edited

Loading

cipolleschi commented May 18, 2022

cortinico commented May 18, 2022

fabOnReact commented May 18, 2022

wood1986 commented May 20, 2022

fortmarek commented May 20, 2022

f-meloni commented May 23, 2022

leotm commented Jul 20, 2022 •

edited

Loading

wood1986 commented Jul 24, 2022

wood1986 commented Jul 24, 2022

leotm commented Aug 3, 2022

stefanradu1989 commented Nov 16, 2022 •

edited

Loading

cipolleschi commented Nov 16, 2022

stefanradu1989 commented Nov 17, 2022

MJ0826 commented Apr 25, 2023

cipolleschi commented Apr 28, 2023

Unable to build release version for iOS with the new architecture #33764

Unable to build release version for iOS with the new architecture #33764

Comments

wood1986 commented May 5, 2022 • edited Loading

Description

Version

Output of npx react-native info

Steps to reproduce

Snack, code example, screenshot, or link to a repository

tj-mc commented May 6, 2022

wood1986 commented May 6, 2022

Arkkeeper commented May 15, 2022

fabOnReact commented May 15, 2022 • edited Loading

cipolleschi commented May 18, 2022

cortinico commented May 18, 2022

fabOnReact commented May 18, 2022

wood1986 commented May 20, 2022

fortmarek commented May 20, 2022

f-meloni commented May 23, 2022

leotm commented Jul 20, 2022 • edited Loading

wood1986 commented Jul 24, 2022

wood1986 commented Jul 24, 2022

leotm commented Aug 3, 2022

stefanradu1989 commented Nov 16, 2022 • edited Loading

cipolleschi commented Nov 16, 2022

stefanradu1989 commented Nov 17, 2022

MJ0826 commented Apr 25, 2023

cipolleschi commented Apr 28, 2023

wood1986 commented May 5, 2022 •

edited

Loading

Output of `npx react-native info`

fabOnReact commented May 15, 2022 •

edited

Loading

leotm commented Jul 20, 2022 •

edited

Loading

stefanradu1989 commented Nov 16, 2022 •

edited

Loading