Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] backport FlipperConfiguration from main #34098

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

cipolleschi
Copy link
Contributor

Summary

This PR backports FlipperConfiguration and the changes to the template Podfile so that apps created with React Native does not install Flipper pods when the dependencies are installed with PRODUCTION=1 bundle exec pod install.

When dependencies are installed using that command, Flipper won't be added as a dependency to the project and we can build the app using the Release schema.

Changelog

[iOS] [Fix] - Make sure that Flipper pods are not installed when creating a release build.

Test Plan

CircleCI passes

@cipolleschi cipolleschi requested a review from hramos as a code owner June 29, 2022 14:14
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 29, 2022
@cipolleschi cipolleschi marked this pull request as draft June 29, 2022 14:15
@react-native-bot react-native-bot added the Platform: iOS iOS applications. label Jun 29, 2022
@cipolleschi cipolleschi marked this pull request as ready for review June 29, 2022 15:19
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jun 29, 2022
Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cortinico cortinico merged commit 23accbf into 0.69-stable Jul 7, 2022
@cortinico cortinico deleted the fix/use_flipper_properly_in_release branch July 7, 2022 06:24
facebook-github-bot pushed a commit that referenced this pull request Jul 22, 2022
Summary:
### Mentioned
- pr[main]: #33882
- discussion: reactwg/react-native-releases#21 (reply in thread)
- pr[0.69-stable]: #34098

Close: #33764

Saw the issue ago couple wks too: leotm/react-native-template-new-architecture#757
Fixed similarly: leotm/react-native-template-new-architecture#791

## Changelog

[iOS] [Changed] - Update Podfile to allow `PRODUCTION=1 pod install`

[CATEGORY] [TYPE] - Message

Pull Request resolved: #34234

Test Plan: Everything builds and runs as expected

Reviewed By: cortinico

Differential Revision: D38029117

Pulled By: cipolleschi

fbshipit-source-id: bdb58200a999cb66f1043a2feb670f9037c8e463
thymikee pushed a commit to thymikee/react-native that referenced this pull request Jul 25, 2022
thymikee pushed a commit to thymikee/react-native that referenced this pull request Jul 25, 2022
kelset pushed a commit that referenced this pull request Jul 27, 2022
Summary:
### Mentioned
- pr[main]: #33882
- discussion: reactwg/react-native-releases#21 (reply in thread)
- pr[0.69-stable]: #34098

Close: #33764

Saw the issue ago couple wks too: leotm/react-native-template-new-architecture#757
Fixed similarly: leotm/react-native-template-new-architecture#791

## Changelog

[iOS] [Changed] - Update Podfile to allow `PRODUCTION=1 pod install`

[CATEGORY] [TYPE] - Message

Pull Request resolved: #34234

Test Plan: Everything builds and runs as expected

Reviewed By: cortinico

Differential Revision: D38029117

Pulled By: cipolleschi

fbshipit-source-id: bdb58200a999cb66f1043a2feb670f9037c8e463
@Bardiamist
Copy link
Contributor

Bardiamist commented Aug 3, 2022

How to specify Flipper version now? Instead of use_flipper!({ 'Flipper' => '0.154.0' })

Update: :flipper_configuration => FlipperConfiguration.enabled(["Debug"], { 'Flipper' => '0.154.0' }), right?

@leotm
Copy link
Contributor

leotm commented Aug 3, 2022

@Bardiamist exactly right ^ we had to same question in

then figured from here presumably

def self.enabled(configurations = ["Debug"], versions = {})

so it could be worth us expanding on the comment here or adding an example for others in the future

# Enables Flipper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Platform: iOS iOS applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants