-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bake prod env var into react_native_pods.rb
for iOS Release build
#34234
Conversation
Mentioned in - reactwg/react-native-releases#21 (reply in thread) - #33882 Close: #33764
PRODUCTION=1 pod install
PRODUCTION=1 pod install
in template
PRODUCTION=1 pod install
in templatePRODUCTION=1 pod install
Base commit: 143a0f7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @leotm, thanks for this PR. I think that if we want to support the PRODUCTION
env var, it is better to bake it into the react_native_pods.rb
similarly to what we did with the new_arch_enabled
flag.
Your fix works only for people who are using the template. The other will work for everyone using React Native.
What do you think?
Base commit: 143a0f7 |
This reverts commit 7b088b1.
- PR feedback: #34234 (review) - Previous Podfile change reverted
gotcha at first wasn't sure if everyone using RN meant those on diff versions or everyone internally |
i couldn't tell too much from the failing tests earlier
|
but think i've understood right, reverted prev change and baked into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, this change can't work. Could you update it with my suggestion?
Thanks figured ^ Appreciate the detailed follow-up Co-authored-by: Riccardo <riccardo.cipolleschi@gmail.com>
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
PRODUCTION=1 pod install
react_native_pods.rb
for PRODUCTION=1 pod install
react_native_pods.rb
for PRODUCTION=1 pod install
react_native_pods.rb
for iOS Release build
react_native_pods.rb
for iOS Release buildreact_native_pods.rb
for iOS Release build
test_windows is the last, seems unrelated to this PR |
Chocolatey was under maintenance this morning, nothing wrong on your side! |
This pull request was successfully merged by @leotm in 77752fc. When will my fix make it into a release? | Upcoming Releases |
Summary: ### Mentioned - pr[main]: #33882 - discussion: reactwg/react-native-releases#21 (reply in thread) - pr[0.69-stable]: #34098 Close: #33764 Saw the issue ago couple wks too: leotm/react-native-template-new-architecture#757 Fixed similarly: leotm/react-native-template-new-architecture#791 ## Changelog [iOS] [Changed] - Update Podfile to allow `PRODUCTION=1 pod install` [CATEGORY] [TYPE] - Message Pull Request resolved: #34234 Test Plan: Everything builds and runs as expected Reviewed By: cortinico Differential Revision: D38029117 Pulled By: cipolleschi fbshipit-source-id: bdb58200a999cb66f1043a2feb670f9037c8e463
Summary
Mentioned
use_flipper
logic insideuse_react_native
and simplify the Flipper dependencies logic #33882Close: #33764
Saw the issue ago couple wks too: leotm/react-native-template-new-architecture#757
Fixed similarly: leotm/react-native-template-new-architecture#791
Changelog
[iOS] [Changed] - Bake prod env var into
react_native_pods.rb
for iOS Release buildTest Plan
Everything builds and runs as expected