[Android][TextInput] Fix: mostRecentEventCount is not updated.

[jainkuniya]

Motivation

Update it's value as it changes on the JS thread, so that updated value is used (

react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java

Line 243 in f7f5dc6

if (mMostRecentEventCount < mNativeEventCount) {

) whenever setSelection(int start, int end) is called (

react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java

Line 315 in f7f5dc6

setSelection(selectionStart, selectionEnd);

).

Test Plan

On current master
Log the value of mMostRecentEventCount in the setSelection method.

react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java

Line 243 in f7f5dc6

if (mMostRecentEventCount < mNativeEventCount) {

It is always 0.

On this PR
It's values gets updated as it new value is set here (

react-native/Libraries/Components/TextInput/TextInput.js

Line 921 in f7f5dc6

mostRecentEventCount: event.nativeEvent.eventCount,

)

To try this PR working, test plan of #17894 can also be used :).

Release Notes

[ANDROID] [BUGFIX] [TextInput] - Fix: mostRecentEventCount is not updated.

[shergin]

@jainkuniya Thank you for tackling this!
Why do you think that setting the variable in public void maybeSetText(ReactTextUpdate reactTextUpdate) { is not enough? (Looks like it is, but why?) Why should we keep both update paths?

[jainkuniya]

hi @shergin

public void maybeSetText(ReactTextUpdate reactTextUpdate) { is only called once (and sometimes it is never called) and it is definitely not called as soon as event count changes so mMostRecentEventCount is not updated to recent value via this path. I am thinking to remove this path https://github.com/jainkuniya/react-native/blob/bc874a55da16770034afb3a343c948d8328d9227/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java#L362 . Should I?

[facebook-github-bot]

@jainkuniya I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

[jainkuniya]

hi @shergin, @janicduplessis, @hramos
waiting for your review :)

[hramos]

I don't usually perform reviews, that's up to the community. Ping me again once this has been reviewed.

[pilsy]

@jainkuniya @shergin @hramos
Any update on this?

[jainkuniya]

It's waiting for review :)

cc @shergin, @janicduplessis

[facebook-github-bot]

@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @jainkuniya in 60c0a60.

^{When will my fix make it into a release? | Upcoming Releases}

[theolavaux]

When will the change be included in a release?