Fix deepFreezeAndThrowOnMutationInDev error caused by objects without a prototype

[dysonpro]

This PR fixes a bug in deepFreezeAndThrowOnMutationInDev which did not take into account that objects passed to it may have been created with Object.create(null) and thus may not have a prototype. Such objects don't have the methods hasOwnProperty, __defineGetter__, or __defineSetter__ on the instance.

I ran into an unrecoverable error in React Native when passing this type of object across the bridge because deepFreezeAndThrowOnMutationInDev attempts to call object.hasOwnProperty(key), object.__defineGetter__ and object__defineSetter__ on objects passed to it. But my object instance does not have these prototype methods.

Changes:

• Modified calls to object.hasOwnProperty(key) to use Object.prototype.hasOwnProperty.call(object, key) (Per ESLint rule here)
• Modified calls to deprecated methods object.__defineGetter__ and object.__defineSetter__ to instead use Object.defineProperty to define get and set methods on the object. (Per guidance on MDN)
• Added a new test to deepFreezeAndThrowOnMutationInDev-test to verify the fix.

Test Plan

I tried to create a reproducible example to post to Snack by passing prototype-less objects to a Text component, in various ways, but they appear to be converted to plain objects before crossing the bridge and therefore they do not throw an error.

However, I was able to create a new test to reproduce the issue. I added the following test to deepFreezeAndThrowOnMutationInDev-test:

it('should not throw on object without prototype', () => {
    __DEV__ = true;
    var o = Object.create(null);
    o.key = 'Value';
    expect(() => deepFreezeAndThrowOnMutationInDev(o)).not.toThrow();
  });

The changes in this PR include this new test.

ESLint test produced 0 Errors and no change in Warning count (1014)

Related PRs

N/A
Other areas with possibly the same issue:

react-native/Libraries/vendor/core/mergeInto.js

Line 50 in c6b96c0

if (!two.hasOwnProperty(key)) {

react-native/Libraries/ReactNative/requireNativeComponent.js

Line 134 in 8dc3ba0

if (!source.hasOwnProperty(key)) {

Release Notes

[GENERAL] [BUGFIX] [Libraries/Utilities/deepFreezeAndThrowOnMutationInDev] -Fix for compatibility with objects without a prototype.

[elicwhite]

Thank you for contributing, this PR looks great. I'm especially happy for the additional test!

We don't accept PRs against release branches. I tried to point this towards master but it won't rebase cleanly. Can you retarget this to the master branch?

[elicwhite]

Ah, I see #19598. I'm going to close this in favor of that.

[matthargett]

@grabbou , can you merge this to 0.49 and publish?