Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fizz] Pass cancellation reason to abort #27536

Merged
merged 1 commit into from
Oct 18, 2023
Merged

[Fizz] Pass cancellation reason to abort #27536

merged 1 commit into from
Oct 18, 2023

Conversation

sebmarkbage
Copy link
Collaborator

This was implemented correctly for Flight but not Fizz. Hard to keep these many wrappers in sync.

@sebmarkbage sebmarkbage requested review from gnoff and acdlite October 18, 2023 01:32
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 18, 2023
@react-sizebot
Copy link

Comparing: a419575...54e394e

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 174.94 kB 174.94 kB = 54.44 kB 54.44 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.06 kB 177.06 kB = 55.12 kB 55.12 kB
facebook-www/ReactDOM-prod.classic.js = 567.28 kB 567.28 kB = 99.85 kB 99.85 kB
facebook-www/ReactDOM-prod.modern.js = 551.14 kB 551.14 kB = 96.94 kB 96.94 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 54e394e

@sebmarkbage sebmarkbage merged commit e3748a0 into facebook:main Oct 18, 2023
2 checks passed
gnoff added a commit to gnoff/next.js that referenced this pull request Oct 18, 2023
@gnoff
Successfully updated React from a41957507 to 9617d39ec.
61e1b76 
- facebook/react#27543
- facebook/react#27541
- https://github.com/facebook/react/pull/27538i
- facebook/react#27536
@gnoff gnoff mentioned this pull request Oct 18, 2023
Merged
gnoff added a commit to gnoff/next.js that referenced this pull request Oct 18, 2023
@gnoff
Successfully updated React from a41957507 to 9617d39ec.
78c3b44 
- facebook/react#27543
- facebook/react#27541
- facebook/react#27538
- facebook/react#27536
gnoff added a commit to gnoff/next.js that referenced this pull request Oct 20, 2023
@gnoff
Successfully updated React from a41957507 to d803f519e.
5b89848 
- facebook/react#27542
- facebook/react#27551
- facebook/react#27537
- facebook/react#27549
- facebook/react#27544
- facebook/react#27543
- facebook/react#27541
- facebook/react#27538
- facebook/react#27536
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Oct 20, 2023
@gnoff
Update React from a41957507 to d803f519e (#57015)
920a7e8 
## React upstream Changes

- facebook/react#27542
- facebook/react#27551
- facebook/react#27537
- facebook/react#27549
- facebook/react#27544
- facebook/react#27543
- facebook/react#27541
- facebook/react#27538
- facebook/react#27536
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@sebmarkbage @AndyPengc12
[Fizz] Pass cancellation reason to abort (facebook#27536)
d4134b2 
This was implemented correctly for Flight but not Fizz. Hard to keep
these many wrappers in sync.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@sebmarkbage
[Fizz] Pass cancellation reason to abort (#27536)
5fd6d38 
This was implemented correctly for Flight but not Fizz. Hard to keep
these many wrappers in sync.

DiffTrain build for commit e3748a0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnoff gnoff Awaiting requested review from gnoff

@acdlite acdlite Awaiting requested review from acdlite

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebmarkbage @react-sizebot @facebook-github-bot