-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[meta-only] Move ReactServerStreamConfigFB to react-server
from react-server-dom-fb
#27544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
Opened by a member of the React Core Team
labels
Oct 18, 2023
alunyov
force-pushed
the
FbStreamingConfig
branch
from
October 18, 2023 20:37
a349ae4
to
fa0e599
Compare
Comparing: 9617d39...fa0e599 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
alunyov
changed the title
Fb streaming config
[meta-only] Move ReactServerStreamConfigFB to Oct 18, 2023
react-server
from react-server-dom-fb
gnoff
approved these changes
Oct 19, 2023
gnoff
added a commit
to gnoff/next.js
that referenced
this pull request
Oct 20, 2023
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
…act-server-dom-fb` (facebook#27544) Code organization PR. It looks like the `ReactServerStreamConfigFB` is only used in the `relay-server` package. This PR moves it to `react-server` from `react-server-dom-fb` (similar to how we have config for bun, for example). This avoids cross-package imports from `react-server` to `react-server-dom-fb.`
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
…act-server-dom-fb` (#27544) Code organization PR. It looks like the `ReactServerStreamConfigFB` is only used in the `relay-server` package. This PR moves it to `react-server` from `react-server-dom-fb` (similar to how we have config for bun, for example). This avoids cross-package imports from `react-server` to `react-server-dom-fb.` DiffTrain build for commit b67ddaa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code organization PR.
It looks like the
ReactServerStreamConfigFB
is only used in therelay-server
package. This PR moves it toreact-server
fromreact-server-dom-fb
(similar to how we have config for bun, for example). This avoids cross-package imports fromreact-server
toreact-server-dom-fb.