Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Flow 0.219.0 #27542

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Upgrade to Flow 0.219.0 #27542

merged 1 commit into from
Oct 20, 2023

Conversation

kassens
Copy link
Member

@kassens kassens commented Oct 18, 2023

This upgrade made the React$Element type opaque, which is good for product code where accessing props of elements is code smell, but React needs to use that internally. I overrode the type to restore it.

This upgrade made the `React$Element` type opaque, which is good for
product code where accessing props of elements is code smell, but
React needs to use that internally. I overrode the type to restore it.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 18, 2023
@react-sizebot
Copy link

Comparing: 20c91b6...9c58cca

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 174.94 kB 174.94 kB = 54.44 kB 54.44 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.06 kB 177.06 kB = 55.12 kB 55.12 kB
facebook-www/ReactDOM-prod.classic.js = 567.28 kB 567.28 kB = 99.85 kB 99.85 kB
facebook-www/ReactDOM-prod.modern.js = 551.14 kB 551.14 kB = 96.94 kB 96.94 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 9c58cca

@kassens kassens merged commit d803f51 into facebook:main Oct 20, 2023
36 checks passed
@kassens kassens deleted the flow219 branch October 20, 2023 15:14
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
This upgrade made the `React$Element` type opaque, which is good for
product code where accessing props of elements is code smell, but React
needs to use that internally. I overrode the type to restore it.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
This upgrade made the `React$Element` type opaque, which is good for
product code where accessing props of elements is code smell, but React
needs to use that internally. I overrode the type to restore it.

DiffTrain build for commit d803f51.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants