Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flight] Expose encodeReply from ReactFlightDOMClientEdge #27551

Merged
merged 1 commit into from
Oct 20, 2023
Merged

[Flight] Expose encodeReply from ReactFlightDOMClientEdge #27551

merged 1 commit into from
Oct 20, 2023

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Oct 19, 2023

Adds encodeReply to ReactFlightDOMClientEdge in webpack and turbopack bindings

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 19, 2023
@gnoff gnoff requested a review from sebmarkbage October 19, 2023 23:58
@react-sizebot
Copy link

Comparing: f172fa7...7e5a24a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 174.94 kB 174.94 kB = 54.44 kB 54.44 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.06 kB 177.06 kB = 55.12 kB 55.12 kB
facebook-www/ReactDOM-prod.classic.js = 567.28 kB 567.28 kB = 99.85 kB 99.85 kB
facebook-www/ReactDOM-prod.modern.js = 551.14 kB 551.14 kB = 96.94 kB 96.94 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.min.js +0.59% 13.45 kB 13.53 kB +0.57% 5.05 kB 5.07 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.min.js +0.59% 13.45 kB 13.53 kB +0.57% 5.05 kB 5.07 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.min.js +0.59% 13.46 kB 13.54 kB +0.57% 5.06 kB 5.08 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.min.js +0.59% 13.46 kB 13.54 kB +0.57% 5.06 kB 5.08 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.min.js +0.54% 14.76 kB 14.84 kB +0.35% 5.41 kB 5.43 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.min.js +0.54% 14.77 kB 14.85 kB +0.37% 5.42 kB 5.44 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.34% 63.93 kB 64.15 kB +0.50% 15.73 kB 15.81 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.34% 63.93 kB 64.15 kB +0.50% 15.73 kB 15.81 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.34% 63.96 kB 64.18 kB +0.49% 15.78 kB 15.85 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.34% 63.96 kB 64.18 kB +0.49% 15.78 kB 15.85 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.32% 68.98 kB 69.20 kB +0.44% 16.76 kB 16.83 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.32% 69.01 kB 69.22 kB +0.43% 16.80 kB 16.88 kB

Generated by 🚫 dangerJS against 7e5a24a

@gnoff gnoff merged commit 3a1967b into facebook:main Oct 20, 2023
2 checks passed
@gnoff gnoff deleted the edge-encode-reply branch October 20, 2023 00:24
gnoff added a commit to gnoff/next.js that referenced this pull request Oct 20, 2023
@gnoff
Successfully updated React from a41957507 to d803f519e.
5b89848 
- facebook/react#27542
- facebook/react#27551
- facebook/react#27537
- facebook/react#27549
- facebook/react#27544
- facebook/react#27543
- facebook/react#27541
- facebook/react#27538
- facebook/react#27536
@gnoff gnoff mentioned this pull request Oct 20, 2023
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Oct 20, 2023
@gnoff
Update React from a41957507 to d803f519e (#57015)
920a7e8 
## React upstream Changes

- facebook/react#27542
- facebook/react#27551
- facebook/react#27537
- facebook/react#27549
- facebook/react#27544
- facebook/react#27543
- facebook/react#27541
- facebook/react#27538
- facebook/react#27536
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@gnoff @AndyPengc12
[Flight] Expose encodeReply from ReactFlightDOMClientEdge (facebook…
dfef6fa 
…#27551)

Adds encodeReply to ReactFlightDOMClientEdge in webpack and turbopack
bindings
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@gnoff
[Flight] Expose encodeReply from ReactFlightDOMClientEdge (#27551)
63fbd00 
Adds encodeReply to ReactFlightDOMClientEdge in webpack and turbopack
bindings

DiffTrain build for commit 3a1967b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gnoff @react-sizebot @sebmarkbage @facebook-github-bot