-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
15-next #7000
Closed
Closed
15-next #7000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't wrap drag events in IE/Edge in dev builds (cherry picked from commit 2e8f28c)
Fix the warning condition in ReactDebugTool and ReactDOMDebugTool (cherry picked from commit 7dbc95f)
(cherry picked from commit aeda846)
Update Jest’s grunt task. (cherry picked from commit 6440115)
(cherry picked from commit 9d201ab)
…top of server-generated markup. (facebook#6668) (cherry picked from commit 256753b)
This just configures flow to be checked and fixes our existing Flow typed files. Possible enhancements: Export .js.flow declarations from the build. Unclear whether this will be a supported workflow in the future or not, so let's wait on that. We should fail builds and CI on Flow errors. Ideally we should lint for Flow style guides (like no space before colon). (cherry picked from commit 771d938)
(cherry picked from commit f25a88e)
…warning (facebook#6398) * New approach for 6062 fix : Show source line number on unknown property warning * WIP: ReactDebugToolEventForwarderDevTool * Update event signature to debugID * Trigger events in ReactDOMComponent * Renamed to onMountDOMComponent; passing in element directly * Added debugID; updated simple test * Added test for multi-div JSX to ref exact line * Added test for composite component (cherry picked from commit 7cf61db)
(cherry picked from commit c9504d9)
(cherry picked from commit 9ce5421)
…go (facebook#6700) (cherry picked from commit fbe9002)
_isOwnerNecessary was unused. (cherry picked from commit e01bf78)
(cherry picked from commit 873369c)
(cherry picked from commit 82ab58e)
Best practice or whatever. (cherry picked from commit 700b714)
(cherry picked from commit 904ee9a)
(cherry picked from commit 25be6dc)
Add new primitive PropType `Symbol` (cherry picked from commit 7bf96c0)
The new flow somehow found these on my machine but nowhere else and not previously. (cherry picked from commit 069f809)
This is an outline for the new reconciler infrastructure. I created a noop renderer to have something to get started from. I split the reconciler folder into old and new, as well as shared. I put shouldUpdateReactComponent in shared as an example of a utility that can easily be shared between both. I plan on breaking out more utilities like these. (cherry picked from commit cf15788)
For clarity. I left "native event" as-is because there's a lot of it, it's not particularly ambiguous, and SimulateNative/nativeTouchData are public API in ReactTestUtils. (cherry picked from commit ba9b985)
…k#6747 (facebook#6748) (cherry picked from commit 0e889d7)
(cherry picked from commit 20bcabb)
added isProfiling() to ReactDebugTool and isRunning() to PerfTools (cherry picked from commit 5569d1d)
Fix remaining onNativeOperation => onHostOperation rename (cherry picked from commit 74cce27)
more info: https://www.w3.org/TR/xml/#NT-Name (cherry picked from commit 32c750d)
…6765) Being able to get the source for your parent components seems useful, and ReactComponentTreeDevtool is best poised to be able to do that. I'm also not sure it makes sense to have separate DOM-specific `onMountDOMComponent` and `onUpdateDOMComponent` events, so I removed them for now. Even if we want them, their timing seemed sort of arbitrary. I also made it so DOM devtools can listen to non-DOM events too. Willing to change that if people think it's ugly though. (cherry picked from commit 03f4ba2)
(cherry picked from commit 5b5bd5e)
Update to Jest 12.1.1 and Jasmine 2 (cherry picked from commit c0ecde6)
This brings createElement() fix from facebook#6855 to cloneElement(). (cherry picked from commit e822cbd)
(cherry picked from commit 21d271f)
Fix issues introduced by createElement() warning (cherry picked from commit 2d74280)
Added own property check when deleting listeners. (cherry picked from commit ca5a0da)
…ebook#6896) * Stop passing null as second argument to document.createElement() * rewrap check for props.is to make it more readable (cherry picked from commit 2636155)
[Fiber] Child Reconciler + New Coroutines Primitive (cherry picked from commit 0f4a4df)
Don't warn when style value is '0' (cherry picked from commit 5c6f9d3)
(cherry picked from commit ba3bfe3)
…lick (facebook#6881) (cherry picked from commit 38900cc)
(cherry picked from commit e62384b)
(cherry picked from commit 29ed7c6)
[Fiber] Transfer everything from Element onto the Fiber and use Tag instead of Stage (cherry picked from commit 7de2375)
[Fiber] Simple test assertions (cherry picked from commit dc5686a)
(cherry picked from commit 50982ce)
…-html (facebook#6862) * Replacing the implementation of escapeTextContentForBrowser with escape-html for performance * Addressing @spicyj's code review comment here: facebook#6862 (comment) . Pulled the code of escape-html in to react and changed the encoding of single quote to '. * Addressing code review comment facebook#6862 (comment) to make code more inlinable for v8. Thanks, @spicyj. (cherry picked from commit d6e7058)
Upgrade Flow (cherry picked from commit d3b36d5)
(cherry picked from commit c9eb572)
Firefox doesn't like these and throws. (cherry picked from commit 3c3c30a)
) Fixes facebook#6871 (cherry picked from commit 2a46103)
(cherry picked from commit d101f68)
(cherry picked from commit eb705d1)
…facebook#6990) (cherry picked from commit 7988aca)
…ebook#6982) * Workaround IE lacking innerHTML on SVG elements * Add tests for setInnerHTML * Correctly check if node has innerHTML property * Ensure tests for setInnerHTML actually tests both codepaths * Provide mock element for setInnerHTML tests * Only use SVG setInnerHTML workaround for SVG elements (cherry picked from commit 99d8524)
Pushed the 15-dev branch and working through the last couple things so closing this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ not for merge ❗
This is mostly a trial run of everything that would go into the next v15.* release using the tool I'm building (more on that later). There is no manual curation here and the tool isn't complete, but I can say confidently that this would be a minor release.
Actual plan for releasing this:
(this part is interesting - if we picked up more changes we would only change the prerelease part of the version, even if it's a semver-bump-required change)