Merge #21
Merged
Merge #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables customers to provide a custom security group for any OptionGroup that requires a VPC and SecurityGroup. fixes #9240
This reverts commit ea1072d.
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…0019) Abstract schema addition to utility functions in `private.ts` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
We were reading the wrong key when reading version source for template resources. This prevented upgrade of bootstrap as the new version was being incorrectly returned as `0`. Fixes #10016 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
We were reading the wrong key when reading version source for template resources. This prevented upgrade of bootstrap as the new version was being incorrectly returned as `0`. Fixes #10016 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
See CHANGELOG ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Enables customers to provide a custom security group for any OptionGroup that requires a VPC and SecurityGroup. fixes #9240 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Existing distributions can already been imported with the new (experimental) `Distribution` construct, but the functionality had never been backported to the stable construct. This makes it slightly more discoverable for users who are using the `CloudFrontWebDistribution` construct. Note: Opted in the README to only update the Distribution section, as it felt redundant to have the same README section twice for the two different classes. fixes #5607 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…10006) The stable `CloudFrontWebDistribution` construct automatically adds the 'edgelambda.amazonaws.com' trust policy to the Lambda execution role when adding a Lambda@Edge function to the distribution. The newer `Distribution` construct was missing this functionality. Also added an integ test to validate the Lambda@Edge functions can actually be deployed. fixes #9998 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This works around a bug in the AWS SDK for JS that only surfaced when we switched to `AWS_STS_REGIONAL_ENDPOINTS=regional`, requiring a `[default]` profile with a region for all users. The bug was that the INI-file AssumeRole provider would ignore the region in the profile, and always fall back to the region in: * The profile specified using `$AWS_PROFILE` (which we don't use). * Otherwise the region in the `[default]` profile (which a user may or may not have). Traditionally it didn't really matter whether the STS client got a region or not because it would always connect to `us-east-1` no matter what, but when we switched to `AWS_STS_REGIONAL_ENDPOINTS=regional`, it became illegal to not have a region. Fix the upstream bug by basically replicating the important parts of `SharedIniFileCredentials` of the AWS SDK in our codebase and patching the bug. Reported upstreeam as aws/aws-sdk-js#3418 Fixes #9937 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
We used to erroneously assume that IAM identities imported into the same Stack object (imported Roles specifically) would always belong to the same account as the resources in the stack, and so try to add `Invoke` permissions to the identity policy, which would silently fail. In a recent change, we started recognizing the account of the Role properly and so now we detect that we must actually ALSO add permission to the Lambda itself (resource policies). Unfortunately the Lambda IAM-to-Lambda-Permissions translator had a list of special recognized classes that did not include imported Roles, and so this would fail. Add another case where we try a more generic fallback by parsing the policy principal. This should catch most simple principals that Lambda Permissions supports. Fixes #9883. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…10037) Move `constructs` from `dependencies` to `devDependencies`. The whole point of the monocdk reorganization is that dependencies whose types are exposed in a package's public API (of which `constructs`, delivering the `Construct` class, is definitely one), should NOT be in `dependencies` but in `peerDependencies`. It was probably added to `dependencies` to make the build work. The correct place to put a dependency for build purposes is in `devDependencies.` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The `includeBody` flag enables a Lambda@Edge function to receive the body of the request or response. Enabled this flag for both the `CloudFrontWebDistribution` and `Distribution` constructs. fixes #7085 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
fix(lambda): Add Runtime support for Java 8 Corretto and Custom AL2
…roach (#9992) Implemented methods in `appsync.Schema` to easily generate query/mutation fields, or bind an existing `ObjectType` as the top level query/mutation type. Fixes: #9308 Fixes: #9310 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
There are many requests for customization of the built-in bootstrapping template. Rather than implementing each and every request, it's more productive to allow users to help themselves. This change introduces two new flags to `cdk bootstrap`: * `cdk bootstrap --show-template`: prints the current template to stdout, which people can pipe to a file. * `cdk bootstrap --template FILE`: reads the template from a file instead of using the built-in template. This can be used to arbitrarily customize the bootstrapping template for use in any organization. I know that the documentation changes in this PR are pretty light, but really a Developer Guide topic should be written on bootstrapping, which is next on my TODO list. Resolves #9256, resolves #8724, resolves #3684, resolves #1528, necessary for #9681. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Fix missing quote in python post-installed message. Before ```sh Initializing a new git repository... Please run python3 -m venv .env'! Executing Creating virtualenv... ``` After ```sh Initializing a new git repository... Please run 'python3 -m venv .env'! Executing Creating virtualenv... ``` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Fixes a small typo I discovered. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license