Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in] Pass the client id to the platform interface. #2427

Merged
merged 2 commits into from
Dec 17, 2019
Merged

[google_sign_in] Pass the client id to the platform interface. #2427

merged 2 commits into from
Dec 17, 2019

Conversation

chingjun
Copy link
Contributor

The param exists in the platform interface but there was no way to pass anything to clientId through the external interface.

@chingjun
Pass the client id to the platform interface.
6b5553a 
The param exists in the platform interface but there was no way to pass
anything to clientId through the external interface.
@chingjun chingjun requested a review from ditman December 17, 2019 00:41
ditman
ditman suggested changes Dec 17, 2019
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks OK, thanks for adding this init parameter to the plugin!

However you need to make sure to:

  • Bump the version in pubspec.yaml
  • Add a note in the CHANGELOG.md describing the change

PS: How did you create this PR? There should be a big checklist of things that you need to do in the description before it can be merged :)

@ditman
Copy link
Member

ditman commented Dec 17, 2019 •
edited by chingjun
Loading

Here's the checklist I mentioned above (please update the PR description with the markdown below this line):

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@chingjun chingjun changed the title Pass the client id to the platform interface. [google_sign_in] Pass the client id to the platform interface. Dec 17, 2019
@chingjun
Copy link
Contributor Author

Updated pubspec.yaml and CHANGELOG.md

ditman
ditman approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@ditman ditman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this! (Here's the parameter in the platform interface)

@chingjun chingjun merged commit 2a0cef3 into flutter:master Dec 17, 2019
eugenejeonme added a commit to COMANDKEYINC/flutter_plugins that referenced this pull request Dec 19, 2019
@eugenejeonme
Archive/20191219 (#4)
c6333a6 
* [google_sign_in] Pass the client id to the platform interface. (flutter#2427)

The param exists in the platform interface but there was no way to pass
anything to clientId through the external interface.

* [in_app_purchase]Change a comment. (flutter#2329)

* re-enable stable CI (flutter#2402)

* [flutter_webview] Raise min Flutter SDK to stable (flutter#2425)

v2 embedding apps no longer need to special case their Flutter SDK
requirement like they have since v0.3.15+3.

* [battery] cleanup for Android embedding post 1.12 (flutter#2400)

* [google_sign_in] Expose network error (flutter#2398)
sanekyy pushed a commit to sanekyy/plugins that referenced this pull request Dec 21, 2019
@chingjun @sanekyy
[google_sign_in] Pass the client id to the platform interface. (flutt…
0f392ac 
…er#2427)

The param exists in the platform interface but there was no way to pass
anything to clientId through the external interface.
hjc22 pushed a commit to hjc22/plugins that referenced this pull request Jan 8, 2020
Merge remote-tracking branch 'flutterPlugin/master' into cash-video-c…
df1df41 
…acheing-01-08

* flutterPlugin/master: (30 commits)
  Update Gradle version (flutter#2448)
  [image_picker] support android V2 embedding (flutter#2430)
  [webview_flutter] Setup XCTests (flutter#2445)
  [video_player] Fixes video initialization future stall. (flutter#2134)
  [ci] Upgrade to Xcode 11.3 (flutter#2435)
  [In_app_purchases] migrate to Play Billing Library 2.0. (flutter#2287)
  Migrate away from deprecated `BinaryMessages` (flutter#2444)
  [google_sign_in]Update google_sign_in_example name in pubspec.yaml (flutter#2335)
  [ios_platform_images] Removed android support from the pubspec. (flutter#2432)
  [google_sign_in] Expose network error (flutter#2398)
  [battery] cleanup for Android embedding post 1.12 (flutter#2400)
  [flutter_webview] Raise min Flutter SDK to stable (flutter#2425)
  re-enable stable CI (flutter#2402)
  [in_app_purchase]Change a comment. (flutter#2329)
  [google_sign_in] Pass the client id to the platform interface. (flutter#2427)
  [ios_platform_images] Made ios_platform_images set the correct image scale. (flutter#2414)
  [url_launcher_platform_interface] use non static token for platform interface (flutter#2418)
  [plugin_platform_interface] Don't use const Object as a token (flutter#2417)
  Update endorsed macos plugins readme and update others (flutter#2407)
  [webview_flutter] add gesture navigation for iOS (flutter#2339)
  ...

# Conflicts:
#	packages/video_player/video_player/CHANGELOG.md
#	packages/video_player/video_player/pubspec.yaml
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
@chingjun
[google_sign_in] Pass the client id to the platform interface. (flutt…
8c34982 
…er#2427)

The param exists in the platform interface but there was no way to pass
anything to clientId through the external interface.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ditman ditman ditman approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chingjun @ditman @googlebot