Added support for Ignition #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
friendly ping @marcbone |
|
Hey @ahcorde, thanks for your contribution. We didnt forgot it, but are sadly super busy with other stuff right now. We did not take a detailed look into it, but our main concern is that you are using the position interface that we cannot implement for the real robot at the moment. So you cannot write a controller that works with the real robot and in the simulator. On the other hand, using the position interface allows at least to run moveit in simulation. Those are our initial thoughts on it without testing it. |
Maverobot
pushed a commit
to Maverobot/franka_ros2
that referenced
this pull request
Feb 17, 2023
Fixed naming issues with controller spawner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I have been playing around with panda and ign_ros_control. I made this changes to make it work.
Signed-off-by: ahcorde ahcorde@gmail.com