Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add employee number to client user bootinfo #38477

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

casesolved-co-uk
Copy link
Contributor

@casesolved-co-uk casesolved-co-uk commented Nov 30, 2023

Adding the employee name to bootinfo is useful for building HR-related personal workspaces

Screen Shot 2023-11-30 at 17 57 10

no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #38477 (9812927) into develop (ba10f7d) will decrease coverage by 0.02%.
Report is 63 commits behind head on develop.
The diff coverage is 0.00%.

❗ Current head 9812927 differs from pull request most recent head efbd42a. Consider uploading reports for the commit efbd42a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38477      +/-   ##
===========================================
- Coverage    60.14%   60.12%   -0.02%     
===========================================
  Files          760      760              
  Lines        69456    69462       +6     
===========================================
- Hits         41771    41767       -4     
- Misses       27685    27695      +10     
Files Coverage Δ
erpnext/hooks.py 100.00% <ø> (ø)
erpnext/startup/boot.py 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@ankush ankush merged commit 525f656 into frappe:develop Dec 6, 2023
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
ankush pushed a commit that referenced this pull request Dec 6, 2023
…38603)

feat: add employee number to client user bootinfo (#38477)

(cherry picked from commit 525f656)

Co-authored-by: Richard Case <110036763+casesolved-co-uk@users.noreply.github.com>
ankush pushed a commit that referenced this pull request Dec 6, 2023
…38602)

feat: add employee number to client user bootinfo (#38477)

(cherry picked from commit 525f656)

Co-authored-by: Richard Case <110036763+casesolved-co-uk@users.noreply.github.com>
frappe-pr-bot pushed a commit that referenced this pull request Dec 12, 2023
# [15.6.0](v15.5.0...v15.6.0) (2023-12-12)

### Bug Fixes

* `split_invoices_based_on_payment_terms` (backport [#37859](#37859)) ([#38488](#38488)) ([4b76cc4](4b76cc4))
* 1st row depr. sch. value of asset put to less than 180 days acc. to I.T. S. 32 (backport [#38696](#38696)) ([#38703](#38703)) ([2bd9671](2bd9671))
* auto delete draft serial and batch bundle (backport [#38637](#38637)) ([#38654](#38654)) ([b0675f6](b0675f6))
* close PO on SCO close (backport [#38667](#38667)) ([#38681](#38681)) ([4055543](4055543))
* format only if searched text contain link value text ([d79e6e3](d79e6e3))
* get customers for leaderboard ([9d5c79d](9d5c79d))
* get items for leaderboard ([7cb38a8](7cb38a8))
* get sales partner for leaderboard ([3845d42](3845d42))
* get sales person for leaderboard ([2fcfebe](2fcfebe))
* get suppliers for leaderboard ([e205772](e205772))
* ignore non-existing regional customizations (backport [#38621](#38621)) ([#38624](#38624)) ([c70e6f2](c70e6f2))
* limit end date to current date ([dbdb971](dbdb971))
* negative batch issue (backport [#38688](#38688)) ([#38694](#38694)) ([a75081b](a75081b))
* not able to make serial and batch using csv import (backport [#38659](#38659)) ([#38662](#38662)) ([dd07eca](dd07eca))
* only highest eligible coupon applied ([#38416](#38416)) ([aa66ee6](aa66ee6))
* serial and batch bundle permission (backport [#38618](#38618)) ([#38619](#38619)) ([ce2bd15](ce2bd15))
* serial no filter in the Serial No Ledger report (backport [#38669](#38669)) ([#38682](#38682)) ([d188c8e](d188c8e))
* Shipping Address Link Showing in Buying (backport [#38634](#38634)) ([#38646](#38646)) ([4150ed9](4150ed9))
* show stock qty in popup (backport [#38698](#38698)) ([#38699](#38699)) ([6e2cde4](6e2cde4))
* typeerror on new sites ([#38692](#38692)) ([9239e73](9239e73))
* typo in unittest ([#38673](#38673)) ([14ee13c](14ee13c))
* **ux:** don't update qty blindly (backport [#38608](#38608)) ([#38639](#38639)) ([0b2e2a2](0b2e2a2))

### Features

* add employee number to client user bootinfo (backport [#38477](#38477)) ([#38603](#38603)) ([c7dbcbc](c7dbcbc))
frappe-pr-bot pushed a commit that referenced this pull request Dec 12, 2023
# [14.54.0](v14.53.0...v14.54.0) (2023-12-12)

### Bug Fixes

* 1st row depr. sch. value of asset put to less than 180 days acc. to I.T. S. 32 ([#38697](#38697)) ([753a1b5](753a1b5))
* calc monthly_repayment_amount correctly in regenerate_repayment_schedule ([#38636](#38636)) ([008400d](008400d))
* format only if searched text contain link value text ([b28deaa](b28deaa))
* limit end date to current date ([cbe15e1](cbe15e1))
* typo in unittest ([#38673](#38673)) ([c87a3c7](c87a3c7))
* **ux:** don't update qty blindly (backport [#38608](#38608)) ([#38638](#38638)) ([29cd474](29cd474))

### Features

* add employee number to client user bootinfo (backport [#38477](#38477)) ([#38602](#38602)) ([c2a137f](c2a137f))

### Reverts

* Revert "refactor: bank transaction (backport #38182)" (#38653) ([7813efa](7813efa)), closes [#38182](#38182) [#38653](#38653) [#38182](#38182)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants