Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typeerror on new sites #38692

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix: typeerror on new sites #38692

merged 1 commit into from
Dec 12, 2023

Conversation

ruthra-kumar
Copy link
Member 

TypeError: Cannot read properties of undefined (reading 'default_currency')
  at Object.get_currency(../../../../../apps/erpnext/erpnext/public/js/utils.js:11:45)
  at frappe.ui.form.Controller.get_company_currency(../../../../../apps/erpnext/erpnext/public/js/controllers/transaction.js:952:18)
  at frappe.ui.form.Controller.validate_conversion_rate(../../../../../apps/erpnext/erpnext/public/js/controllers/taxes_and_totals.js:115:31)
  at frappe.ui.form.Controller._calculate_taxes_and_totals(../../../../../apps/erpnext/erpnext/public/js/controllers/taxes_and_totals.js:100:8)
  at frappe.ui.form.Controller.calculate_taxes_and_totals(../../../../../apps/erpnext/erpnext/public/js/controllers/taxes_and_totals.js:39:8)
  at _function(../../../../../apps/erpnext/erpnext/public/js/controllers/transaction.js:741:8)
  at runner(../../../../../apps/frappe/frappe/public/js/frappe/form/script_manager.js:106:31)
  at ? (../../../../../apps/frappe/frappe/public/js/frappe/form/script_manager.js:136:22)

@ankush ankush merged commit fa2d33c into frappe:develop Dec 12, 2023
6 checks passed
mergify bot pushed a commit that referenced this pull request Dec 12, 2023
@ruthra-kumar @mergify
fix: typeerror on new sites (#38692)
9239e73 
(cherry picked from commit fa2d33c)
@mergify mergify bot mentioned this pull request Dec 12, 2023
Merged
ruthra-kumar added a commit that referenced this pull request Dec 12, 2023
@ruthra-kumar
Merge pull request #38693 from frappe/mergify/bp/version-15-hotfix/pr…
b68e1f6 
…-38692

fix: typeerror on new sites (backport #38692)
frappe-pr-bot pushed a commit that referenced this pull request Dec 12, 2023
@frappe-bot
chore(release): Bumped to Version 15.6.0
86b276a 
# [15.6.0](v15.5.0...v15.6.0) (2023-12-12)

### Bug Fixes

* `split_invoices_based_on_payment_terms` (backport [#37859](#37859)) ([#38488](#38488)) ([4b76cc4](4b76cc4))
* 1st row depr. sch. value of asset put to less than 180 days acc. to I.T. S. 32 (backport [#38696](#38696)) ([#38703](#38703)) ([2bd9671](2bd9671))
* auto delete draft serial and batch bundle (backport [#38637](#38637)) ([#38654](#38654)) ([b0675f6](b0675f6))
* close PO on SCO close (backport [#38667](#38667)) ([#38681](#38681)) ([4055543](4055543))
* format only if searched text contain link value text ([d79e6e3](d79e6e3))
* get customers for leaderboard ([9d5c79d](9d5c79d))
* get items for leaderboard ([7cb38a8](7cb38a8))
* get sales partner for leaderboard ([3845d42](3845d42))
* get sales person for leaderboard ([2fcfebe](2fcfebe))
* get suppliers for leaderboard ([e205772](e205772))
* ignore non-existing regional customizations (backport [#38621](#38621)) ([#38624](#38624)) ([c70e6f2](c70e6f2))
* limit end date to current date ([dbdb971](dbdb971))
* negative batch issue (backport [#38688](#38688)) ([#38694](#38694)) ([a75081b](a75081b))
* not able to make serial and batch using csv import (backport [#38659](#38659)) ([#38662](#38662)) ([dd07eca](dd07eca))
* only highest eligible coupon applied ([#38416](#38416)) ([aa66ee6](aa66ee6))
* serial and batch bundle permission (backport [#38618](#38618)) ([#38619](#38619)) ([ce2bd15](ce2bd15))
* serial no filter in the Serial No Ledger report (backport [#38669](#38669)) ([#38682](#38682)) ([d188c8e](d188c8e))
* Shipping Address Link Showing in Buying (backport [#38634](#38634)) ([#38646](#38646)) ([4150ed9](4150ed9))
* show stock qty in popup (backport [#38698](#38698)) ([#38699](#38699)) ([6e2cde4](6e2cde4))
* typeerror on new sites ([#38692](#38692)) ([9239e73](9239e73))
* typo in unittest ([#38673](#38673)) ([14ee13c](14ee13c))
* **ux:** don't update qty blindly (backport [#38608](#38608)) ([#38639](#38639)) ([0b2e2a2](0b2e2a2))

### Features

* add employee number to client user bootinfo (backport [#38477](#38477)) ([#38603](#38603)) ([c7dbcbc](c7dbcbc))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport version-15-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruthra-kumar @ankush