Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 1st row depr. sch. value of asset put to less than 180 days acc. to I.T. S. 32 #38696

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix: 1st row depr. sch. value of asset put to less than 180 days acc. to I.T. S. 32 #38696

merged 1 commit into from
Dec 12, 2023

Conversation

anandbaburajan
Copy link
Contributor

@anandbaburajan anandbaburajan commented Dec 12, 2023

Fixing the incorrect value of the first row of the depreciation schedule if an asset is put to use for less than 180 days as per Income Tax – Section 32 -- the pro rata amount shouldn't be calculated for the first row.

Depends on resilient-tech/india-compliance#1392.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #38696 (7d9e9df) into develop (acb6e8e) will decrease coverage by 0.01%.
Report is 35 commits behind head on develop.
The diff coverage is 38.59%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38696      +/-   ##
===========================================
- Coverage    60.07%   60.07%   -0.01%     
===========================================
  Files          759      759              
  Lines        69531    69540       +9     
===========================================
+ Hits         41774    41775       +1     
- Misses       27757    27765       +8     
Files Coverage Δ
erpnext/__init__.py 70.00% <100.00%> (ø)
erpnext/accounts/deferred_revenue.py 77.31% <100.00%> (ø)
...ange_rate_revaluation/exchange_rate_revaluation.py 88.21% <100.00%> (ø)
...xt/accounts/doctype/journal_entry/journal_entry.py 65.63% <100.00%> (ø)
...xt/accounts/doctype/payment_entry/payment_entry.py 84.14% <100.00%> (ø)
...next/accounts/doctype/pricing_rule/pricing_rule.py 62.09% <100.00%> (ø)
...ounts/doctype/purchase_invoice/purchase_invoice.py 70.12% <100.00%> (ø)
...xt/accounts/doctype/sales_invoice/sales_invoice.py 73.92% <100.00%> (-0.08%) ⬇️
...xt/accounts/doctype/shipping_rule/shipping_rule.py 75.65% <100.00%> (ø)
...next/accounts/doctype/subscription/subscription.py 77.71% <100.00%> (ø)
... and 48 more

... and 3 files with indirect coverage changes

@anandbaburajan anandbaburajan merged commit e7984b3 into frappe:develop Dec 12, 2023
15 checks passed
mergify bot pushed a commit that referenced this pull request Dec 12, 2023
… to I.T. S. 32 (#38696)

fix: 1st row value of asset put to less than 180 days acc. to IT S. 32
(cherry picked from commit e7984b3)
anandbaburajan added a commit that referenced this pull request Dec 12, 2023
… to I.T. S. 32 (backport #38696) (#38703)

fix: 1st row depr. sch. value of asset put to less than 180 days acc. to I.T. S. 32 (#38696)

fix: 1st row value of asset put to less than 180 days acc. to IT S. 32
(cherry picked from commit e7984b3)

Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Dec 12, 2023
# [15.6.0](v15.5.0...v15.6.0) (2023-12-12)

### Bug Fixes

* `split_invoices_based_on_payment_terms` (backport [#37859](#37859)) ([#38488](#38488)) ([4b76cc4](4b76cc4))
* 1st row depr. sch. value of asset put to less than 180 days acc. to I.T. S. 32 (backport [#38696](#38696)) ([#38703](#38703)) ([2bd9671](2bd9671))
* auto delete draft serial and batch bundle (backport [#38637](#38637)) ([#38654](#38654)) ([b0675f6](b0675f6))
* close PO on SCO close (backport [#38667](#38667)) ([#38681](#38681)) ([4055543](4055543))
* format only if searched text contain link value text ([d79e6e3](d79e6e3))
* get customers for leaderboard ([9d5c79d](9d5c79d))
* get items for leaderboard ([7cb38a8](7cb38a8))
* get sales partner for leaderboard ([3845d42](3845d42))
* get sales person for leaderboard ([2fcfebe](2fcfebe))
* get suppliers for leaderboard ([e205772](e205772))
* ignore non-existing regional customizations (backport [#38621](#38621)) ([#38624](#38624)) ([c70e6f2](c70e6f2))
* limit end date to current date ([dbdb971](dbdb971))
* negative batch issue (backport [#38688](#38688)) ([#38694](#38694)) ([a75081b](a75081b))
* not able to make serial and batch using csv import (backport [#38659](#38659)) ([#38662](#38662)) ([dd07eca](dd07eca))
* only highest eligible coupon applied ([#38416](#38416)) ([aa66ee6](aa66ee6))
* serial and batch bundle permission (backport [#38618](#38618)) ([#38619](#38619)) ([ce2bd15](ce2bd15))
* serial no filter in the Serial No Ledger report (backport [#38669](#38669)) ([#38682](#38682)) ([d188c8e](d188c8e))
* Shipping Address Link Showing in Buying (backport [#38634](#38634)) ([#38646](#38646)) ([4150ed9](4150ed9))
* show stock qty in popup (backport [#38698](#38698)) ([#38699](#38699)) ([6e2cde4](6e2cde4))
* typeerror on new sites ([#38692](#38692)) ([9239e73](9239e73))
* typo in unittest ([#38673](#38673)) ([14ee13c](14ee13c))
* **ux:** don't update qty blindly (backport [#38608](#38608)) ([#38639](#38639)) ([0b2e2a2](0b2e2a2))

### Features

* add employee number to client user bootinfo (backport [#38477](#38477)) ([#38603](#38603)) ([c7dbcbc](c7dbcbc))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant