Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log physics version #1769

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Conversation

gz65555
Copy link
Collaborator

@gz65555 gz65555 commented Sep 18, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@gz65555 gz65555 requested a review from GuoLei1990 September 18, 2023 11:43
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 70.76% and project coverage change: -0.03% ⚠️

Comparison is base (fcc37b5) 65.04% compared to head (52ea8d3) 65.01%.
Report is 9 commits behind head on main.

❗ Current head 52ea8d3 differs from pull request most recent head 30c0284. Consider uploading reports for the commit 30c0284 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1769      +/-   ##
==========================================
- Coverage   65.04%   65.01%   -0.03%     
==========================================
  Files         470      473       +3     
  Lines       23582    23610      +28     
  Branches     3352     3356       +4     
==========================================
+ Hits        15339    15351      +12     
- Misses       7041     7053      +12     
- Partials     1202     1206       +4     
Files Changed Coverage Δ
...kages/core/src/RenderPipeline/SpriteMaskBatcher.ts 13.55% <0.00%> (ø)
...r/BlendShapeWeightsAnimationCurveOwnerAssembler.ts 45.45% <0.00%> (-17.05%) ⬇️
packages/core/src/lighting/Light.ts 92.30% <ø> (ø)
...ages/loader/src/gltf/parser/GLTFAnimationParser.ts 60.86% <0.00%> (ø)
packages/core/src/Script.ts 85.93% <33.33%> (-2.78%) ⬇️
packages/core/src/physics/CharacterController.ts 54.83% <40.00%> (-2.57%) ⬇️
packages/core/src/physics/Collider.ts 89.09% <92.30%> (-0.28%) ⬇️
packages/core/src/Camera.ts 90.66% <100.00%> (ø)
packages/core/src/Component.ts 94.73% <100.00%> (ø)
packages/core/src/RenderPipeline/SpriteBatcher.ts 83.52% <100.00%> (ø)
... and 6 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 added the ignore for release ignore for release label Sep 18, 2023
@GuoLei1990 GuoLei1990 merged commit 1027470 into galacean:main Sep 18, 2023
GuoLei1990 added a commit to HypnosNova/engine-1 that referenced this pull request Sep 19, 2023
* main: (23 commits)
  Support entity reference (galacean#1417)
  feat: log physics version (galacean#1769)
  Fix Script destroy bug (galacean#1770)
  Fix collider shape bug (galacean#1768)
  fix: physics unit test timeout (galacean#1766)
  Fix `viewportPointToRay` triggers precision issues when the depth value is 1 (galacean#1767)
  fix: project loader not exported (galacean#1758)
  "v1.1.0-beta.4"
  Opt SpriteBatch code (galacean#1760)
  Fix light shader data abnormal when multiple scenes are activated (galacean#1759)
  Fix BlendShape anim compatible with multiple SkinMeshRenderer in on… (galacean#1756)
  refactor: clear code and opt memory (galacean#1757)
  test: add physx unit timeout (galacean#1755)
  "v1.1.0-beta.3"
  Fix charactor controller error (galacean#1754)
  test: fix unit test timeout
  "v1.1.0-beta.2"
  Fix clone error (galacean#1753)
  Support main thread ktx2 (galacean#1745)
  "v1.1.0-beta.1"
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release ignore for release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants