Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 2.1 ⬆️ #54

Merged
merged 30 commits into from
May 8, 2020
Merged

Bump to 2.1 ⬆️ #54

merged 30 commits into from
May 8, 2020

Conversation

chapulina
Copy link
Contributor

  • Merge from ign-physics1
  • Update changelog
  • Bump version

mxgrey and others added 26 commits January 14, 2019 12:30
Bump to 1.7.0

Approved-by: Steve Peters <scpeters@osrfoundation.org>
Add PlaneShape features + test

Approved-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
* [ign-physics1] Update BitBucket links

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Fix collision issue with detachable joints

The issue occurs if a model is spawned and is attached to a parent model
without a call to `step()` in between. This should be fixed in DART, but
in the meantime, we can just call `incrementVersion` after `moveTo` is
called on a DART BodyNode.
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested review from azeey and scpeters May 7, 2020 15:05
@chapulina chapulina requested a review from mxgrey as a code owner May 7, 2020 15:05
@github-actions github-actions bot added 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels May 7, 2020
@azeey
Copy link
Contributor

azeey commented May 7, 2020

The Ubuntu CI is not finding sdformat9 because sdformat8 is installed.

Changelog.md Show resolved Hide resolved
@scpeters
Copy link
Member

scpeters commented May 7, 2020

The Ubuntu CI is not finding sdformat9 because sdformat8 is installed.

gazebo-tooling/release-tools#194

scpeters and others added 4 commits May 7, 2020 09:10
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
* dartsim: add prefix 'modelName/' to child BodyNode before calling moveTo in Attach*Joint, then try to restore BodyNode to its original skeleton if / is detected in child BodyNode's name during DetachJoint
* Store the original name of links for use in moving BodyNodes between
skeletons
* Failing test demonstrating problem when a model and link have the same
name
* Handle the case when model and link names are the same
* Update changelog

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>

Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #54 into ign-physics2 will increase coverage by 0.62%.
The diff coverage is 74.64%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-physics2      #54      +/-   ##
================================================
+ Coverage         82.17%   82.80%   +0.62%     
================================================
  Files                87       75      -12     
  Lines              2783     2425     -358     
================================================
- Hits               2287     2008     -279     
+ Misses              496      417      -79     
Impacted Files Coverage Δ
dartsim/src/ShapeFeatures.cc 38.05% <33.33%> (-1.08%) ⬇️
dartsim/src/JointFeatures.cc 69.00% <90.24%> (+8.55%) ⬆️
dartsim/src/Base.hh 98.97% <100.00%> (+0.03%) ⬆️
dartsim/src/EntityManagementFeatures.cc 59.89% <100.00%> (-8.05%) ⬇️
include/ignition/physics/PlaneShape.hh 100.00% <100.00%> (ø)
include/ignition/physics/detail/PlaneShape.hh 100.00% <100.00%> (ø)
src/CompositeData.cc 100.00% <0.00%> (ø)
dartsim/src/plugin.cc 100.00% <0.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e96306...975aad3. Read the comment docs.

@chapulina chapulina merged commit 53fae7c into ign-physics2 May 8, 2020
@chapulina chapulina deleted the bump_2.1 branch May 8, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants