Add dismiss review feature #12674

a1012112796 · 2020-09-01T15:48:26Z

It's same with github

refs:
https://github.blog/2016-10-12-dismissing-reviews-on-pull-requests/
https://developer.github.com/v3/pulls/reviews/#dismiss-a-review-for-a-pull-request

It's same with github refs: https://github.blog/2016-10-12-dismissing-reviews-on-pull-requests/ https://developer.github.com/v3/pulls/reviews/#dismiss-a-review-for-a-pull-request Signed-off-by: a1012112796 <1012112796@qq.com>

codecov-commenter · 2020-09-01T17:00:47Z

Codecov Report

Merging #12674 into master will increase coverage by 0.03%.
The diff coverage is 31.95%.

@@            Coverage Diff             @@
##           master   #12674      +/-   ##
==========================================
+ Coverage   43.29%   43.32%   +0.03%     
==========================================
  Files         646      646              
  Lines       71592    71710     +118     
==========================================
+ Hits        30993    31069      +76     
- Misses      35583    35599      +16     
- Partials     5016     5042      +26

Impacted Files	Coverage Δ
models/branches.go	`42.70% <0.00%> (-0.31%)`	⬇️
models/issue_comment.go	`53.75% <ø> (ø)`
models/migrations/migrations.go	`4.66% <ø> (ø)`
models/migrations/v148.go	`0.00% <0.00%> (ø)`
models/pull.go	`55.17% <0.00%> (ø)`
modules/auth/repo_form.go	`42.34% <ø> (ø)`
modules/graceful/server.go	`47.00% <0.00%> (-0.41%)`	⬇️
modules/highlight/highlight.go	`24.69% <0.00%> (ø)`
modules/migrations/gitlab.go	`1.04% <0.00%> (-0.10%)`	⬇️
modules/session/virtual.go	`60.20% <0.00%> (ø)`
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fa7a4b...ab6c402. Read the comment docs.

models/action.go

options/locale/locale_en-US.ini

routers/api/v1/api.go

routers/api/v1/repo/pull_review.go

routers/routes/routes.go

templates/repo/issue/view_content/pull.tmpl

bagasme · 2020-09-03T11:15:22Z

In my case clicking dismiss review button (green X) doesn't dismiss requested review, but instead going back to top of PR page.

a1012112796 · 2020-09-03T11:59:43Z

In my case clicking dismiss review button (green X) doesn't dismiss requested review, but instead going back to top of PR page.

Okay, I will have more checks. Please wait. I'm not good at UI. Thanks.

bagasme · 2020-09-07T10:55:49Z

@a1012112796 dismiss worked as expected

bagasme

Ack: feature worked as expected

stale · 2020-11-07T06:11:53Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

lafriks · 2020-11-07T12:50:58Z

Please resolve conflicts

lafriks · 2020-11-18T10:18:59Z

There is still conflict

codecov-io · 2020-11-20T14:54:51Z

Codecov Report

Merging #12674 (786f823) into master (45ca2e4) will decrease coverage by 0.00%.
The diff coverage is 53.22%.

@@            Coverage Diff             @@
##           master   #12674      +/-   ##
==========================================
- Coverage   42.24%   42.24%   -0.01%     
==========================================
  Files         697      698       +1     
  Lines       76585    76702     +117     
==========================================
+ Hits        32355    32400      +45     
- Misses      38912    38965      +53     
- Partials     5318     5337      +19

Impacted Files	Coverage Δ
models/branches.go	`41.61% <0.00%> (-0.29%)`	⬇️
models/issue_comment.go	`52.71% <ø> (ø)`
models/migrations/migrations.go	`2.44% <ø> (ø)`
models/migrations/v160.go	`0.00% <0.00%> (ø)`
models/pull.go	`55.17% <0.00%> (ø)`
modules/auth/repo_form.go	`41.59% <ø> (ø)`
modules/templates/helper.go	`46.89% <0.00%> (-0.19%)`	⬇️
routers/repo/pull_review.go	`0.00% <0.00%> (ø)`
routers/api/v1/repo/pull_review.go	`42.95% <31.03%> (-1.26%)`	⬇️
modules/notification/mail/mail.go	`38.88% <33.33%> (-0.20%)`	⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de1e4b2...786f823. Read the comment docs.

models/review.go

lafriks · 2021-01-24T17:22:19Z

Please resolve conflicts

* master: (358 commits) [skip ci] Updated translations via Crowdin Use caddy's certmagic library for extensible/robust ACME handling (go-gitea#14177) Redirect on changed user and org name (go-gitea#11649) chore: bump minio to RELEASE.2021-01-16T02-19-44Z (go-gitea#14445) [skip ci] Updated translations via Crowdin CI: skip build steps for cron update works (go-gitea#14443) [skip ci] Updated licenses and gitignores [skip ci] Updated translations via Crowdin just overload to not get it by mistake again ... (go-gitea#14440) [skip ci] Updated translations via Crowdin Add link to packages in openSUSE build service (go-gitea#14439) Improve Description in new/ edit Project template (go-gitea#14429) Don't show "Reference in new issue" when issues unit is globally disabled (go-gitea#14437) CI: Update license & gitignore by cron (go-gitea#14419) Fix close/reopen with comment (go-gitea#14436) Add german translation guidelines (go-gitea#14283) [skip ci] Updated translations via Crowdin Fix lfs preview bug (go-gitea#14428) [skip ci] Updated translations via Crowdin Bump gsap from 3.5.1 to 3.6.0 (go-gitea#14410) ...

6543 · 2021-01-26T20:13:38Z

@a1012112796 a local git merge --no-ff master && git push should solve this :)

* master: [skip ci] Updated translations via Crowdin Fix bug because of duplicated join (go-gitea#14454) Cron job to cleanup hook_task table (go-gitea#13080) Fix panic 500 page rendering (go-gitea#14474) [skip ci] Updated translations via Crowdin Move macaron to chi (go-gitea#14293) [skip ci] Updated translations via Crowdin Fix incorrect key name so registerManualConfirm setting works as expected. (go-gitea#14455)

6543 · 2021-02-02T15:25:45Z

@a1012112796 would good if you could resolve convlict ;)

* master: (28 commits) [Docs] Clone filters (go-gitea#14555) update docs to show latest stable version (1.13.2) (go-gitea#14550) Adding Chi's GetHead middleware (go-gitea#14541) Changelog v1.13.2 (go-gitea#14535) (go-gitea#14543) [skip ci] Updated translations via Crowdin [API] List, Check, Add & delete endpoints for repository teams (go-gitea#13630) [skip ci] Updated translations via Crowdin rm redirect (go-gitea#14534) Upgrade 'css-minimizer-webpack-plugin' to the latest version (go-gitea#14527) Set the name Mapper in migrations (go-gitea#14526) Internal ssh server respect Ciphers, MACs and KeyExchanges settings (go-gitea#14523) Move middlewares to web/middleware (go-gitea#14480) Add Doctor FixWrongUserType (go-gitea#14522) [skip ci] Updated translations via Crowdin noop (go-gitea#14521) Update docs and comments to remove macaron (go-gitea#14491) [skip ci] Updated translations via Crowdin Fix json charset bug (go-gitea#14514) enhancement: add signoff option in commit form (go-gitea#14516) Fix load time bug (go-gitea#14508) ...

modules/notification/action/action.go

routers/api/v1/repo/pull_review.go

services/pull/review.go

Co-authored-by: zeripath <art27@cantab.net>

* master: (22 commits) Add support for ref parameter to get raw file API (go-gitea#14602) Fixed irritating error message related to go version (go-gitea#14611) Use OldRef instead of CommitSHA for DeleteBranch comments (go-gitea#14604) Add information on how to build statically (go-gitea#14594) [skip ci] Updated translations via Crowdin Exclude the current dump file from the dump (go-gitea#14606) Remove spurious DataAsync Error logging (go-gitea#14599) [API] Add delete release by tag & fix unreleased inconsistency (go-gitea#14563) Fix rate limit bug when downloading assets on migrating from github (go-gitea#14564) [API] Add affected files of commits to commit struct (go-gitea#14579) [skip ci] Updated licenses and gitignores Fix locale init (go-gitea#14582) Add Content-Length header to HEAD requests (go-gitea#14542) Honor REGISTER_MANUAL_CONFIRM when doing openid registration (go-gitea#14548) Fix lfs file viewer (go-gitea#14568) Fix typo in generate-emoji.go (go-gitea#14570) Fix bug about ListOptions and stars/watchers pagnation (go-gitea#14556) Fix gpg key deletion (go-gitea#14561) [API] GetRelease by tag only return release (go-gitea#14397) Reduce data races (go-gitea#14549) ...

6543 · 2021-02-11T17:31:30Z

🚀

a1012112796 added 2 commits September 1, 2020 23:29

Add dismiss review feature

4c5a98f

It's same with github refs: https://github.blog/2016-10-12-dismissing-reviews-on-pull-requests/ https://developer.github.com/v3/pulls/reviews/#dismiss-a-review-for-a-pull-request Signed-off-by: a1012112796 <1012112796@qq.com>

Merge branch 'master' into feature/dismissing_reviews

a45b133

a1012112796 changed the title ~~@a1012112796 Add dismiss review feature~~ Add dismiss review feature Sep 1, 2020

a1012112796 added 3 commits September 1, 2020 23:51

make fmt

58a6148

fix test

2b84a0a

fix test

365fc83

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 1, 2020

bagasme reviewed Sep 2, 2020

View reviewed changes

models/action.go Show resolved Hide resolved

lunny added this to the 1.14.0 milestone Sep 2, 2020

lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Sep 2, 2020

zeripath reviewed Sep 2, 2020

View reviewed changes

a1012112796 added 3 commits September 3, 2020 20:56

change modal ui and error message

8e57c49

Add unDismissReview api

ca6282d

Merge branch 'master' into feature/dismissing_reviews

ab6c402

bagasme approved these changes Sep 7, 2020

View reviewed changes

stale bot added the issue/stale label Nov 7, 2020

stale bot removed the issue/stale label Nov 7, 2020

a1012112796 added 3 commits November 8, 2020 11:54

Merge branch 'master' into feature/dismissing_reviews

b969c85

fix bugs

dbaebf7

fix test

35dedbb

Merge branch 'master' into feature/dismissing_reviews

46cbcc2

6543 reviewed Nov 21, 2020

View reviewed changes

models/review.go Outdated Show resolved Hide resolved

a1012112796 and others added 2 commits January 25, 2021 09:45

Update options/locale/locale_en-US.ini

0feea44

a1012112796 and others added 4 commits January 27, 2021 09:35

fix bug

f323120

Merge branch 'master' into feature/dismissing_reviews

e5bb544

apply suggestion

456db50

6543 approved these changes Jan 28, 2021

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 28, 2021

6543 approved these changes Feb 3, 2021

View reviewed changes

zeripath reviewed Feb 8, 2021

View reviewed changes

modules/notification/action/action.go Show resolved Hide resolved

zeripath reviewed Feb 8, 2021

View reviewed changes

routers/api/v1/repo/pull_review.go Outdated Show resolved Hide resolved

routers/api/v1/repo/pull_review.go Outdated Show resolved Hide resolved

routers/api/v1/repo/pull_review.go Outdated Show resolved Hide resolved

services/pull/review.go Outdated Show resolved Hide resolved

a1012112796 and others added 4 commits February 9, 2021 09:53

Apply suggestions from code review

9b9d7b3

Co-authored-by: zeripath <art27@cantab.net>

fix nit

28a7f96

Merge branch 'master' into feature/dismissing_reviews

91091fa

zeripath approved these changes Feb 10, 2021

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 10, 2021

zeripath and others added 2 commits February 10, 2021 21:29

Merge branch 'master' into feature/dismissing_reviews

02f445a

Merge branch 'master' into feature/dismissing_reviews

5897902

6543 merged commit ac70163 into go-gitea:master Feb 11, 2021

a1012112796 deleted the feature/dismissing_reviews branch February 12, 2021 02:51

go-gitea locked and limited conversation to collaborators May 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add dismiss review feature #12674

Add dismiss review feature #12674

a1012112796 commented Sep 1, 2020 •

edited

Loading

codecov-commenter commented Sep 1, 2020 •

edited

Loading

bagasme commented Sep 3, 2020

a1012112796 commented Sep 3, 2020

bagasme commented Sep 7, 2020

bagasme left a comment

stale bot commented Nov 7, 2020

lafriks commented Nov 7, 2020

lafriks commented Nov 18, 2020

codecov-io commented Nov 20, 2020 •

edited

Loading

lafriks commented Jan 24, 2021

6543 commented Jan 26, 2021

6543 commented Feb 2, 2021

6543 commented Feb 11, 2021

Add dismiss review feature #12674

Add dismiss review feature #12674

Conversation

a1012112796 commented Sep 1, 2020 • edited Loading

codecov-commenter commented Sep 1, 2020 • edited Loading

Codecov Report

bagasme commented Sep 3, 2020

a1012112796 commented Sep 3, 2020

bagasme commented Sep 7, 2020

bagasme left a comment

Choose a reason for hiding this comment

stale bot commented Nov 7, 2020

lafriks commented Nov 7, 2020

lafriks commented Nov 18, 2020

codecov-io commented Nov 20, 2020 • edited Loading

Codecov Report

lafriks commented Jan 24, 2021

6543 commented Jan 26, 2021

6543 commented Feb 2, 2021

6543 commented Feb 11, 2021

a1012112796 commented Sep 1, 2020 •

edited

Loading

codecov-commenter commented Sep 1, 2020 •

edited

Loading

codecov-io commented Nov 20, 2020 •

edited

Loading