Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor freeze when clicking Skeleton node of a glTF scene with 500+ bones #35652

Closed
lmomimi opened this issue Jan 28, 2020 · 3 comments · Fixed by #36409
Closed

Editor freeze when clicking Skeleton node of a glTF scene with 500+ bones #35652

lmomimi opened this issue Jan 28, 2020 · 3 comments · Fixed by #36409

Comments

@lmomimi
Copy link

lmomimi commented Jan 28, 2020

Godot version:
3.2 rc 4

OS/device including version:
macos 10.15.2
Issue description:*
New Game Project.zip

Steps to reproduce:
open BAQIR-RIG.glb click armature_baq node,editor freeze

Minimal reproduction project:

Bugsquad edit (keywords for easier searching): select, selecting, crash

@akien-mga akien-mga changed the title candidate-3-2-rc-4 editer freeze Editor freeze when clicking Skeleton node of a glTF scene with 512 bones Jan 28, 2020
@akien-mga akien-mga changed the title Editor freeze when clicking Skeleton node of a glTF scene with 512 bones Editor freeze when clicking Skeleton node of a glTF scene with 500+ bones Jan 28, 2020
@akien-mga
Copy link
Member

I can confirm the freeze on the master branch on Linux. It likely also happens in earlier versions, it's not a regression.

The attached project has a glTF file with a 514-bones skeleton, and generating the Inspector for all 514 bones is what is taking so much time, eventually exceeding the max MessageQueue size if using the default of 1024. If increased to 4096, it works for me after a temporary freeze of ~1 min, then shows the inspector:
Screenshot_20200128_084101

This is similar to #29238, the Inspector should use paging to avoid creating controls for so many bones.

The deadlock would be fixed by #35653, though it's not a proper fix for this issue.

@akien-mga akien-mga added this to the 4.0 milestone Jan 28, 2020
@fire
Copy link
Member

fire commented Jan 28, 2020

A proper fix would be switching to the tree based editor.

#33871

This missed the Feature Freeze in 2019 Summer.

@slapin
Copy link
Contributor

slapin commented Apr 2, 2020

Yeah confirm this using scene imported from escn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants